feat(bottlecap): handle OOM exceptions #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding trace id and span id so data is not rejected by backend, also added the error
…ion into jordan.gonzalez/bottlecap/timeout-handling
duncanista
changed the base branch from
main
to
jordan.gonzalez/bottlecap/timeout-handling
Base automatically changed from
jordan.gonzalez/bottlecap/timeout-handling
to
main
November 22, 2024 00:24
| Event::OutOfMemory => { | ||
| let mut p = invocation_processor.lock().await; | ||
| p.on_out_of_memory_error(); | ||
| drop(p); |
Contributor
There was a problem hiding this comment.
do we need this explicit drop?
They are all over the place and I think they are useless since it is done automatically at the end of the block
Contributor
Author
There was a problem hiding this comment.
Maybe not on the ones where we have it at the end, we can improve this later
alexgallotta
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Handles OOM exceptions, sending enhanced metric as expected.
Notes
Metrics look iffy, but that's OK, because when the sandbox get's signal-killed, there's no way for us to tell that we got OOM as of now.