Skip to content

Conversation

@astuyve
Copy link
Contributor

@astuyve astuyve commented Jan 22, 2025

Fixes #514 by checking if NO_PROXY contains DD_SITE domain, and the the user is likely relying on privatelink endpoints + private DNS isntead of an HTTP proxy for telemetry data.

This is kind of a hack in 2 ways:

  1. reqwest has some support for NO_PROXY but hyper-proxy doesn't. I could use the built in version, but either way I'd need to build it myself
  2. We simply pass a proxy string to libdatadog for APM + statsd, we don't actually pass config anywhere. So we'd have to add that.

This solution works for the customer reporting it, as their NO_PROXY string includes datadoghq.com.

But I wonder if there's a use case for a customer who would use privatelink for, say metrics only - but then use an HTTP proxy for logs (perhaps to inspect logs for PII or some other form of compliance).

In that case our entire shared http client architecture (complete with shared threadpools) would need to change. I think we should leave that for the future at this time, and help our friends in #514 move on.

Screenshots of my config:
image

VPC endpoints as per our docs:
image

Logs/metrics/traces:
image
image
image

@astuyve astuyve requested a review from a team as a code owner January 22, 2025 18:58
@astuyve astuyve merged commit fff85cc into main Jan 23, 2025
23 checks passed
@astuyve astuyve deleted the aj/honor-noproxy branch January 23, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lambda Extension not properly honoring NO_PROXY env var

3 participants