Skip to content

Commit c3b9e60

Browse files
zarirhamzazarirhamza
authored
Remove Service Override from aws.lambda spans (#666)
* add DD_SERVICE * fix cold_start tag * add env var to disable
1 parent 5d14bc0 commit c3b9e60

13 files changed

+475
-103
lines changed

‎integration_tests/snapshots/logs/esm_node18.log

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ START
7272
"service": "integration-tests-js-XXXX-esm_node18",
7373
"version": "1.0.0",
7474
"runtime-id":"XXXX",
75+
"cold_start": "true",
7576
"function_arn":"XXXX_node18",
7677
"function_version": "$LATEST",
7778
"request_id":"XXXX",
@@ -88,7 +89,6 @@ START
8889
"language": "javascript"
8990
},
9091
"metrics": {
91-
"cold_start": 1,
9292
"_dd.measured": 1,
9393
"process_id":XXXX,
9494
"_sampling_priority_v1": 1
@@ -178,6 +178,7 @@ START
178178
"service": "integration-tests-js-XXXX-esm_node18",
179179
"version": "1.0.0",
180180
"runtime-id":"XXXX",
181+
"cold_start": "false",
181182
"function_arn":"XXXX_node18",
182183
"function_version": "$LATEST",
183184
"request_id":"XXXX",
@@ -191,7 +192,6 @@ START
191192
"language": "javascript"
192193
},
193194
"metrics": {
194-
"cold_start": 0,
195195
"_dd.measured": 1,
196196
"process_id":XXXX,
197197
"_sampling_priority_v1": 1
@@ -281,6 +281,7 @@ START
281281
"service": "integration-tests-js-XXXX-esm_node18",
282282
"version": "1.0.0",
283283
"runtime-id":"XXXX",
284+
"cold_start": "false",
284285
"function_arn":"XXXX_node18",
285286
"function_version": "$LATEST",
286287
"request_id":"XXXX",
@@ -294,7 +295,6 @@ START
294295
"language": "javascript"
295296
},
296297
"metrics": {
297-
"cold_start": 0,
298298
"_dd.measured": 1,
299299
"process_id":XXXX,
300300
"_sampling_priority_v1": 1
@@ -384,6 +384,7 @@ START
384384
"service": "integration-tests-js-XXXX-esm_node18",
385385
"version": "1.0.0",
386386
"runtime-id":"XXXX",
387+
"cold_start": "false",
387388
"function_arn":"XXXX_node18",
388389
"function_version": "$LATEST",
389390
"request_id":"XXXX",
@@ -397,7 +398,6 @@ START
397398
"language": "javascript"
398399
},
399400
"metrics": {
400-
"cold_start": 0,
401401
"_dd.measured": 1,
402402
"process_id":XXXX,
403403
"_sampling_priority_v1": 1
@@ -486,6 +486,7 @@ START
486486
"service": "integration-tests-js-XXXX-esm_node18",
487487
"version": "1.0.0",
488488
"runtime-id":"XXXX",
489+
"cold_start": "false",
489490
"function_arn":"XXXX_node18",
490491
"function_version": "$LATEST",
491492
"request_id":"XXXX",
@@ -499,7 +500,6 @@ START
499500
"language": "javascript"
500501
},
501502
"metrics": {
502-
"cold_start": 0,
503503
"_dd.measured": 1,
504504
"process_id":XXXX,
505505
"_sampling_priority_v1": 1
@@ -588,6 +588,7 @@ START
588588
"service": "integration-tests-js-XXXX-esm_node18",
589589
"version": "1.0.0",
590590
"runtime-id":"XXXX",
591+
"cold_start": "false",
591592
"function_arn":"XXXX_node18",
592593
"function_version": "$LATEST",
593594
"request_id":"XXXX",
@@ -601,7 +602,6 @@ START
601602
"language": "javascript"
602603
},
603604
"metrics": {
604-
"cold_start": 0,
605605
"_dd.measured": 1,
606606
"process_id":XXXX,
607607
"_sampling_priority_v1": 1
@@ -690,6 +690,7 @@ START
690690
"service": "integration-tests-js-XXXX-esm_node18",
691691
"version": "1.0.0",
692692
"runtime-id":"XXXX",
693+
"cold_start": "false",
693694
"function_arn":"XXXX_node18",
694695
"function_version": "$LATEST",
695696
"request_id":"XXXX",
@@ -703,7 +704,6 @@ START
703704
"language": "javascript"
704705
},
705706
"metrics": {
706-
"cold_start": 0,
707707
"_dd.measured": 1,
708708
"process_id":XXXX,
709709
"_sampling_priority_v1": 1
@@ -791,6 +791,7 @@ START
791791
"service": "integration-tests-js-XXXX-esm_node18",
792792
"version": "1.0.0",
793793
"runtime-id":"XXXX",
794+
"cold_start": "false",
794795
"function_arn":"XXXX_node18",
795796
"function_version": "$LATEST",
796797
"request_id":"XXXX",
@@ -804,7 +805,6 @@ START
804805
"language": "javascript"
805806
},
806807
"metrics": {
807-
"cold_start": 0,
808808
"_dd.measured": 1,
809809
"process_id":XXXX,
810810
"_sampling_priority_v1": 1
@@ -891,6 +891,7 @@ START
891891
"service": "integration-tests-js-XXXX-esm_node18",
892892
"version": "1.0.0",
893893
"runtime-id":"XXXX",
894+
"cold_start": "false",
894895
"function_arn":"XXXX_node18",
895896
"function_version": "$LATEST",
896897
"request_id":"XXXX",
@@ -904,7 +905,6 @@ START
904905
"language": "javascript"
905906
},
906907
"metrics": {
907-
"cold_start": 0,
908908
"_dd.measured": 1,
909909
"process_id":XXXX,
910910
"_sampling_priority_v1": 1

‎integration_tests/snapshots/logs/esm_node20.log

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ START
7272
"service": "integration-tests-js-XXXX-esm_node20",
7373
"version": "1.0.0",
7474
"runtime-id":"XXXX",
75+
"cold_start": "true",
7576
"function_arn":"XXXX_node20",
7677
"function_version": "$LATEST",
7778
"request_id":"XXXX",
@@ -88,7 +89,6 @@ START
8889
"language": "javascript"
8990
},
9091
"metrics": {
91-
"cold_start": 1,
9292
"_dd.measured": 1,
9393
"process_id":XXXX,
9494
"_sampling_priority_v1": 1
@@ -178,6 +178,7 @@ START
178178
"service": "integration-tests-js-XXXX-esm_node20",
179179
"version": "1.0.0",
180180
"runtime-id":"XXXX",
181+
"cold_start": "false",
181182
"function_arn":"XXXX_node20",
182183
"function_version": "$LATEST",
183184
"request_id":"XXXX",
@@ -191,7 +192,6 @@ START
191192
"language": "javascript"
192193
},
193194
"metrics": {
194-
"cold_start": 0,
195195
"_dd.measured": 1,
196196
"process_id":XXXX,
197197
"_sampling_priority_v1": 1
@@ -281,6 +281,7 @@ START
281281
"service": "integration-tests-js-XXXX-esm_node20",
282282
"version": "1.0.0",
283283
"runtime-id":"XXXX",
284+
"cold_start": "false",
284285
"function_arn":"XXXX_node20",
285286
"function_version": "$LATEST",
286287
"request_id":"XXXX",
@@ -294,7 +295,6 @@ START
294295
"language": "javascript"
295296
},
296297
"metrics": {
297-
"cold_start": 0,
298298
"_dd.measured": 1,
299299
"process_id":XXXX,
300300
"_sampling_priority_v1": 1
@@ -384,6 +384,7 @@ START
384384
"service": "integration-tests-js-XXXX-esm_node20",
385385
"version": "1.0.0",
386386
"runtime-id":"XXXX",
387+
"cold_start": "false",
387388
"function_arn":"XXXX_node20",
388389
"function_version": "$LATEST",
389390
"request_id":"XXXX",
@@ -397,7 +398,6 @@ START
397398
"language": "javascript"
398399
},
399400
"metrics": {
400-
"cold_start": 0,
401401
"_dd.measured": 1,
402402
"process_id":XXXX,
403403
"_sampling_priority_v1": 1
@@ -486,6 +486,7 @@ START
486486
"service": "integration-tests-js-XXXX-esm_node20",
487487
"version": "1.0.0",
488488
"runtime-id":"XXXX",
489+
"cold_start": "false",
489490
"function_arn":"XXXX_node20",
490491
"function_version": "$LATEST",
491492
"request_id":"XXXX",
@@ -499,7 +500,6 @@ START
499500
"language": "javascript"
500501
},
501502
"metrics": {
502-
"cold_start": 0,
503503
"_dd.measured": 1,
504504
"process_id":XXXX,
505505
"_sampling_priority_v1": 1
@@ -588,6 +588,7 @@ START
588588
"service": "integration-tests-js-XXXX-esm_node20",
589589
"version": "1.0.0",
590590
"runtime-id":"XXXX",
591+
"cold_start": "false",
591592
"function_arn":"XXXX_node20",
592593
"function_version": "$LATEST",
593594
"request_id":"XXXX",
@@ -601,7 +602,6 @@ START
601602
"language": "javascript"
602603
},
603604
"metrics": {
604-
"cold_start": 0,
605605
"_dd.measured": 1,
606606
"process_id":XXXX,
607607
"_sampling_priority_v1": 1
@@ -690,6 +690,7 @@ START
690690
"service": "integration-tests-js-XXXX-esm_node20",
691691
"version": "1.0.0",
692692
"runtime-id":"XXXX",
693+
"cold_start": "false",
693694
"function_arn":"XXXX_node20",
694695
"function_version": "$LATEST",
695696
"request_id":"XXXX",
@@ -703,7 +704,6 @@ START
703704
"language": "javascript"
704705
},
705706
"metrics": {
706-
"cold_start": 0,
707707
"_dd.measured": 1,
708708
"process_id":XXXX,
709709
"_sampling_priority_v1": 1
@@ -791,6 +791,7 @@ START
791791
"service": "integration-tests-js-XXXX-esm_node20",
792792
"version": "1.0.0",
793793
"runtime-id":"XXXX",
794+
"cold_start": "false",
794795
"function_arn":"XXXX_node20",
795796
"function_version": "$LATEST",
796797
"request_id":"XXXX",
@@ -804,7 +805,6 @@ START
804805
"language": "javascript"
805806
},
806807
"metrics": {
807-
"cold_start": 0,
808808
"_dd.measured": 1,
809809
"process_id":XXXX,
810810
"_sampling_priority_v1": 1
@@ -891,6 +891,7 @@ START
891891
"service": "integration-tests-js-XXXX-esm_node20",
892892
"version": "1.0.0",
893893
"runtime-id":"XXXX",
894+
"cold_start": "false",
894895
"function_arn":"XXXX_node20",
895896
"function_version": "$LATEST",
896897
"request_id":"XXXX",
@@ -904,7 +905,6 @@ START
904905
"language": "javascript"
905906
},
906907
"metrics": {
907-
"cold_start": 0,
908908
"_dd.measured": 1,
909909
"process_id":XXXX,
910910
"_sampling_priority_v1": 1

0 commit comments

Comments
 (0)