Skip to content

Commit 5796f69

Browse files
fixes
1 parent 8bcd77f commit 5796f69

File tree

2 files changed

+50
-1
lines changed

2 files changed

+50
-1
lines changed

datadog_lambda/dsm.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ def _dsm_set_kinesis_context(event):
6868
if not context_json:
6969
logger.debug("DataStreams skipped lambda message: %r", record)
7070
return None
71-
7271
carrier_get = _create_carrier_get(context_json)
7372
set_consume_checkpoint("kinesis", arn, carrier_get)
7473

@@ -78,10 +77,21 @@ def _get_dsm_context_from_lambda(message):
7877
Lambda-specific message formats:
7978
- message.messageAttributes._datadog.stringValue (SQS -> lambda)
8079
- message.Sns.MessageAttributes._datadog.Value.decode() (SNS -> lambda)
80+
- message.kinesis.data.decode()._datadog (Kinesis -> lambda)
8181
"""
8282
context_json = None
8383
message_body = message
8484

85+
if "kinesis" in message:
86+
try:
87+
kinesis_data = json.loads(
88+
base64.b64decode(message["kinesis"]["data"]).decode()
89+
)
90+
return kinesis_data.get("_datadog")
91+
except (ValueError, TypeError, KeyError):
92+
logger.debug("Unable to parse kinesis data for lambda message")
93+
return None
94+
8595
if "Sns" in message:
8696
message_body = message["Sns"]
8797

tests/test_dsm.py

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,45 @@ def test_sns_to_lambda_format(self):
451451
assert result["x-datadog-parent-id"] == "222222222"
452452
assert result["dd-pathway-ctx"] == "test-pathway-ctx"
453453

454+
def test_kinesis_to_lambda_format(self):
455+
"""Test format: message.kinesis.data.decode()._datadog (Kinesis -> lambda)"""
456+
trace_context = {
457+
"x-datadog-trace-id": "555444333",
458+
"x-datadog-parent-id": "888777666",
459+
"dd-pathway-ctx": "test-pathway-ctx",
460+
}
461+
462+
# Create the kinesis data payload
463+
kinesis_payload = {
464+
"_datadog": trace_context,
465+
"actualData": "some business data",
466+
}
467+
encoded_kinesis_data = base64.b64encode(
468+
json.dumps(kinesis_payload).encode("utf-8")
469+
).decode("utf-8")
470+
471+
kinesis_lambda_record = {
472+
"eventSource": "aws:kinesis",
473+
"eventSourceARN": (
474+
"arn:aws:kinesis:us-east-1:123456789012:stream/my-stream"
475+
),
476+
"kinesis": {
477+
"data": encoded_kinesis_data,
478+
"partitionKey": "partition-key-1",
479+
"sequenceNumber": (
480+
"49590338271490256608559692538361571095921575989136588898"
481+
),
482+
},
483+
}
484+
485+
result = _get_dsm_context_from_lambda(kinesis_lambda_record)
486+
487+
assert result is not None
488+
assert result == trace_context
489+
assert result["x-datadog-trace-id"] == "555444333"
490+
assert result["x-datadog-parent-id"] == "888777666"
491+
assert result["dd-pathway-ctx"] == "test-pathway-ctx"
492+
454493
def test_no_message_attributes(self):
455494
"""Test message without MessageAttributes returns None."""
456495
message = {

0 commit comments

Comments
 (0)