Skip to content

Commit ab8c871

Browse files
moved %r to the end of message
1 parent 2509fcc commit ab8c871

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

datadog_lambda/dsm.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,15 @@ def _get_dsm_context_from_sqs_lambda(message):
4343
message_attributes = message.get("messageAttributes")
4444
if not message_attributes:
4545
logger.debug(
46-
"DataStreams skipped lambda message: %r, no messageAttributes", message
46+
"DataStreams skipped lambda message, no messageAttributes, message: %r",
47+
message,
4748
)
4849
return None
4950

5051
if "_datadog" not in message_attributes:
5152
logger.debug(
52-
"DataStreams skipped lambda message: %r, no datadog context", message
53+
"DataStreams skipped lambda message, no datadog context, message: %r",
54+
message,
5355
)
5456
return None
5557

@@ -59,13 +61,14 @@ def _get_dsm_context_from_sqs_lambda(message):
5961
context_json = json.loads(datadog_attr["stringValue"])
6062
if not isinstance(context_json, dict):
6163
logger.debug(
62-
"DataStreams did not handle lambda message: %r, context is not a dict",
64+
"DataStreams did not handle lambda message, context is not a dict, message: %r",
6365
message,
6466
)
6567
return None
6668
else:
6769
logger.debug(
68-
"DataStreams did not handle lambda message: %r, no dsm context", message
70+
"DataStreams did not handle lambda message, no dsm context, message: %r",
71+
message,
6972
)
7073

7174
return context_json

tests/test_dsm.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def test_debug_logging_for_skipped_messages(self):
205205

206206
assert result is None
207207
self.mock_logger.debug.assert_called_with(
208-
"DataStreams skipped lambda message: %r, no messageAttributes",
208+
"DataStreams skipped lambda message, no messageAttributes, message: %r",
209209
message_no_attrs,
210210
)
211211

@@ -222,7 +222,7 @@ def test_debug_logging_for_skipped_messages(self):
222222

223223
assert result is None
224224
self.mock_logger.debug.assert_called_with(
225-
"DataStreams skipped lambda message: %r, no datadog context",
225+
"DataStreams skipped lambda message, no datadog context, message: %r",
226226
message_no_datadog,
227227
)
228228

@@ -239,7 +239,7 @@ def test_debug_logging_for_skipped_messages(self):
239239

240240
assert result is None
241241
self.mock_logger.debug.assert_called_with(
242-
"DataStreams did not handle lambda message: %r, context is not a dict",
242+
"DataStreams did not handle lambda message, context is not a dict, message: %r",
243243
message_not_dict,
244244
)
245245

0 commit comments

Comments
 (0)