Skip to content

Commit f0a7d88

Browse files
add logger check in exception test cases
1 parent 3bbdb88 commit f0a7d88

File tree

1 file changed

+29
-5
lines changed

1 file changed

+29
-5
lines changed

tests/test_tracing.py

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import os
88
import unittest
99

10-
from unittest.mock import Mock, patch, call
10+
from unittest.mock import Mock, patch, call, ANY
1111

1212
import ddtrace
1313

@@ -2605,8 +2605,9 @@ def test_sqs_no_DSM_context_in_message_attribute(self, mock_dsm_set_checkpoint):
26052605
assert carrier_get("dd-pathway-ctx-base64") is None
26062606

26072607
@patch("datadog_lambda.tracing._dsm_set_checkpoint")
2608+
@patch("datadog_lambda.tracing.logger")
26082609
def test_sqs_invalid_datadog_message_attribute_raises_exception(
2609-
self, mock_dsm_set_checkpoint
2610+
self, mock_logger, mock_dsm_set_checkpoint
26102611
):
26112612
event = {
26122613
"Records": [
@@ -2626,6 +2627,11 @@ def test_sqs_invalid_datadog_message_attribute_raises_exception(
26262627
extract_context_from_sqs_or_sns_event_or_context(
26272628
event, self.lambda_context, parse_event_source(event)
26282629
)
2630+
# Exception handled by logger
2631+
mock_logger.debug.assert_any_call(
2632+
"The trace extractor returned with error %s",
2633+
ANY,
2634+
)
26292635
# None indiciates no DSM context propagation
26302636
mock_dsm_set_checkpoint.assert_called_once_with(
26312637
None, "sqs", "arn:aws:sqs:us-east-1:123456789012:test-queue"
@@ -2829,8 +2835,9 @@ def test_sns_no_DSM_context_in_message_attribute(self, mock_dsm_set_checkpoint):
28292835
assert carrier_get("dd-pathway-ctx-base64") is None
28302836

28312837
@patch("datadog_lambda.tracing._dsm_set_checkpoint")
2838+
@patch("datadog_lambda.tracing.logger")
28322839
def test_sns_invalid_datadog_message_attribute_raises_exception(
2833-
self, mock_dsm_set_checkpoint
2840+
self, mock_logger, mock_dsm_set_checkpoint
28342841
):
28352842
event = {
28362843
"Records": [
@@ -2852,6 +2859,11 @@ def test_sns_invalid_datadog_message_attribute_raises_exception(
28522859
extract_context_from_sqs_or_sns_event_or_context(
28532860
event, self.lambda_context, parse_event_source(event)
28542861
)
2862+
# Exception handled by logger
2863+
mock_logger.debug.assert_any_call(
2864+
"The trace extractor returned with error %s",
2865+
ANY,
2866+
)
28552867
# None indiciates no DSM context propagation
28562868
mock_dsm_set_checkpoint.assert_called_once_with(
28572869
None, "sns", "arn:aws:sns:us-east-1:123456789012:test-topic"
@@ -3088,8 +3100,9 @@ def test_sns_to_sqs_no_DSM_context_in_message_attribute(
30883100
assert carrier_get("dd-pathway-ctx-base64") is None
30893101

30903102
@patch("datadog_lambda.tracing._dsm_set_checkpoint")
3103+
@patch("datadog_lambda.tracing.logger")
30913104
def test_sns_to_sqs_invalid_datadog_message_attribute_raises_exception(
3092-
self, mock_dsm_set_checkpoint
3105+
self, mock_logger, mock_dsm_set_checkpoint
30933106
):
30943107
sns_notification = {
30953108
"Type": "Notification",
@@ -3113,6 +3126,11 @@ def test_sns_to_sqs_invalid_datadog_message_attribute_raises_exception(
31133126
extract_context_from_sqs_or_sns_event_or_context(
31143127
event, self.lambda_context, parse_event_source(event)
31153128
)
3129+
# Exception handled by logger
3130+
mock_logger.debug.assert_any_call(
3131+
"The trace extractor returned with error %s",
3132+
ANY,
3133+
)
31163134
# None indiciates no DSM context propagation
31173135
mock_dsm_set_checkpoint.assert_called_once_with(
31183136
None, "sqs", "arn:aws:sqs:us-east-1:123456789012:test-queue"
@@ -3247,8 +3265,9 @@ def test_kinesis_empty_message_attribute(self, mock_dsm_set_checkpoint):
32473265
)
32483266

32493267
@patch("datadog_lambda.tracing._dsm_set_checkpoint")
3268+
@patch("datadog_lambda.tracing.logger")
32503269
def test_kinesis_invalid_datadog_message_attribute_raises_exception(
3251-
self, mock_dsm_set_checkpoint
3270+
self, mock_logger, mock_dsm_set_checkpoint
32523271
):
32533272
event = {
32543273
"Records": [
@@ -3260,6 +3279,11 @@ def test_kinesis_invalid_datadog_message_attribute_raises_exception(
32603279
}
32613280

32623281
extract_context_from_kinesis_event(event, self.lambda_context)
3282+
# Exception handled by logger
3283+
mock_logger.debug.assert_any_call(
3284+
"The trace extractor returned with error %s",
3285+
ANY,
3286+
)
32633287
# None indiciates no DSM context propagation
32643288
mock_dsm_set_checkpoint.assert_called_once_with(
32653289
None, "kinesis", "arn:aws:kinesis:us-east-1:123456789012:stream/test-stream"

0 commit comments

Comments
 (0)