Skip to content

Commit 3a01859

Browse files
authored
fix hasChannelStoreMethods method, node >= 21 checks (#8)
1 parent f6086b3 commit 3a01859

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/pull-request.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ jobs:
8080
- 20.5.1 # sync unsubscribe bug
8181
- 20.6.0 # sync unsubscribe bug fixed
8282
- 20.x # nothing special, full support dc, latest 20
83+
- 21.0.0 # nothing special, full support dc, first 21
84+
- 21.x # nothing special, full support dc, latest 21
8385
steps:
8486
- uses: actions/checkout@v2
8587
- uses: actions/setup-node@v1

checks.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module.exports.MINOR = MINOR;
44
module.exports.PATCH = PATCH;
55

66
function hasFullSupport() {
7-
return MAJOR >= 20 && MINOR >= 6;
7+
return MAJOR > 20 || (MAJOR >= 20 && MINOR >= 6);
88
}
99
module.exports.hasFullSupport = hasFullSupport;
1010

@@ -38,7 +38,7 @@ function hasZeroSubscribersBug() {
3838
module.exports.hasZeroSubscribersBug = hasZeroSubscribersBug;
3939

4040
function hasChannelStoreMethods() {
41-
return MAJOR === 20
41+
return MAJOR >= 20
4242
|| (MAJOR === 19 && MINOR >= 9);
4343
}
4444
module.exports.hasChannelStoreMethods = hasChannelStoreMethods;

0 commit comments

Comments
 (0)