Skip to content

[kafka] Bump kafka-python to 1.3.1#2863

Closed
jeffwidman wants to merge 1 commit intoDataDog:masterfrom
jeffwidman:bumpkafka
Closed

[kafka] Bump kafka-python to 1.3.1#2863
jeffwidman wants to merge 1 commit intoDataDog:masterfrom
jeffwidman:bumpkafka

Conversation

@jeffwidman
Copy link
Contributor

@jeffwidman jeffwidman commented Sep 26, 2016

What does this PR do?

Bumps kafka-python 1.3.1.

Motivation

There's a number of bug fixes and issues since the 1.2.5 release. Similar to #2709, if you're bumping the version in the newest release of the agent, might as well bump it up to 1.3 series.

@jeffwidman jeffwidman changed the title [core] Bump kafka-python to 1.3.1 [kafka] Bump kafka-python to 1.3.1 Sep 26, 2016
@olivielpeau
Copy link
Member

Hi @jeffwidman and thanks for opening this PR!

I've tested the lib upgrade with the current kafka_consumer check and it looks like it's working nicely.

Could you also open a PR against omnibus-software to update the version shipped with the packaged Agent? (https://github.com/DataDog/omnibus-software/blob/5.9.1/config/software/kafka-python.rb#L2)

Thanks!

@jeffwidman
Copy link
Contributor Author

jeffwidman commented Oct 19, 2016

Done in DataDog/omnibus-software#78

Also, when you get a chance, the kafka/datadog PR that really matters to me is #2880 as we're using it in production and obviously prefer not to maintain a separate patch.

Thanks!

@jeffwidman
Copy link
Contributor Author

jeffwidman commented Oct 26, 2016

@olivielpeau anything else you need from me on this?

@jeffwidman
Copy link
Contributor Author

Any update on this?

@olivielpeau
Copy link
Member

@jeffwidman sorry for reacting only now. Looks like your PR has conflicts now, could you either give us push permissions on your branch or resolve the conflict yourself? Thanks!

@jeffwidman
Copy link
Contributor Author

jeffwidman commented Dec 23, 2016

I deleted the original branch, so unfortunately not possible for me to rebase (as far as I'm aware) and there's no checkbox to allow edits from maintainers. So closing and continuing in #3097

@jeffwidman jeffwidman closed this Dec 23, 2016
olivielpeau pushed a commit that referenced this pull request Dec 26, 2016
Another take on #2863 because I deleted the original branch
olivielpeau pushed a commit to DataDog/omnibus-software that referenced this pull request Dec 26, 2016
There's a number of bug fixes and issues since the 1.2.5 release.

Details in DataDog/dd-agent#2863
@masci masci modified the milestones: 5.11.0, 5.12.0 Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants