Skip to content

Commit c426bb0

Browse files
committed
Document expected values for class/field/method access modifiers
1 parent a5c6d43 commit c426bb0

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

class-match/src/main/java/datadog/instrument/classmatch/ClassHeader.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,12 @@
99
/** Minimal class header that describes its access modifiers and immediate class hierarchy. */
1010
public class ClassHeader {
1111

12-
/** Access modifiers for this class. */
12+
/**
13+
* Access modifiers for this class.
14+
*
15+
* @see <a href="https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.1-200-E.1">
16+
* Expected values</a>
17+
*/
1318
public final int access;
1419

1520
/** Internal name of this class. */

class-match/src/main/java/datadog/instrument/classmatch/FieldOutline.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,12 @@
1111
/** Outlines a field; access modifiers, field name, descriptor. */
1212
public final class FieldOutline {
1313

14-
/** Access modifiers for this field. */
14+
/**
15+
* Access modifiers for this field.
16+
*
17+
* @see <a href="https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.5-200-A.1">
18+
* Expected values</a>
19+
*/
1520
public final int access;
1621

1722
/** Name of this field. */

class-match/src/main/java/datadog/instrument/classmatch/MethodOutline.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,12 @@
1212
/** Outlines a method; access modifiers, method name, descriptor, annotations. */
1313
public final class MethodOutline {
1414

15-
/** Access modifiers for this method. */
15+
/**
16+
* Access modifiers for this method.
17+
*
18+
* @see <a href="https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.6-200-A.1">
19+
* Expected values</a>
20+
*/
1621
public final int access;
1722

1823
/** Name of this method. */

0 commit comments

Comments
 (0)