Skip to content

Commit 0817c4d

Browse files
committed
RUM-12635: Adding experimental annotation for cronet engine wrapper
1 parent f600f1e commit 0817c4d

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

integrations/dd-sdk-android-cronet/src/main/kotlin/com/datadog/android/cronet/DatadogCronetEngine.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ package com.datadog.android.cronet
88
import android.content.Context
99
import com.datadog.android.cronet.internal.DatadogRequestFinishedInfoListener
1010
import com.datadog.android.cronet.internal.DatadogUrlRequestBuilder
11+
import com.datadog.android.rum.ExperimentalRumApi
1112
import com.datadog.android.rum.NoOpRumResourceAttributesProvider
1213
import com.datadog.android.rum.RumResourceAttributesProvider
1314
import com.datadog.android.rum.internal.net.RumResourceInstrumentation
@@ -49,7 +50,7 @@ class DatadogCronetEngine(
4950
* Builder wrapper for [CronetEngine] that adds Datadog instrumentation.
5051
* Datadog's instrumentation for Cronet is made using delegating instead of inheritance in order to make possible
5152
* for the customers to add several instrumentations at the same time. The [delegate] could be the pure
52-
* [Cronet.Builder] instance or another wrapper, provided by different vendor.
53+
* [CronetEngine.Builder] instance or another wrapper, provided by different vendor.
5354
*/
5455
@Suppress("TooManyFunctions") // The amount of functions is depend on Cronet
5556
class Builder : CronetEngine.Builder {
@@ -61,6 +62,7 @@ class DatadogCronetEngine(
6162
* @param iCronetEngineBuilder - an instance [ICronetEngineBuilder] usually made from [Context].
6263
* @param delegate - the delegate builder to wrap, defaults to a new CronetEngine.Builder
6364
*/
65+
@ExperimentalRumApi
6466
internal constructor(
6567
iCronetEngineBuilder: ICronetEngineBuilder,
6668
delegate: CronetEngine.Builder = CronetEngine.Builder(iCronetEngineBuilder)
@@ -75,6 +77,7 @@ class DatadogCronetEngine(
7577
* @param delegate the delegate builder to wrap in case if several wrappers should be used,
7678
* defaults to a new CronetEngine.Builder
7779
*/
80+
@ExperimentalRumApi
7881
constructor(
7982
context: Context,
8083
delegate: CronetEngine.Builder = CronetEngine.Builder(context)

sample/kotlin/src/main/kotlin/com/datadog/android/sample/cronet/CronetImageFragment.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import android.widget.ImageView
1515
import android.widget.Toast
1616
import androidx.fragment.app.Fragment
1717
import com.datadog.android.cronet.DatadogCronetEngine
18+
import com.datadog.android.rum.ExperimentalRumApi
1819
import com.datadog.android.sample.R
1920
import org.chromium.net.CronetEngine
2021
import org.chromium.net.CronetException
@@ -40,6 +41,7 @@ internal class CronetImageFragment : Fragment() {
4041
"https://storage.googleapis.com/cronet/walnut.jpg"
4142
)
4243

44+
@OptIn(ExperimentalRumApi::class)
4345
override fun onCreateView(
4446
inflater: LayoutInflater,
4547
container: ViewGroup?,

0 commit comments

Comments
 (0)