Skip to content

Commit 0862c56

Browse files
committed
RUM-10930: dogfood experiment - condition for partial flush now same as in AndroidTracer
1 parent 64c07b6 commit 0862c56

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

features/dd-sdk-android-trace-internal/src/main/java/com/datadog/trace/core/PendingTrace.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ private PublishState decrementRefAndMaybeWrite(boolean isRootSpan) {
331331
// Finished root with pending work ... delay write
332332
pendingTraceBuffer.enqueue(this);
333333
return PublishState.ROOT_BUFFERED;
334-
} else if (partialFlushMinSpans > 0 && size() >= partialFlushMinSpans) {
334+
} else if (partialFlushMinSpans > 0 && size() > partialFlushMinSpans) {
335335
// Trace is getting too big, write anything completed.
336336
partialFlush();
337337
return PublishState.PARTIAL_FLUSH;

features/dd-sdk-android-trace-internal/src/test/kotlin/com/datadog/trace/core/PendingTraceTestBase.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ internal abstract class PendingTraceTestBase : DDCoreSpecification() {
144144
@Test
145145
fun `partial flush`() {
146146
// Given
147-
val quickTracer = tracerBuilder().writer(writer).partialFlushMinSpans(2).build()
147+
val quickTracer = tracerBuilder().writer(writer).partialFlushMinSpans(1).build()
148148
val rootSpan = quickTracer.buildSpan(instrumentationName, "root").start() as DDSpan
149149
val trace = rootSpan.context().trace as PendingTrace
150150
val child1 = quickTracer.buildSpan(instrumentationName, "child1")
@@ -192,7 +192,7 @@ internal abstract class PendingTraceTestBase : DDCoreSpecification() {
192192
@Test
193193
fun `partial flush with root span closed last`() {
194194
// Given
195-
val quickTracer = tracerBuilder().writer(writer).partialFlushMinSpans(2).build() as CoreTracer
195+
val quickTracer = tracerBuilder().writer(writer).partialFlushMinSpans(1).build() as CoreTracer
196196
val rootSpan = quickTracer.buildSpan(instrumentationName, "root").start() as DDSpan
197197
val trace = rootSpan.context().trace
198198
val child1 = quickTracer

0 commit comments

Comments
 (0)