RUM-10422: Handle the case when DatadogContext is requested when SDK is getting deinitialized

Author: 0xnm

dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/SdkFeature.kt

@@ -177,6 +177,7 @@ internal class SdkFeature(
     ) {
         coreFeature.contextExecutorService
             .executeSafe("withWriteContext-${wrappedFeature.name}", internalLogger) {
+                if (coreFeature.initialized.get() == false) return@executeSafe
                 val context = contextProvider.getContext(withFeatureContexts)
                 val eventBatchWriteScope = storage.getEventWriteScope(context)
                 callback(context, eventBatchWriteScope)
@@ -189,6 +190,7 @@ internal class SdkFeature(
     ) {
         coreFeature.contextExecutorService
             .executeSafe("withContext-${wrappedFeature.name}", internalLogger) {
+                if (coreFeature.initialized.get() == false) return@executeSafe
                 val context = contextProvider.getContext(withFeatureContexts)
                 callback(context)
             }
@@ -203,6 +205,7 @@ internal class SdkFeature(
                 operationName,
                 internalLogger,
                 Callable {
+                    if (coreFeature.initialized.get() == false) return@Callable null
                     val context = contextProvider.getContext(withFeatureContexts)
                     val eventBatchWriteScope = storage.getEventWriteScope(context)
                     context to eventBatchWriteScope

dd-sdk-android-core/src/test/kotlin/com/datadog/android/core/internal/SdkFeatureTest.kt

@@ -78,6 +78,7 @@ import org.mockito.kotlin.doThrow
 import org.mockito.kotlin.eq
 import org.mockito.kotlin.mock
 import org.mockito.kotlin.verify
+import org.mockito.kotlin.verifyNoInteractions
 import org.mockito.kotlin.whenever
 import org.mockito.quality.Strictness
 import java.util.Locale
@@ -86,6 +87,7 @@ import java.util.concurrent.CancellationException
 import java.util.concurrent.ExecutionException
 import java.util.concurrent.Future
 import java.util.concurrent.RejectedExecutionException
+import java.util.concurrent.atomic.AtomicBoolean
 
 @Extensions(
     ExtendWith(MockitoExtension::class),
@@ -144,6 +146,7 @@ internal class SdkFeatureTest {
         whenever(coreFeature.mockInstance.batchProcessingLevel)
             .thenReturn(fakeCoreBatchProcessingLevel)
         whenever(coreFeature.mockTrackingConsentProvider.getConsent()) doReturn fakeConsent
+        whenever(coreFeature.mockInstance.initialized) doReturn AtomicBoolean(true)
         whenever(mockWrappedFeature.name) doReturn fakeFeatureName
         whenever(mockWrappedFeature.requestFactory) doReturn mock()
         whenever(mockWrappedFeature.storageConfiguration) doReturn fakeStorageConfiguration
@@ -512,6 +515,22 @@ internal class SdkFeatureTest {
         )
     }
 
+    @Test
+    fun `M not provide write context W withWriteContext(callback) { CoreFeature is not initialized }`(
+        @StringForgery fakeWithFeatureContexts: Set<String>
+    ) {
+        // Given
+        testedFeature.storage = mockStorage
+        val callback = mock<(DatadogContext, EventWriteScope) -> Unit>()
+        whenever(coreFeature.mockInstance.initialized) doReturn AtomicBoolean(false)
+
+        // When
+        testedFeature.withWriteContext(fakeWithFeatureContexts, callback = callback)
+
+        // Then
+        verifyNoInteractions(callback, mockContextProvider, mockStorage)
+    }
+
     @Test
     fun `M provide Datadog context W withContext(callback)`(
         @Forgery fakeContext: DatadogContext,
@@ -529,6 +548,22 @@ internal class SdkFeatureTest {
         verify(callback).invoke(fakeContext)
     }
 
+    @Test
+    fun `M not provide Datadog context W withContext(callback) { CoreFeature is not initialized }`(
+        @StringForgery fakeWithFeatureContexts: Set<String>
+    ) {
+        // Given
+        testedFeature.storage = mockStorage
+        val callback = mock<(DatadogContext) -> Unit>()
+        whenever(coreFeature.mockInstance.initialized) doReturn AtomicBoolean(false)
+
+        // When
+        testedFeature.withContext(fakeWithFeatureContexts, callback = callback)
+
+        // Then
+        verifyNoInteractions(callback, mockContextProvider)
+    }
+
     @Test
     fun `M provide write context W getWriteContextSync()`(
         @Forgery fakeContext: DatadogContext,
@@ -610,6 +645,19 @@ internal class SdkFeatureTest {
         assertThat(writeContext).isNull()
     }
 
+    @Test
+    fun `M provide null write context W getWriteContextSync() { CoreFeature is not initialized }`() {
+        // Given
+        whenever(coreFeature.mockInstance.initialized) doReturn AtomicBoolean(false)
+
+        // When
+        val writeContext = testedFeature.getWriteContextSync()
+
+        // Then
+        assertThat(writeContext).isNull()
+        verifyNoInteractions(mockContextProvider, mockStorage)
+    }
+
     @Test
     fun `M send event W sendEvent(event)`() {
         // Given