Skip to content

Commit 28504a1

Browse files
authored
Merge pull request #2617 from DataDog/mconstantin/rum-9410/investigate-itv-logic
RUM-9410 Remove the noisy warning log as for some views is normal to not have itv
2 parents 2e24bf5 + 0ec7861 commit 28504a1

File tree

2 files changed

+0
-24
lines changed

2 files changed

+0
-24
lines changed

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/metric/interactiontonextview/InteractionToNextViewMetricResolver.kt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,6 @@ internal class InteractionToNextViewMetricResolver(
6868
return null
6969
}
7070
}
71-
// in case there are no previous interactions for this view and there's only one view created
72-
// we are probably in the first view of the app (AppLaunch) and we can't calculate the metric
73-
if (lastViewCreatedTimestamps.size > 1) {
74-
internalLogger.log(
75-
InternalLogger.Level.WARN,
76-
InternalLogger.Target.MAINTAINER,
77-
{ "[ViewNetworkSettledMetric] No previous interaction found for this viewId:$viewId" }
78-
)
79-
}
8071
return null
8172
}
8273

features/dd-sdk-android-rum/src/test/kotlin/com/datadog/android/rum/internal/metric/interactiontonextview/InteractionToNextViewMetricResolverTest.kt

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,6 @@ internal class InteractionToNextViewMetricResolverTest {
283283

284284
// Then
285285
assertThat(result).isNull()
286-
mockInternalLogger.verifyLog(
287-
InternalLogger.Level.WARN,
288-
InternalLogger.Target.MAINTAINER,
289-
"[ViewNetworkSettledMetric] No previous interaction found for this viewId:$fakeViewId"
290-
)
291286
}
292287

293288
@Test
@@ -317,11 +312,6 @@ internal class InteractionToNextViewMetricResolverTest {
317312

318313
// Then
319314
assertThat(result).isNull()
320-
mockInternalLogger.verifyLog(
321-
InternalLogger.Level.WARN,
322-
InternalLogger.Target.MAINTAINER,
323-
"[ViewNetworkSettledMetric] No previous interaction found for this viewId:$fakeViewId"
324-
)
325315
}
326316

327317
@Test
@@ -339,11 +329,6 @@ internal class InteractionToNextViewMetricResolverTest {
339329

340330
// Then
341331
assertThat(result).isNull()
342-
mockInternalLogger.verifyLog(
343-
InternalLogger.Level.WARN,
344-
InternalLogger.Target.MAINTAINER,
345-
"[ViewNetworkSettledMetric] No previous interaction found for this viewId:$fakeViewId"
346-
)
347332
}
348333

349334
@Test

0 commit comments

Comments
 (0)