Skip to content

Commit 2fbb979

Browse files
typotter0xnm
andauthored
Apply suggestions from code review
Co-authored-by: Nikita Ogorodnikov <[email protected]>
1 parent f301593 commit 2fbb979

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

features/dd-sdk-android-flags/src/test/kotlin/com/datadog/android/flags/internal/DatadogFlagsClientTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -938,8 +938,8 @@ internal class DatadogFlagsClientTest {
938938

939939
// Then
940940
verify(mockEvaluationsManager).updateEvaluationsForContext(
941-
eq(fakeContext),
942-
eq(mockCallback)
941+
fakeContext,
942+
mockCallback
943943
)
944944
}
945945

@@ -953,8 +953,8 @@ internal class DatadogFlagsClientTest {
953953

954954
// Then
955955
verify(mockEvaluationsManager).updateEvaluationsForContext(
956-
eq(fakeContext),
957-
eq(null)
956+
fakeContext,
957+
null
958958
)
959959
}
960960

features/dd-sdk-android-flags/src/test/kotlin/com/datadog/android/flags/internal/evaluation/EvaluationsManagerTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ internal class EvaluationsManagerTest {
307307
fun `M invoke onFailure W updateEvaluationsForContext() { network failure, no cached flags }`() {
308308
// Given
309309
val publicContext = EvaluationContext(fakeTargetingKey, emptyMap())
310-
val mockCallback = org.mockito.kotlin.mock<EvaluationContextCallback>()
310+
val mockCallback = mock<EvaluationContextCallback>()
311311

312312
whenever(mockFlagsRepository.hasFlags()).thenReturn(false)
313313
whenever(mockAssignmentsDownloader.readPrecomputedFlags(publicContext)).thenReturn(null)
@@ -326,7 +326,7 @@ internal class EvaluationsManagerTest {
326326
fun `M invoke onFailure W updateEvaluationsForContext() { network failure, has cached flags }`() {
327327
// Given
328328
val publicContext = EvaluationContext(fakeTargetingKey, emptyMap())
329-
val mockCallback = org.mockito.kotlin.mock<EvaluationContextCallback>()
329+
val mockCallback = mock<EvaluationContextCallback>()
330330

331331
whenever(mockFlagsRepository.hasFlags()).thenReturn(true)
332332
whenever(mockAssignmentsDownloader.readPrecomputedFlags(publicContext)).thenReturn(null)
@@ -352,7 +352,7 @@ internal class EvaluationsManagerTest {
352352
whenever(mockPrecomputeMapper.map(jsonResponse)).thenReturn(flagsMap)
353353

354354
// When/Then - should not throw
355-
evaluationsManager.updateEvaluationsForContext(publicContext, callback = null)
355+
assertDoesNotThrow { evaluationsManager.updateEvaluationsForContext(publicContext, callback = null) }
356356
}
357357

358358
// endregion

0 commit comments

Comments
 (0)