RUM-8785: post-review fixes

Author: satween

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/vitals/FPSVitalListener.kt

@@ -5,7 +5,9 @@
  */
 package com.datadog.android.rum.internal.vitals
 
+import android.annotation.SuppressLint
 import android.os.Build
+import androidx.annotation.RequiresApi
 import androidx.metrics.performance.FrameData
 import com.datadog.android.core.internal.system.BuildSdkVersionProvider
 import com.datadog.android.rum.internal.domain.FrameMetricsData
@@ -16,6 +18,7 @@ internal class FPSVitalListener(
     private val buildSdkVersionProvider: BuildSdkVersionProvider = BuildSdkVersionProvider.DEFAULT,
     private var screenRefreshRate: Double = 60.0
 ) : FrameStateListener {
+    @RequiresApi(Build.VERSION_CODES.S)
     private var frameDeadline = EXPECTED_60_FPS_FRAME_DURATION_NS
     private var displayRefreshRate: Double = SIXTY_FPS
 
@@ -24,6 +27,7 @@ internal class FPSVitalListener(
         if (durationNs > 0.0) {
             var frameRate = (ONE_SECOND_NS / durationNs)
 
+            @SuppressLint("NewApi")
             if (buildSdkVersionProvider.version >= Build.VERSION_CODES.S) {
                 screenRefreshRate = ONE_SECOND_NS / frameDeadline
             } else if (buildSdkVersionProvider.version == Build.VERSION_CODES.R) {
@@ -42,6 +46,7 @@ internal class FPSVitalListener(
 
     override fun onFrameMetricsData(data: FrameMetricsData) {
         displayRefreshRate = data.displayRefreshRate
+        @SuppressLint("NewApi")
         if (buildSdkVersionProvider.version >= Build.VERSION_CODES.S) {
             frameDeadline = data.deadline
         }

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/vitals/JankStatsActivityLifecycleListener.kt

@@ -214,7 +214,7 @@ internal class JankStatsActivityLifecycleListener(
         if (frameMetricsListener == null) {
             frameMetricsListener = DDFrameMetricsListener()
         }
-        // todo RUM-8799: handler thread can be used instead
+        // TODO RUM-8799: handler thread can be used instead
         val handler = Handler(Looper.getMainLooper())
         val decorView = window.peekDecorView()
 
@@ -296,7 +296,7 @@ internal class JankStatsActivityLifecycleListener(
             commandIssueDuration = frameMetrics.getMetric(FrameMetrics.COMMAND_ISSUE_DURATION)
             swapBuffersDuration = frameMetrics.getMetric(FrameMetrics.SWAP_BUFFERS_DURATION)
             totalDuration = frameMetrics.getMetric(FrameMetrics.TOTAL_DURATION)
-            firstDrawFrame = frameMetrics.getMetric(FrameMetrics.FIRST_DRAW_FRAME) == TRUE
+            firstDrawFrame = frameMetrics.getMetric(FrameMetrics.FIRST_DRAW_FRAME) == IS_FIRST_DRAW_FRAME
         }
         @SuppressLint("InlinedApi")
         if (buildSdkVersionProvider.version >= Build.VERSION_CODES.O) {
@@ -320,6 +320,6 @@ internal class JankStatsActivityLifecycleListener(
         internal const val JANK_STATS_TRACKING_DISABLE_ERROR =
             "Failed to disable JankStats tracking"
         private const val SIXTY_FPS: Double = 60.0
-        private const val TRUE = 1L
+        private const val IS_FIRST_DRAW_FRAME = 1L
     }
 }