Skip to content

Commit 4897596

Browse files
committed
RUM-9899: getting rid from deprecated & unused code (ScopeState & ScopeStateAware)
1 parent cdb915c commit 4897596

File tree

8 files changed

+5
-55
lines changed

8 files changed

+5
-55
lines changed

features/dd-sdk-android-trace-internal/api/dd-sdk-android-trace-internal.api

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2290,7 +2290,7 @@ public abstract interface class com/datadog/trace/bootstrap/instrumentation/api/
22902290
public abstract fun getSpan ()Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;
22912291
}
22922292

2293-
public abstract interface class com/datadog/trace/bootstrap/instrumentation/api/AgentScopeManager : com/datadog/trace/bootstrap/instrumentation/api/ScopeStateAware {
2293+
public abstract interface class com/datadog/trace/bootstrap/instrumentation/api/AgentScopeManager {
22942294
public abstract fun activate (Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;Lcom/datadog/trace/bootstrap/instrumentation/api/ScopeSource;)Lcom/datadog/trace/bootstrap/instrumentation/api/AgentScope;
22952295
public abstract fun activate (Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;Lcom/datadog/trace/bootstrap/instrumentation/api/ScopeSource;Z)Lcom/datadog/trace/bootstrap/instrumentation/api/AgentScope;
22962296
public abstract fun activateNext (Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;)Lcom/datadog/trace/bootstrap/instrumentation/api/AgentScope;
@@ -2590,7 +2590,7 @@ public abstract interface class com/datadog/trace/bootstrap/instrumentation/api/
25902590
public abstract fun withTag (Ljava/lang/String;Z)Lcom/datadog/trace/bootstrap/instrumentation/api/AgentTracer$SpanBuilder;
25912591
}
25922592

2593-
public abstract interface class com/datadog/trace/bootstrap/instrumentation/api/AgentTracer$TracerAPI : com/datadog/trace/api/EndpointCheckpointer, com/datadog/trace/bootstrap/instrumentation/api/ScopeStateAware {
2593+
public abstract interface class com/datadog/trace/bootstrap/instrumentation/api/AgentTracer$TracerAPI : com/datadog/trace/api/EndpointCheckpointer {
25942594
public abstract fun activateSpan (Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;Lcom/datadog/trace/bootstrap/instrumentation/api/ScopeSource;)Lcom/datadog/trace/bootstrap/instrumentation/api/AgentScope;
25952595
public abstract fun activateSpan (Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;Lcom/datadog/trace/bootstrap/instrumentation/api/ScopeSource;Z)Lcom/datadog/trace/bootstrap/instrumentation/api/AgentScope;
25962596
public abstract fun activeSpan ()Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;
@@ -2790,15 +2790,6 @@ public final class com/datadog/trace/bootstrap/instrumentation/api/ScopeSource :
27902790
public static fun values ()[Lcom/datadog/trace/bootstrap/instrumentation/api/ScopeSource;
27912791
}
27922792

2793-
public abstract interface class com/datadog/trace/bootstrap/instrumentation/api/ScopeState {
2794-
public abstract fun activate ()V
2795-
public abstract fun fetchFromActive ()V
2796-
}
2797-
2798-
public abstract interface class com/datadog/trace/bootstrap/instrumentation/api/ScopeStateAware {
2799-
public abstract fun newScopeState ()Lcom/datadog/trace/bootstrap/instrumentation/api/ScopeState;
2800-
}
2801-
28022793
public class com/datadog/trace/bootstrap/instrumentation/api/SpanLink : com/datadog/trace/bootstrap/instrumentation/api/AgentSpanLink {
28032794
protected fun <init> (Lcom/datadog/trace/api/DDTraceId;JBLjava/lang/String;Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpanLink$Attributes;)V
28042795
public fun attributes ()Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpanLink$Attributes;
@@ -3361,7 +3352,6 @@ public class com/datadog/trace/core/CoreTracer : com/datadog/trace/bootstrap/ins
33613352
public fun getTagInterceptor ()Lcom/datadog/trace/core/taginterceptor/TagInterceptor;
33623353
public fun getTraceId ()Ljava/lang/String;
33633354
public fun getTraceId (Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;)Ljava/lang/String;
3364-
public fun newScopeState ()Lcom/datadog/trace/bootstrap/instrumentation/api/ScopeState;
33653355
public fun onRootSpanFinished (Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;Lcom/datadog/trace/api/EndpointTracker;)V
33663356
public fun onRootSpanStarted (Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;)Lcom/datadog/trace/api/EndpointTracker;
33673357
public fun propagate ()Lcom/datadog/trace/bootstrap/instrumentation/api/AgentPropagation;
@@ -3969,7 +3959,6 @@ public final class com/datadog/trace/core/scopemanager/ContinuableScopeManager :
39693959
public fun addScopeListener (Lcom/datadog/trace/api/scopemanager/ScopeListener;)V
39703960
public fun captureSpan (Lcom/datadog/trace/bootstrap/instrumentation/api/AgentSpan;)Lcom/datadog/trace/bootstrap/instrumentation/api/AgentScope$Continuation;
39713961
public fun closePrevious (Z)V
3972-
public fun newScopeState ()Lcom/datadog/trace/bootstrap/instrumentation/api/ScopeState;
39733962
}
39743963

39753964
public class com/datadog/trace/core/taginterceptor/RuleFlags {

features/dd-sdk-android-trace-internal/src/main/java/com/datadog/trace/bootstrap/instrumentation/api/AgentScopeManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
/**
44
* Allows custom scope managers. See OTScopeManager, CustomScopeManager, and ContextualScopeManager
55
*/
6-
public interface AgentScopeManager extends ScopeStateAware {
6+
public interface AgentScopeManager {
77

88
AgentScope activate(AgentSpan span, ScopeSource source);
99

features/dd-sdk-android-trace-internal/src/main/java/com/datadog/trace/bootstrap/instrumentation/api/AgentTracer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class AgentTracer {
3030
// Not intended to be constructed.
3131
private AgentTracer() {}
3232

33-
public interface TracerAPI extends EndpointCheckpointer, ScopeStateAware {
33+
public interface TracerAPI extends EndpointCheckpointer {
3434

3535
/**
3636
* Create and start a new span.

features/dd-sdk-android-trace-internal/src/main/java/com/datadog/trace/bootstrap/instrumentation/api/ScopeState.java

Lines changed: 0 additions & 7 deletions
This file was deleted.

features/dd-sdk-android-trace-internal/src/main/java/com/datadog/trace/bootstrap/instrumentation/api/ScopeStateAware.java

Lines changed: 0 additions & 5 deletions
This file was deleted.

features/dd-sdk-android-trace-internal/src/main/java/com/datadog/trace/core/CoreTracer.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import com.datadog.trace.bootstrap.instrumentation.api.PathwayContext;
4141
import com.datadog.trace.bootstrap.instrumentation.api.ProfilingContextIntegration;
4242
import com.datadog.trace.bootstrap.instrumentation.api.ScopeSource;
43-
import com.datadog.trace.bootstrap.instrumentation.api.ScopeState;
4443
import com.datadog.trace.bootstrap.instrumentation.api.TagContext;
4544
import com.datadog.trace.common.metrics.MetricsAggregator;
4645
import com.datadog.trace.common.metrics.NoOpMetricsAggregator;
@@ -205,11 +204,6 @@ public EndpointTracker onRootSpanStarted(AgentSpan root) {
205204
return endpointCheckpointer.onRootSpanStarted(root);
206205
}
207206

208-
@Override
209-
public ScopeState newScopeState() {
210-
return scopeManager.newScopeState();
211-
}
212-
213207
public static class CoreTracerBuilder {
214208

215209
private Config config;

features/dd-sdk-android-trace-internal/src/main/java/com/datadog/trace/core/scopemanager/ContinuableScopeManager.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import com.datadog.trace.bootstrap.instrumentation.api.ProfilerContext;
1818
import com.datadog.trace.bootstrap.instrumentation.api.ProfilingContextIntegration;
1919
import com.datadog.trace.bootstrap.instrumentation.api.ScopeSource;
20-
import com.datadog.trace.bootstrap.instrumentation.api.ScopeState;
2120
import com.datadog.trace.core.monitor.HealthMetrics;
2221
import com.datadog.trace.logger.Logger;
2322
import com.datadog.trace.logger.LoggerFactory;
@@ -320,26 +319,6 @@ ScopeStack scopeStack() {
320319
return this.tlsScopeStack.get();
321320
}
322321

323-
@Override
324-
public ScopeState newScopeState() {
325-
return new ContinuableScopeState();
326-
}
327-
328-
private class ContinuableScopeState implements ScopeState {
329-
330-
private ScopeStack localScopeStack = tlsScopeStack.initialValue();
331-
332-
@Override
333-
public void activate() {
334-
tlsScopeStack.set(localScopeStack);
335-
}
336-
337-
@Override
338-
public void fetchFromActive() {
339-
localScopeStack = tlsScopeStack.get();
340-
}
341-
}
342-
343322
static final class ScopeStackThreadLocal extends ThreadLocal<ScopeStack> {
344323

345324
private final ProfilingContextIntegration profilingContextIntegration;

features/dd-sdk-android-trace/api/dd-sdk-android-trace.api

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public final class com/datadog/android/trace/AndroidTracer$Companion {
2727
}
2828

2929
public final class com/datadog/android/trace/DatadogTracer {
30-
public static final field INSTANCE Lcom/datadog/android/trace/DatadogTracer;
30+
public fun <init> ()V
3131
}
3232

3333
public abstract interface class com/datadog/android/trace/InternalCoreWriterProvider {

0 commit comments

Comments
 (0)