RUM-10064: Emit available feature contexts when FeatureSdkCore.setContextUpdateReceiver is called

Author: 0xnm

dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/feature/FeatureSdkCore.kt

@@ -70,7 +70,8 @@ interface FeatureSdkCore : SdkCore {
     fun setEventReceiver(featureName: String, receiver: FeatureEventReceiver)
 
     /**
-     * Sets context update receiver for the given feature.
+     * Sets context update receiver for the given feature. Once subscribed, current context will be emitted
+     * immdediately if it exists.
      *
      * @param featureName Feature name.
      * @param listener Listener to remove.

dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/DatadogCore.kt

@@ -260,6 +260,12 @@ internal class DatadogCore(
             )
         } else {
             feature.setContextUpdateListener(listener)
+            features.keys.forEach {
+                val currentContext = contextProvider?.getFeatureContext(it)
+                if (!currentContext.isNullOrEmpty()) {
+                    listener.onContextUpdate(it, currentContext)
+                }
+            }
         }
     }
 

dd-sdk-android-core/src/test/kotlin/com/datadog/android/core/DatadogCoreTest.kt

@@ -38,6 +38,7 @@ import com.datadog.tools.unit.annotations.TestConfigurationsProvider
 import com.datadog.tools.unit.extensions.TestConfigurationExtension
 import com.datadog.tools.unit.extensions.config.TestConfiguration
 import com.datadog.tools.unit.forge.aThrowable
+import com.datadog.tools.unit.forge.exhaustiveAttributes
 import com.google.gson.JsonObject
 import fr.xgouchet.elmyr.Forge
 import fr.xgouchet.elmyr.annotation.AdvancedForgery
@@ -445,7 +446,7 @@ internal class DatadogCoreTest {
     ) {
         // Given
         val mockFeature = mock<SdkFeature>()
-        val mockContextUpdateListener: FeatureContextUpdateReceiver = mock()
+        val mockContextUpdateListener = mock<FeatureContextUpdateReceiver>()
         testedCore.features[feature] = mockFeature
 
         // When
@@ -455,12 +456,68 @@ internal class DatadogCoreTest {
         verify(mockFeature).setContextUpdateListener(mockContextUpdateListener)
     }
 
+    @Test
+    fun `M not invoke listener W setContextUpdateListener() { other features have no context yet }`(
+        @StringForgery feature: String,
+        forge: Forge
+    ) {
+        // Given
+        val mockFeature = mock<SdkFeature>()
+        val mockContextUpdateListener = mock<FeatureContextUpdateReceiver>()
+        testedCore.features[feature] = mockFeature
+        val mockContextProvider = mock<ContextProvider>()
+        testedCore.coreFeature.contextProvider = mockContextProvider
+        whenever(mockContextProvider.getFeatureContext(any())) doAnswer {
+            forge.anElementFrom(null, emptyMap<String, Any?>())
+        }
+        repeat(forge.aTinyInt()) {
+            testedCore.features += forge.aString() to mock<SdkFeature>()
+        }
+
+        // When
+        testedCore.setContextUpdateReceiver(feature, mockContextUpdateListener)
+
+        // Then
+        verify(mockFeature).setContextUpdateListener(mockContextUpdateListener)
+        verifyNoInteractions(mockContextUpdateListener)
+    }
+
+    @Test
+    fun `M invoke listener W setContextUpdateListener() { other features have context }`(
+        @StringForgery feature: String,
+        forge: Forge
+    ) {
+        // Given
+        val mockFeature = mock<SdkFeature>()
+        val mockContextUpdateListener = mock<FeatureContextUpdateReceiver>()
+        testedCore.features[feature] = mockFeature
+        val mockContextProvider = mock<ContextProvider>()
+        testedCore.coreFeature.contextProvider = mockContextProvider
+        val otherFeatures = forge.aList {
+            forge.aString() to forge.exhaustiveAttributes()
+        }
+        otherFeatures.forEach {
+            testedCore.features += it.first to mock<SdkFeature>()
+            whenever(mockContextProvider.getFeatureContext(it.first)) doReturn it.second
+        }
+
+        // When
+        testedCore.setContextUpdateReceiver(feature, mockContextUpdateListener)
+
+        // Then
+        verify(mockFeature).setContextUpdateListener(mockContextUpdateListener)
+        otherFeatures.forEach {
+            verify(mockContextUpdateListener).onContextUpdate(it.first, it.second)
+        }
+        verifyNoMoreInteractions(mockContextUpdateListener)
+    }
+
     @Test
     fun `M notify no feature registered W setContextUpdateListener() { feature is not registered }`(
         @StringForgery feature: String
     ) {
         // Given
-        val mockContextUpdateListener: FeatureContextUpdateReceiver = mock()
+        val mockContextUpdateListener = mock<FeatureContextUpdateReceiver>()
 
         // When
         testedCore.setContextUpdateReceiver(feature, mockContextUpdateListener)

features/dd-sdk-android-webview/src/main/kotlin/com/datadog/android/webview/internal/rum/WebViewRumFeature.kt

@@ -41,8 +41,6 @@ internal class WebViewRumFeature(
         sdkCore.setContextUpdateReceiver(WEB_RUM_FEATURE_NAME, this)
         dataWriter = createDataWriter(sdkCore.internalLogger)
         initialized.set(true)
-        val currentRumContext = sdkCore.getFeatureContext(Feature.RUM_FEATURE_NAME)
-        nativeRumViewsCache.addToCache(currentRumContext)
     }
 
     override fun onContextUpdate(featureName: String, event: Map<String, Any?>) {

reliability/core-it/src/androidTest/kotlin/com/datadog/android/core/integration/tests/FeatureSdkCoreTest.kt

@@ -391,6 +391,34 @@ class FeatureSdkCoreTest : MockServerTest() {
         assertThat(receivedEvent.eventData).containsExactlyInAnyOrderEntriesOf(fakeKeyValues)
     }
 
+    @Test
+    fun mustReceiveCurrentContextIfExists_when_contextUpdateReceiverRegistered() {
+        // Given
+        val stubContextUpdateReceiver = StubContextUpdateReceiver()
+        val otherFeature = StubStorageBackedFeature(
+            forge,
+            forge.anAlphabeticalString(),
+            getMockServerWrapper().getServerUrl()
+        )
+        val fakeKeyValues = forge.aMap { forge.anAlphabeticalString() to forge.anAlphabeticalString() }
+        testedFeatureSdkCore.registerFeature(stubFeature)
+        testedFeatureSdkCore.registerFeature(otherFeature)
+        testedFeatureSdkCore.updateFeatureContext(stubFeature.name) {
+            fakeKeyValues.forEach { (key, value) ->
+                it[key] = value
+            }
+        }
+
+        // When
+        testedFeatureSdkCore.setContextUpdateReceiver(otherFeature.name, stubContextUpdateReceiver)
+
+        // Then
+        assertThat(stubContextUpdateReceiver.getReceivedEvents()).hasSize(1)
+        val receivedEvent = stubContextUpdateReceiver.getReceivedEvents().first()
+        assertThat(receivedEvent.featureName).isEqualTo(stubFeature.name)
+        assertThat(receivedEvent.eventData).containsExactlyInAnyOrderEntriesOf(fakeKeyValues)
+    }
+
     @Test
     fun mustReceiveContextUpdate_when_contextUpdateReceiverRegistered_updateCalledFromDifferentThreads() {
         // Given