Merge pull request #2667 from DataDog/yl/fix-action-tracking-crash

RUM-9345: Use reflection to retrieve semantics information in modifier

Author: ambushwork

integrations/dd-sdk-android-compose/build.gradle.kts

@@ -39,6 +39,9 @@ plugins {
 
 android {
     namespace = "com.datadog.android.compose"
+    defaultConfig {
+        consumerProguardFiles("consumer-rules.pro")
+    }
     buildFeatures {
         compose = true
     }

integrations/dd-sdk-android-compose/consumer-rules.pro

@@ -0,0 +1,7 @@
+# Keep the Compose internals class name. We need this in the RUM actions tracking.
+-keep class androidx.compose.foundation.ClickableElement {
+    <fields>;
+}
+-keep class androidx.compose.foundation.CombinedClickableElement {
+    <fields>;
+}

integrations/dd-sdk-android-compose/src/main/kotlin/com/datadog/android/compose/internal/utils/LayoutNodeUtils.kt

@@ -11,6 +11,7 @@ package com.datadog.android.compose.internal.utils
 import androidx.compose.ui.geometry.Rect
 import androidx.compose.ui.layout.boundsInWindow
 import androidx.compose.ui.node.LayoutNode
+import androidx.compose.ui.semantics.Role
 import androidx.compose.ui.semantics.SemanticsActions
 import androidx.compose.ui.semantics.SemanticsModifier
 import androidx.compose.ui.semantics.SemanticsProperties
@@ -24,12 +25,15 @@ import com.datadog.android.rum.RumAttributes.ACTION_TARGET_SELECTED
 
 internal class LayoutNodeUtils {
 
-    @Suppress("NestedBlockDepth")
+    @Suppress("NestedBlockDepth", "CyclomaticComplexMethod")
     fun resolveLayoutNode(node: LayoutNode): TargetNode? {
         return runSafe {
             var isClickable = false
             var isScrollable = false
             var datadogTag: String? = null
+            var role: Role? = null
+            var selected: Boolean? = null
+            val customAttributes = mutableMapOf<String, Any?>()
             for (info in node.getModifierInfo()) {
                 val modifier = info.modifier
                 if (modifier is SemanticsModifier) {
@@ -43,42 +47,51 @@ internal class LayoutNodeUtils {
                         getOrNull(DatadogSemanticsPropertyKey)?.let {
                             datadogTag = it
                         }
+                        selected = selected ?: getOrNull(SemanticsProperties.Selected)
+                        role = role ?: getOrNull(SemanticsProperties.Role)
                     }
                 } else {
-                    val className = modifier::class.qualifiedName
-                    if (className == CLASS_NAME_CLICKABLE_ELEMENT ||
-                        className == CLASS_NAME_COMBINED_CLICKABLE_ELEMENT ||
-                        className == CLASS_NAME_TOGGLEABLE_ELEMENT
-                    ) {
-                        isClickable = true
-                    } else if (className == CLASS_NAME_SCROLLING_LAYOUT_ELEMENT ||
-                        className == CLASS_NAME_SCROLLABLE_ELEMENT
-                    ) {
-                        isScrollable = true
+                    when (modifier::class.qualifiedName) {
+                        CLASS_NAME_CLICKABLE_ELEMENT,
+                        CLASS_NAME_COMBINED_CLICKABLE_ELEMENT -> {
+                            role = role ?: getRole(modifier)
+                            isClickable = true
+                        }
+
+                        CLASS_NAME_TOGGLEABLE_ELEMENT -> {
+                            isClickable = true
+                        }
+
+                        CLASS_NAME_SCROLLING_LAYOUT_ELEMENT,
+                        CLASS_NAME_SCROLLABLE_ELEMENT -> {
+                            isScrollable = true
+                        }
                     }
                 }
             }
-
+            selected?.let {
+                customAttributes[ACTION_TARGET_SELECTED] = it
+            }
+            role?.let {
+                customAttributes[ACTION_TARGET_ROLE] = it
+            }
             datadogTag?.let {
                 TargetNode(
                     tag = it,
                     isClickable = isClickable,
                     isScrollable = isScrollable,
-                    customAttributes = resolveCustomAttributes(node)
+                    customAttributes = customAttributes.toMap()
                 )
             }
         }
     }
 
-    private fun resolveCustomAttributes(node: LayoutNode): Map<String, Any?> {
-        return node.collapsedSemantics?.let { configuration ->
-            val selected = configuration.getOrNull(SemanticsProperties.Selected)
-            val role = configuration.getOrNull(SemanticsProperties.Role)
-            mapOf(
-                ACTION_TARGET_SELECTED to selected,
-                ACTION_TARGET_ROLE to role
-            )
-        }.orEmpty()
+    @Suppress("UnsafeThirdPartyFunctionCall")
+    // Function is wrapped with `runSafe` in the call site.
+    private fun getRole(obj: Any): Role {
+        val roleField = obj::class.java.getDeclaredField("role")
+        roleField.isAccessible = true
+        return roleField.get(obj) as Role
     }
 
     fun getLayoutNodeBoundsInWindow(node: LayoutNode): Rect? {
@@ -90,7 +103,7 @@ internal class LayoutNodeUtils {
     private fun <T> runSafe(action: () -> T): T? {
         try {
             return action()
-        } catch (@Suppress("TooGenericExceptionCaught") e: Exception) {
+        } catch (@Suppress("TooGenericExceptionCaught") e: Throwable) {
             // We rely on visibility suppression to access internal field,
             // any runtime exception must be caught here.
             (Datadog.getInstance() as? FeatureSdkCore)?.internalLogger?.log(