Skip to content

Commit 5957478

Browse files
authored
Merge pull request #2794 from DataDog/tvaleev/feature/RUM-10316-aligning_device_and_os
RUM-10316: using common-schema for common object generation
2 parents c038e65 + a23e583 commit 5957478

File tree

22 files changed

+1247
-238
lines changed

22 files changed

+1247
-238
lines changed

features/dd-sdk-android-logs/api/apiSurface

Lines changed: 25 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,23 +35,29 @@ data class com.datadog.android.log.LogsConfiguration
3535
fun setEventMapper(com.datadog.android.event.EventMapper<com.datadog.android.log.model.LogEvent>): Builder
3636
fun build(): LogsConfiguration
3737
data class com.datadog.android.log.model.LogEvent
38-
constructor(Status, kotlin.String, kotlin.String, kotlin.String, Logger, Dd, Usr? = null, Account? = null, Network? = null, Error? = null, kotlin.String? = null, kotlin.String, kotlin.collections.MutableMap<kotlin.String, kotlin.Any?> = mutableMapOf())
38+
constructor(Device, Os, Status, kotlin.String, kotlin.String, kotlin.String, Logger, Usr? = null, Account? = null, Network? = null, Error? = null, kotlin.String? = null, kotlin.String, kotlin.collections.MutableMap<kotlin.String, kotlin.Any?> = mutableMapOf())
3939
fun toJson(): com.google.gson.JsonElement
4040
companion object
4141
fun fromJson(kotlin.String): LogEvent
4242
fun fromJsonObject(com.google.gson.JsonObject): LogEvent
43+
data class Device
44+
constructor(Type? = null, kotlin.String? = null, kotlin.String? = null, kotlin.String? = null, kotlin.String? = null, kotlin.String? = null, kotlin.collections.List<kotlin.String>? = null, kotlin.String? = null, kotlin.Number? = null, kotlin.Boolean? = null, kotlin.Number? = null)
45+
fun toJson(): com.google.gson.JsonElement
46+
companion object
47+
fun fromJson(kotlin.String): Device
48+
fun fromJsonObject(com.google.gson.JsonObject): Device
49+
data class Os
50+
constructor(kotlin.String, kotlin.String, kotlin.String? = null, kotlin.String)
51+
fun toJson(): com.google.gson.JsonElement
52+
companion object
53+
fun fromJson(kotlin.String): Os
54+
fun fromJsonObject(com.google.gson.JsonObject): Os
4355
data class Logger
4456
constructor(kotlin.String, kotlin.String? = null, kotlin.String)
4557
fun toJson(): com.google.gson.JsonElement
4658
companion object
4759
fun fromJson(kotlin.String): Logger
4860
fun fromJsonObject(com.google.gson.JsonObject): Logger
49-
data class Dd
50-
constructor(Device)
51-
fun toJson(): com.google.gson.JsonElement
52-
companion object
53-
fun fromJson(kotlin.String): Dd
54-
fun fromJsonObject(com.google.gson.JsonObject): Dd
5561
data class Usr
5662
constructor(kotlin.String? = null, kotlin.String? = null, kotlin.String? = null, kotlin.collections.MutableMap<kotlin.String, kotlin.Any?> = mutableMapOf())
5763
fun toJson(): com.google.gson.JsonElement
@@ -76,12 +82,6 @@ data class com.datadog.android.log.model.LogEvent
7682
companion object
7783
fun fromJson(kotlin.String): Error
7884
fun fromJsonObject(com.google.gson.JsonObject): Error
79-
data class Device
80-
constructor(kotlin.String)
81-
fun toJson(): com.google.gson.JsonElement
82-
companion object
83-
fun fromJson(kotlin.String): Device
84-
fun fromJsonObject(com.google.gson.JsonObject): Device
8585
data class Client
8686
constructor(SimCarrier? = null, kotlin.String? = null, kotlin.String? = null, kotlin.String? = null, kotlin.String)
8787
fun toJson(): com.google.gson.JsonElement
@@ -112,3 +112,15 @@ data class com.datadog.android.log.model.LogEvent
112112
fun toJson(): com.google.gson.JsonElement
113113
companion object
114114
fun fromJson(kotlin.String): Status
115+
enum Type
116+
constructor(kotlin.String)
117+
- MOBILE
118+
- DESKTOP
119+
- TABLET
120+
- TV
121+
- GAMING_CONSOLE
122+
- BOT
123+
- OTHER
124+
fun toJson(): com.google.gson.JsonElement
125+
companion object
126+
fun fromJson(kotlin.String): Type

features/dd-sdk-android-logs/api/dd-sdk-android-logs.api

Lines changed: 90 additions & 40 deletions
Large diffs are not rendered by default.

features/dd-sdk-android-logs/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ unMock {
7979
}
8080

8181
apply(from = "generate_log_models.gradle.kts")
82-
82+
apply(from = "clone_common_schema.gradle.kts")
8383
kotlinConfig(jvmBytecodeTarget = JvmTarget.JVM_11)
8484
androidLibraryConfig()
8585
junitConfig()
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
/*
2+
* Unless explicitly stated otherwise all files in this repository are licensed under the Apache License Version 2.0.
3+
* This product includes software developed at Datadog (https://www.datadoghq.com/).
4+
* Copyright 2016-Present Datadog, Inc.
5+
*/
6+
import com.datadog.gradle.plugin.gitclone.GitCloneDependenciesTask
7+
8+
tasks.register<GitCloneDependenciesTask>("cloneCommonSchema") {
9+
extension.apply {
10+
clone(
11+
"https://github.com/DataDog/rum-events-format.git",
12+
"schemas/rum",
13+
destinationFolder = "src/main/json/log",
14+
excludedPrefixes = listOf(
15+
"_action-child-schema.json",
16+
"_perf-metric-schema.json",
17+
"_profiling-internal-context-schema.json",
18+
"_rect-schema.json",
19+
"_view-accessibility-schema.json",
20+
"_view-container-schema.json",
21+
"_view-performance-schema.json",
22+
"action-schema.json",
23+
"error-schema.json",
24+
"long_task-schema.json",
25+
"resource-schema.json",
26+
"view-schema.json",
27+
"vital-schema.json"
28+
),
29+
ref = "master"
30+
)
31+
}
32+
}

features/dd-sdk-android-logs/generate_log_models.gradle.kts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ tasks.register(
1414
com.datadog.gradle.plugin.jsonschema.GenerateJsonSchemaTask::class.java
1515
) {
1616
inputDirPath = "src/main/json/log"
17+
ignoredFiles = arrayOf(
18+
"_common-schema.json"
19+
)
1720
targetPackageName = "com.datadog.android.log.model"
1821
}
1922

0 commit comments

Comments
 (0)