RUM-9899: fix detekt

Author: satween

integrations/dd-sdk-android-okhttp-otel/src/main/kotlin/com/datadog/android/okhttp/otel/OkHttpExt.kt

@@ -26,8 +26,10 @@ fun Request.Builder.addParentSpan(span: Span): Request.Builder = apply {
         if (agentSpanContext is DDSpanContext) {
             agentSpanContext.trace.setSamplingPriorityIfNecessary()
         }
+        @Suppress("UnsafeThirdPartyFunctionCall") // the context will always be a TraceContext
         tag(TraceContext::class.java, span.extractTraceContext())
     } else {
+        @Suppress("UnsafeThirdPartyFunctionCall") // the context will always be a TraceContext
         tag(TraceContext::class.java, span.extractTraceContext())
     }
 }

integrations/dd-sdk-android-okhttp/src/main/kotlin/com/datadog/android/okhttp/TraceContext.kt

@@ -25,4 +25,4 @@ data class TraceContext(
      * The sampling priority.
      */
     val samplingPriority: Int
-)
+)

integrations/dd-sdk-android-okhttp/src/main/kotlin/com/datadog/android/okhttp/trace/OtelMigration.kt

@@ -11,4 +11,4 @@ import com.datadog.trace.core.CoreTracer
 
 typealias Tracer = CoreTracer
 typealias Span = AgentSpan
-typealias SpanContext = AgentSpan.Context
+typealias SpanContext = AgentSpan.Context

integrations/dd-sdk-android-okhttp/src/main/kotlin/com/datadog/android/okhttp/trace/TracingInterceptor.kt

@@ -323,12 +323,13 @@ internal constructor(
 
     private fun extractSamplingDecision(request: Request): Boolean? {
         val headerSamplingPriority = extractSamplingDecisionFromHeader(request)
-        if (headerSamplingPriority != null) return headerSamplingPriority
-
         val openTelemetrySpanSamplingPriority = request.tag(TraceContext::class.java)?.samplingPriority
-        if (openTelemetrySpanSamplingPriority == PrioritySampling.UNSET) return null
 
-        return openTelemetrySpanSamplingPriority?.let { samplingPriority -> samplingPriority > 0 }
+        return when {
+            headerSamplingPriority != null -> headerSamplingPriority
+            openTelemetrySpanSamplingPriority == PrioritySampling.UNSET -> null
+            else -> openTelemetrySpanSamplingPriority?.let { samplingPriority -> samplingPriority > 0 }
+        }
     }
 
     @Suppress("ReturnCount")
@@ -846,7 +847,7 @@ internal constructor(
 
         private const val AGENT_PSR_ATTRIBUTE = "_dd.agent_psr"
         private val DEFAULT_LOCAL_TRACER_FACTORY: (SdkCore, Set<TracingHeaderType>) -> Tracer =
-            { sdkCore, tracingHeaderTypes: Set<TracingHeaderType> ->
+            { sdkCore, _: Set<TracingHeaderType> ->
                 CoreTracer.CoreTracerBuilder((sdkCore as FeatureSdkCore).internalLogger)
                     .sampler(AllSampler())
                     .build()

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/DatadogInterceptorTest.kt

@@ -10,7 +10,6 @@ import com.datadog.android.api.InternalLogger
 import com.datadog.android.api.SdkCore
 import com.datadog.android.api.feature.Feature
 import com.datadog.android.okhttp.internal.rum.NoOpRumResourceAttributesProvider
-import com.datadog.android.okhttp.internal.utils.traceIdAsHexString
 import com.datadog.android.okhttp.trace.DeterministicTraceSampler
 import com.datadog.android.okhttp.trace.NoOpTracedRequestListener
 import com.datadog.android.okhttp.trace.Tracer

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/DatadogInterceptorWithoutTracesTest.kt

@@ -30,7 +30,6 @@ import com.datadog.android.rum.RumResourceAttributesProvider
 import com.datadog.android.rum.RumResourceKind
 import com.datadog.android.rum.RumResourceMethod
 import com.datadog.android.rum.resource.ResourceId
-import com.datadog.legacy.trace.api.interceptor.MutableSpan
 import com.datadog.tools.unit.annotations.TestConfigurationsProvider
 import com.datadog.tools.unit.extensions.TestConfigurationExtension
 import com.datadog.tools.unit.extensions.config.TestConfiguration
@@ -114,8 +113,6 @@ internal class DatadogInterceptorWithoutTracesTest {
     @Mock
     lateinit var mockResolver: DefaultFirstPartyHostHeaderTypeResolver
 
-
-
     @Mock
     lateinit var mockTraceSampler: Sampler<Span>
 

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/internal/utils/SpanSamplingIdProviderTest.kt

@@ -15,7 +15,6 @@ import com.datadog.trace.api.DDTraceId
 import com.datadog.trace.core.DDSpanContext
 import fr.xgouchet.elmyr.Forge
 import fr.xgouchet.elmyr.annotation.LongForgery
-import fr.xgouchet.elmyr.annotation.StringForgery
 import fr.xgouchet.elmyr.junit5.ForgeConfiguration
 import fr.xgouchet.elmyr.junit5.ForgeExtension
 import org.assertj.core.api.Assertions.assertThat

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/trace/TracingInterceptorContextInjectionSampledTest.kt

@@ -115,7 +115,6 @@ internal class TracingInterceptorContextInjectionSampledTest {
     @Mock
     lateinit var mockResolver: DefaultFirstPartyHostHeaderTypeResolver
 
-
     lateinit var mockTraceSampler: Sampler<Span>
 
     @Mock

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/trace/TracingInterceptorNonDdTracerNotSendingSpanTest.kt

@@ -197,7 +197,8 @@ internal open class TracingInterceptorNonDdTracerNotSendingSpanTest {
         testedInterceptor = instantiateTestedInterceptor(
             fakeLocalHosts,
             localTracerFactory = { _, _ -> mockLocalTracer },
-            globalTracerProvider = { mockTracer })
+            globalTracerProvider = { mockTracer }
+        )
     }
 
     open fun instantiateTestedInterceptor(