RUM-9973: Remove addFirst, removeFirst, removeLast usages

Author: 0xnm

detekt_custom.yml

@@ -253,6 +253,8 @@ datadog:
       # endregion
       # region Java Collections
       - "java.util.Collections.newSetFromMap(kotlin.collections.MutableMap?):java.lang.IllegalArgumentException"
+      - "java.util.LinkedList.add(kotlin.Int, android.view.View):java.lang.IndexOutOfBoundsException"
+      - "java.util.LinkedList.add(kotlin.Int, com.datadog.android.webview.internal.rum.domain.WebViewNativeRumViewsCache.ViewEntry):java.lang.IndexOutOfBoundsException"
       - "java.util.LinkedList.offer(com.datadog.android.core.internal.data.upload.UploadWorker.UploadNextBatchTask):java.lang.ClassCastException,java.lang.NullPointerException,java.lang.IllegalArgumentException"
       - "java.util.LinkedList.removeFirst():java.util.NoSuchElementException"
       - "java.util.LinkedList.removeLast():java.util.NoSuchElementException"
@@ -652,15 +654,19 @@ datadog:
       - "java.util.LinkedList.addAll(kotlin.collections.Collection)"
       - "java.util.LinkedList.addAll(kotlin.Int, kotlin.collections.Collection)"
       - "java.util.LinkedList.addFirst(android.view.View?)"
+      - "java.util.LinkedList.addFirst(com.datadog.android.webview.internal.rum.domain.WebViewNativeRumViewsCache.ViewEntry?)"
       - "java.util.LinkedList.clear()"
       - "java.util.LinkedList.constructor()"
       - "java.util.LinkedList.constructor(kotlin.collections.MutableCollection?)"
       - "java.util.LinkedList.firstOrNull(kotlin.Function1)"
       - "java.util.LinkedList.forEach(kotlin.Function1)"
       - "java.util.LinkedList.isEmpty()"
       - "java.util.LinkedList.isNotEmpty()"
+      - "java.util.LinkedList.iterator()"
+      - "java.util.LinkedList.peekLast()"
       - "java.util.LinkedList.poll()"
       - "java.util.LinkedList.remove(com.datadog.android.privacy.TrackingConsentProviderCallback)"
+      - "java.util.LinkedList.remove(com.datadog.android.webview.internal.rum.domain.WebViewNativeRumViewsCache.ViewEntry)"
       - "java.util.LinkedHashMap.remove(kotlin.String)"
       - "java.util.Queue.addAll(kotlin.collections.Collection)"
       - "java.util.Queue.clear()"
@@ -820,10 +826,6 @@ datadog:
       - "java.util.HashMap.clear()"
       - "java.util.HashSet.addAll(kotlin.collections.Collection)"
       - "java.util.HashSet.find(kotlin.Function1)"
-      - "java.util.LinkedList.addFirst(com.datadog.android.webview.internal.rum.domain.WebViewNativeRumViewsCache.ViewEntry?)"
-      - "java.util.LinkedList.peekLast()"
-      - "java.util.LinkedList.remove(com.datadog.android.webview.internal.rum.domain.WebViewNativeRumViewsCache.ViewEntry)"
-      - "java.util.LinkedList.iterator()"
       - "java.util.Properties.constructor()"
       - "java.util.Properties.setProperty(kotlin.String?, kotlin.String?)"
       - "java.util.UUID.constructor(kotlin.Long, kotlin.Long)"

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/instrumentation/gestures/GesturesListener.kt

@@ -135,13 +135,19 @@ internal class GesturesListener(
         isScroll: Boolean = false
     ): ViewTarget? {
         val queue = LinkedList<View>()
-        queue.addFirst(decorView)
+        // add(index, element) instead of addFirst here is on purpose, to prevent issues with old AGP being used
+        // when compiling with Android API 35.
+        // Index 0 is always safe
+        @Suppress("UnsafeThirdPartyFunctionCall")
+        queue.add(0, decorView)
         var target: ViewTarget? = null
         var composeViewDetected = false
         while (queue.isNotEmpty()) {
-            // removeFirst can't fail because we checked isNotEmpty
+            // removeAt(index) instead of removeFirst here is on purpose, to prevent issues
+            // with old AGP being used when compiling with Android API 35.
+            // removeAt can't fail because we checked isNotEmpty
             @Suppress("UnsafeThirdPartyFunctionCall")
-            val view = queue.removeFirst()
+            val view = queue.removeAt(0)
             composeViewDetected = composeViewDetected || isJetpackComposeView(view)
             val newTarget = if (isScroll) {
                 findTargetForScroll(view, x, y)

features/dd-sdk-android-trace/src/main/java/com/datadog/opentracing/PendingTrace.java

@@ -362,6 +362,8 @@ public synchronized boolean clean() {
     @Override
     public void addFirst(final DDSpan span) {
         synchronized (this) {
+            // add(index, element) instead of addFirst here is on purpose, to prevent issues
+            // with old AGP being used when compiling with Android API 35.
             super.add(0, span);
         }
         completedSpanCount.incrementAndGet();

features/dd-sdk-android-webview/src/main/kotlin/com/datadog/android/webview/internal/rum/domain/WebViewNativeRumViewsCache.kt

@@ -63,12 +63,24 @@ internal class WebViewNativeRumViewsCache(
                     parentViewsHistoryQueue.first.timestamp <= entry.timestamp
                 )
         ) {
-            parentViewsHistoryQueue.addFirst(entry)
+            // add(index, element) instead of addFirst here is on purpose, to prevent issues
+            // with old AGP being used when compiling with Android API 35.
+            // Index 0 is always safe
+            @Suppress("UnsafeThirdPartyFunctionCall")
+            parentViewsHistoryQueue.add(0, entry)
         } else if (parentViewsHistoryQueue.first.viewId == entry.viewId) {
             // the function is synchronized and we are checking the size before
+            if (parentViewsHistoryQueue.isNotEmpty()) {
+                // removeAt(index) instead of removeFirst here is on purpose, to prevent issues
+                // with old AGP being used when compiling with Android API 35.
+                @Suppress("UnsafeThirdPartyFunctionCall")
+                parentViewsHistoryQueue.removeAt(0)
+            }
+            // add(index, element) instead of addFirst here is on purpose, to prevent issues
+            // with old AGP being used when compiling with Android API 35.
+            // Index 0 is always safe
             @Suppress("UnsafeThirdPartyFunctionCall")
-            parentViewsHistoryQueue.removeFirst()
-            parentViewsHistoryQueue.addFirst(entry)
+            parentViewsHistoryQueue.add(0, entry)
         }
     }
 
@@ -84,9 +96,11 @@ internal class WebViewNativeRumViewsCache(
             }
         }
         while (parentViewsHistoryQueue.size > DATA_CACHE_ENTRIES_LIMIT) {
+            // removeAt(index) instead of removeLast here is on purpose, to prevent issues
+            // with old AGP being used when compiling with Android API 35.
             // the function is synchronized and we are checking the size before
             @Suppress("UnsafeThirdPartyFunctionCall")
-            parentViewsHistoryQueue.removeLast()
+            parentViewsHistoryQueue.removeAt(parentViewsHistoryQueue.size - 1)
         }
     }