RUM-9631: Use resources from appContext

Author: jonathanmos

detekt_custom.yml

@@ -562,7 +562,6 @@ datadog:
       - "androidx.compose.ui.text.AnnotatedString.getStringAnnotations(kotlin.Int, kotlin.Int)"
       - "android.content.ContentResolver.registerContentObserver(android.net.Uri, kotlin.Boolean, android.database.ContentObserver)"
       - "android.content.ContentResolver.unregisterContentObserver(android.database.ContentObserver)"
-      - "android.content.res.Resources.getSystem()"
       - "androidx.core.view.GestureDetectorCompat.constructor(android.content.Context, android.view.GestureDetector.OnGestureListener)"
       - "androidx.core.view.GestureDetectorCompat.onTouchEvent(android.view.MotionEvent)"
       - "androidx.fragment.app.FragmentManager.FragmentLifecycleCallbacks.onFragmentActivityCreated(androidx.fragment.app.FragmentManager, androidx.fragment.app.Fragment, android.os.Bundle?)"

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/accessibility/DatadogAccessibilityReader.kt

@@ -28,7 +28,7 @@ import java.util.concurrent.atomic.AtomicLong
 internal class DatadogAccessibilityReader(
     private val internalLogger: InternalLogger,
     private val applicationContext: Context,
-    private val resources: Resources? = Resources.getSystem(),
+    private val resources: Resources = applicationContext.resources,
     private val activityManager: ActivityManager? =
         applicationContext.getSystemService(Context.ACTIVITY_SERVICE) as? ActivityManager,
     private val accessibilityManager: AccessibilityManager? =
@@ -190,8 +190,8 @@ internal class DatadogAccessibilityReader(
         )
     }
 
-    private fun getTextSize(): Float? {
-        return resources?.configuration?.fontScale
+    private fun getTextSize(): Float {
+        return resources.configuration.fontScale
     }
 
     private fun isScreenReaderEnabled(accessibilityManager: AccessibilityManager?): Boolean? {

features/dd-sdk-android-rum/src/test/kotlin/com/datadog/android/rum/RumTest.kt

@@ -80,7 +80,10 @@ internal class RumTest {
             verify(mockSdkCore).registerFeature(capture())
 
             lastValue.onInitialize(
-                appContext = mock { whenever(it.packageName) doReturn fakePackageName }
+                appContext = mock {
+                    whenever(it.packageName) doReturn fakePackageName
+                    whenever(it.resources) doReturn mock()
+                }
             )
             assertThat(lastValue.sampleRate)
                 .isEqualTo(fakeRumConfiguration.featureConfiguration.sampleRate)
@@ -126,7 +129,10 @@ internal class RumTest {
         whenever(mockSdkCore.registerFeature(any())) doAnswer {
             val feature = it.getArgument<RumFeature>(0)
             feature.onInitialize(
-                appContext = mock { whenever(it.packageName) doReturn fakePackageName }
+                appContext = mock {
+                    whenever(it.packageName) doReturn fakePackageName
+                    whenever(it.resources) doReturn mock()
+                }
             )
         }
         // When

features/dd-sdk-android-rum/src/test/kotlin/com/datadog/android/rum/internal/domain/accessibility/DatadogAccessibilityReaderTest.kt

@@ -235,38 +235,6 @@ internal class DatadogAccessibilityReaderTest {
     }
 
     // region Text Size Tests
-    @Test
-    fun `M return null text size W getState { resources is null }`() {
-        // Given
-        testedReader = DatadogAccessibilityReader(
-            internalLogger = mockInternalLogger,
-            applicationContext = mockContext,
-            resources = null,
-            activityManager = mockActivityManager,
-            accessibilityManager = mockAccessibilityManager,
-            secureWrapper = mockSecureWrapper,
-            globalWrapper = mockGlobalWrapper,
-            handler = mockHandler
-        )
-
-        // When
-        val result = testedReader.getState()
-
-        // Then
-        assertThat(result[TEXT_SIZE_KEY]).isNull()
-    }
-
-    @Test
-    fun `M return null text size W getState { resources configuration is null }`() {
-        // Given
-        whenever(mockResources.configuration) doReturn null
-
-        // When
-        val result = testedReader.getState()
-
-        // Then
-        assertThat(result[TEXT_SIZE_KEY]).isNull()
-    }
 
     @Test
     fun `M return text size W getState { valid font scale }`(

features/dd-sdk-android-rum/src/test/kotlin/com/datadog/android/rum/utils/config/ApplicationContextTestConfiguration.kt

@@ -48,6 +48,7 @@ internal open class ApplicationContextTestConfiguration<T : Context>(klass: Clas
         whenever(mockInstance.packageManager) doReturn mockPackageManager
         whenever(mockInstance.packageName) doReturn fakePackageName
         whenever(mockInstance.applicationInfo) doReturn fakeAppInfo
+        whenever(mockInstance.resources) doReturn mock()
 
         // ???
         whenever(mockInstance.getSystemService(Context.ACTIVITY_SERVICE)) doReturn mock()