More lint fixes

Author: fuzzybinary

features/dd-sdk-android-rum/api/apiSurface

@@ -62,6 +62,8 @@ object com.datadog.android.rum.RumAttributes
   const val NETWORK_SIGNAL_STRENGTH: String
   const val NETWORK_UP_KBPS: String
   const val NETWORK_BYTES_READ: String
+  const val FLUTTER_FIRST_BUILD_COMPLETE: String
+  const val CUSTOM_INV_VALUE: String
 data class com.datadog.android.rum.RumConfiguration
   class Builder
     constructor(String)
@@ -83,7 +85,7 @@ data class com.datadog.android.rum.RumConfiguration
     fun useCustomEndpoint(String): Builder
     fun setSessionListener(RumSessionListener): Builder
     fun setInitialResourceIdentifier(com.datadog.android.rum.metric.networksettled.InitialResourceIdentifier): Builder
-    fun setLastInteractionIdentifier(com.datadog.android.rum.metric.interactiontonextview.LastInteractionIdentifier): Builder
+    fun setLastInteractionIdentifier(com.datadog.android.rum.metric.interactiontonextview.LastInteractionIdentifier?): Builder
     fun build(): RumConfiguration
 enum com.datadog.android.rum.RumErrorSource
   - NETWORK
@@ -156,6 +158,7 @@ interface com.datadog.android.rum.RumSessionListener
 class com.datadog.android.rum._RumInternalProxy
   fun addLongTask(Long, String)
   fun updatePerformanceMetric(RumPerformanceMetric, Double)
+  fun setInternalViewAttribute(String, Any?)
   fun setSyntheticsAttribute(String?, String?)
   companion object 
     fun setTelemetryConfigurationEventMapper(RumConfiguration.Builder, com.datadog.android.event.EventMapper<com.datadog.android.telemetry.model.TelemetryConfigurationEvent>): RumConfiguration.Builder
@@ -1775,7 +1778,7 @@ data class com.datadog.android.rum.model.ViewEvent
       fun fromJson(kotlin.String): ViewEventSession
       fun fromJsonObject(com.google.gson.JsonObject): ViewEventSession
   data class ViewEventView
-    constructor(kotlin.String, kotlin.String? = null, kotlin.String, kotlin.String? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.Long? = null, LoadingType? = null, kotlin.Long, kotlin.Long? = null, kotlin.Long? = null, kotlin.String? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.String? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.String? = null, kotlin.Number? = null, kotlin.Long? = null, kotlin.String? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.Long? = null, CustomTimings? = null, kotlin.Boolean? = null, kotlin.Boolean? = null, Action, Error, Crash? = null, LongTask? = null, FrozenFrame? = null, Resource, Frustration? = null, kotlin.collections.List<InForegroundPeriod>? = null, kotlin.Number? = null, kotlin.Number? = null, kotlin.Number? = null, kotlin.Number? = null, kotlin.Number? = null, kotlin.Number? = null, FlutterBuildTime? = null, FlutterBuildTime? = null, FlutterBuildTime? = null)
+    constructor(kotlin.String, kotlin.String? = null, kotlin.String, kotlin.String? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.Long? = null, LoadingType? = null, kotlin.Long, kotlin.Long? = null, kotlin.Long? = null, kotlin.String? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.String? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.String? = null, kotlin.Number? = null, kotlin.Long? = null, kotlin.String? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.Long? = null, kotlin.Long? = null, CustomTimings? = null, kotlin.Boolean? = null, kotlin.Boolean? = null, Action, Error, Crash? = null, LongTask? = null, FrozenFrame? = null, Resource, Frustration? = null, kotlin.collections.List<InForegroundPeriod>? = null, kotlin.Number? = null, kotlin.Number? = null, kotlin.Number? = null, kotlin.Number? = null, kotlin.Number? = null, kotlin.Number? = null, FlutterBuildTime? = null, FlutterBuildTime? = null, FlutterBuildTime? = null, Performance? = null)
     fun toJson(): com.google.gson.JsonElement
     companion object 
       fun fromJson(kotlin.String): ViewEventView
@@ -1913,6 +1916,12 @@ data class com.datadog.android.rum.model.ViewEvent
     companion object 
       fun fromJson(kotlin.String): FlutterBuildTime
       fun fromJsonObject(com.google.gson.JsonObject): FlutterBuildTime
+  data class Performance
+    constructor(Cls? = null, Fcp? = null, Fid? = null, Inp? = null, Lcp? = null, Fbc? = null)
+    fun toJson(): com.google.gson.JsonElement
+    companion object 
+      fun fromJson(kotlin.String): Performance
+      fun fromJsonObject(com.google.gson.JsonObject): Performance
   data class Cellular
     constructor(kotlin.String? = null, kotlin.String? = null)
     fun toJson(): com.google.gson.JsonElement
@@ -1961,6 +1970,48 @@ data class com.datadog.android.rum.model.ViewEvent
     companion object 
       fun fromJson(kotlin.String): ContainerView
       fun fromJsonObject(com.google.gson.JsonObject): ContainerView
+  data class Cls
+    constructor(kotlin.Number, kotlin.Long? = null, kotlin.String? = null, PreviousRect? = null, PreviousRect? = null)
+    fun toJson(): com.google.gson.JsonElement
+    companion object 
+      fun fromJson(kotlin.String): Cls
+      fun fromJsonObject(com.google.gson.JsonObject): Cls
+  data class Fcp
+    constructor(kotlin.Long)
+    fun toJson(): com.google.gson.JsonElement
+    companion object 
+      fun fromJson(kotlin.String): Fcp
+      fun fromJsonObject(com.google.gson.JsonObject): Fcp
+  data class Fid
+    constructor(kotlin.Long, kotlin.Long, kotlin.String? = null)
+    fun toJson(): com.google.gson.JsonElement
+    companion object 
+      fun fromJson(kotlin.String): Fid
+      fun fromJsonObject(com.google.gson.JsonObject): Fid
+  data class Inp
+    constructor(kotlin.Long, kotlin.Long? = null, kotlin.String? = null)
+    fun toJson(): com.google.gson.JsonElement
+    companion object 
+      fun fromJson(kotlin.String): Inp
+      fun fromJsonObject(com.google.gson.JsonObject): Inp
+  data class Lcp
+    constructor(kotlin.Long, kotlin.String? = null, kotlin.String? = null)
+    fun toJson(): com.google.gson.JsonElement
+    companion object 
+      fun fromJson(kotlin.String): Lcp
+      fun fromJsonObject(com.google.gson.JsonObject): Lcp
+  data class Fbc
+    constructor(kotlin.Long)
+    fun toJson(): com.google.gson.JsonElement
+    companion object 
+      fun fromJson(kotlin.String): Fbc
+      fun fromJsonObject(com.google.gson.JsonObject): Fbc
+  data class PreviousRect
+    constructor(kotlin.Number, kotlin.Number, kotlin.Number, kotlin.Number)
+    fun toJson(): com.google.gson.JsonElement
+    companion object 
+      fun fromJson(kotlin.String): PreviousRect
+      fun fromJsonObject(com.google.gson.JsonObject): PreviousRect
   enum ViewEventSource
     constructor(kotlin.String)
     - ANDROID
@@ -2076,7 +2127,7 @@ data class com.datadog.android.rum.model.ViewEvent
     companion object 
       fun fromJson(kotlin.String): State
 data class com.datadog.android.rum.model.ViewPerformanceData
-  constructor(Cls? = null, Fcp? = null, Fid? = null, Inp? = null, Lcp? = null)
+  constructor(Cls? = null, Fcp? = null, Fid? = null, Inp? = null, Lcp? = null, Fbc? = null)
   fun toJson(): com.google.gson.JsonElement
   companion object 
     fun fromJson(kotlin.String): ViewPerformanceData
@@ -2111,6 +2162,12 @@ data class com.datadog.android.rum.model.ViewPerformanceData
     companion object 
       fun fromJson(kotlin.String): Lcp
       fun fromJsonObject(com.google.gson.JsonObject): Lcp
+  data class Fbc
+    constructor(kotlin.Long)
+    fun toJson(): com.google.gson.JsonElement
+    companion object 
+      fun fromJson(kotlin.String): Fbc
+      fun fromJsonObject(com.google.gson.JsonObject): Fbc
   data class PreviousRect
     constructor(kotlin.Number, kotlin.Number, kotlin.Number, kotlin.Number)
     fun toJson(): com.google.gson.JsonElement

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/RumAttributes.kt

@@ -294,14 +294,14 @@ object RumAttributes {
      * Custom Flutter vital - First Build Complete. The amount of time between a route change (the start of a view)
      * and when the first `build` method is complete. In nanoseconds since view start.
      */
-    const val FLUTTER_FIRST_BUILD_COMPLETE = "_dd.performance.first_build_complete"
+    const val FLUTTER_FIRST_BUILD_COMPLETE: String = "_dd.performance.first_build_complete"
 
     /**
      * Custom value for Interaction To Next view.
      * For Flutter this is the amount of time between an action occurring and the First Build Complete occurring
      * on the next view.
      */
-    const val CUSTOM_INV_VALUE = "_dd.view.custom_inv_value"
+    const val CUSTOM_INV_VALUE: String = "_dd.view.custom_inv_value"
 
     // endregion
 }

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScope.kt

@@ -202,7 +202,7 @@ internal open class RumViewScope(
             is RumRawEvent.StartResource -> onStartResource(event, writer)
             is RumRawEvent.AddError -> onAddError(event, writer)
             is RumRawEvent.AddLongTask -> onAddLongTask(event, writer)
-            is RumRawEvent.SetInternalViewAttribute -> onSetInternalViewAttribute(event, writer)
+            is RumRawEvent.SetInternalViewAttribute -> onSetInternalViewAttribute(event)
 
             is RumRawEvent.AddFeatureFlagEvaluation -> onAddFeatureFlagEvaluation(event, writer)
             is RumRawEvent.AddFeatureFlagEvaluations -> onAddFeatureFlagEvaluations(event, writer)
@@ -621,7 +621,7 @@ internal open class RumViewScope(
     }
 
     @WorkerThread
-    private fun onSetInternalViewAttribute(event: RumRawEvent.SetInternalViewAttribute, writer: DataWriter<Any>) {
+    private fun onSetInternalViewAttribute(event: RumRawEvent.SetInternalViewAttribute) {
         if (stopped) return
 
         internalAttributes[event.key] = event.value

features/dd-sdk-android-rum/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScopeTest.kt

@@ -8295,7 +8295,7 @@ internal class RumViewScopeTest {
         testedScope.handleEvent(
             RumRawEvent.SetInternalViewAttribute(
                 key = RumAttributes.CUSTOM_INV_VALUE,
-                value = custom_inv
+                value = customInv
             ),
             mockWriter
         )
@@ -8308,7 +8308,7 @@ internal class RumViewScopeTest {
         argumentCaptor<ViewEvent> {
             verify(mockWriter).write(eq(mockEventBatchWriter), capture(), eq(EventType.DEFAULT))
             assertThat(lastValue)
-                .hasInteractionToNextViewTime(custom_inv)
+                .hasInteractionToNextViewTime(customInv)
         }
         verifyNoMoreInteractions(mockWriter)
         assertThat(result).isSameAs(testedScope)