Skip to content

Commit ab7d8b8

Browse files
committed
RUM-9491: Merge develop
1 parent c48d6cc commit ab7d8b8

File tree

8 files changed

+13
-17
lines changed

8 files changed

+13
-17
lines changed

dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/CoreFeature.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,6 @@ internal class CoreFeature(
524524
accountInfoProvider = DatadogAccountInfoProvider(internalLogger)
525525
}
526526

527-
528527
private fun setupNetworkInfoProviders(appContext: Context) {
529528
networkInfoProvider = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
530529
CallbackNetworkInfoProvider(internalLogger = internalLogger)

features/dd-sdk-android-logs/src/main/kotlin/com/datadog/android/log/internal/LogsFeature.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ import com.datadog.android.api.storage.DataWriter
1919
import com.datadog.android.api.storage.EventType
2020
import com.datadog.android.api.storage.FeatureStorageConfiguration
2121
import com.datadog.android.api.storage.NoOpDataWriter
22-
import com.datadog.android.core.feature.event.JvmCrash
23-
import com.datadog.android.core.internal.utils.NULL_MAP_VALUE
2422
import com.datadog.android.event.EventMapper
2523
import com.datadog.android.event.MapperSerializer
2624
import com.datadog.android.internal.utils.NULL_MAP_VALUE

features/dd-sdk-android-logs/src/test/kotlin/com/datadog/android/log/internal/LogsFeatureTest.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ import com.datadog.android.api.storage.DataWriter
1616
import com.datadog.android.api.storage.EventBatchWriter
1717
import com.datadog.android.api.storage.EventType
1818
import com.datadog.android.api.storage.FeatureStorageConfiguration
19-
import com.datadog.android.core.feature.event.JvmCrash
20-
import com.datadog.android.core.feature.event.ThreadDump
21-
import com.datadog.android.core.internal.utils.NULL_MAP_VALUE
2219
import com.datadog.android.event.EventMapper
2320
import com.datadog.android.event.MapperSerializer
2421
import com.datadog.android.internal.utils.NULL_MAP_VALUE

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScope.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ internal open class RumViewScope(
5757
private val sessionEndedMetricDispatcher: SessionMetricDispatcher,
5858
internal val key: RumScopeKey,
5959
eventTime: Time,
60-
initialAttributes: Map<String, Any?>,
60+
private val initialAttributes: Map<String, Any?>,
6161
private val viewChangedListener: RumViewChangedListener?,
6262
internal val firstPartyHostHeaderTypeResolver: FirstPartyHostHeaderTypeResolver,
6363
internal val cpuVitalMonitor: VitalMonitor,
@@ -252,7 +252,7 @@ internal open class RumViewScope(
252252
sessionEndedMetricDispatcher = sessionEndedMetricDispatcher,
253253
key = key,
254254
eventTime = newEventTime,
255-
initialAttributes = eventAttributes,
255+
initialAttributes = initialAttributes,
256256
viewChangedListener = viewChangedListener,
257257
firstPartyHostHeaderTypeResolver = firstPartyHostHeaderTypeResolver,
258258
cpuVitalMonitor = cpuVitalMonitor,

features/dd-sdk-android-rum/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScopeTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8356,7 +8356,7 @@ internal class RumViewScopeTest {
83568356
assertThat(newScope.type).isEqualTo(testedScope.type)
83578357
assertThat(newScope.sampleRate).isEqualTo(testedScope.sampleRate)
83588358
assertThat(newScope.url).isEqualTo(testedScope.url)
8359-
assertThat(newScope.eventAttributes).isEqualTo(testedScope.eventAttributes)
8359+
assertThat(newScope.viewAttributes).isEqualTo(testedScope.viewAttributes)
83608360
assertThat(newScope.stoppedNanos).isEqualTo(expectedTime.nanoTime)
83618361
assertThat(newScope.viewLoadingTime).isNull()
83628362
assertThat(newScope.activeActionScope).isNull()

features/dd-sdk-android-trace-internal/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,4 @@ dependencyUpdateConfig()
8484
publishingConfig(
8585
"Internal APM support library for Android applications."
8686
)
87-
detektCustomConfig(":dd-sdk-android-core", ":dd-sdk-android-internal")
87+
detektCustomConfig()

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/internal/utils/SpanSamplingIdProviderTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
package com.datadog.android.okhttp.internal.utils
88

9-
import com.datadog.android.core.internal.utils.toHexString
9+
import com.datadog.android.internal.utils.toHexString
1010
import com.datadog.android.log.LogAttributes
1111
import com.datadog.opentracing.DDSpanContext
1212
import com.datadog.tools.unit.forge.BaseConfigurator

sample/tv/src/main/java/com/datadog/android/tv/sample/TvSampleApplication.kt

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,15 @@ class TvSampleApplication : Application() {
118118

119119
private fun initializeOkHttp() {
120120
okHttpClient = OkHttpClient.Builder()
121-
.addInterceptor(DatadogInterceptor(traceSampler = RateBasedSampler(FULL_SAMPLING_RATE)))
121+
.addInterceptor(
122+
DatadogInterceptor.Builder(emptyMap())
123+
.setTraceSampler(RateBasedSampler(FULL_SAMPLING_RATE))
124+
.build()
125+
)
122126
.addNetworkInterceptor(
123-
TracingInterceptor(
124-
traceSampler = RateBasedSampler(
125-
FULL_SAMPLING_RATE
126-
)
127-
)
127+
TracingInterceptor.Builder(emptyMap())
128+
.setTraceSampler(RateBasedSampler(FULL_SAMPLING_RATE))
129+
.build()
128130
)
129131
.eventListenerFactory(DatadogEventListener.Factory())
130132
.build()

0 commit comments

Comments
 (0)