RUM-9902 - post review fixes

Author: satween

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/telemetry/internal/TelemetryEventHandler.kt

@@ -436,14 +436,14 @@ internal class TelemetryEventHandler(
     }
 
     private fun isGlobalTracerRegistered(): Boolean {
-        // We don't reference io.opentracing from RUM directly, so using reflection for this.
-        // Would be nice to add the test with the flavor which is has no io.opentracing and test
+        // We don't reference com.datadog.android.trace from RUM directly, so using reflection for this.
+        // Would be nice to add the test with the flavor which is has no com.datadog.android.trace and test
         // for obfuscation enabled case.
         return try {
             val globalDatadogTracer =
                 Class.forName("com.datadog.android.trace.GlobalDatadogTracer")
             return try {
-                val holderInstance = globalDatadogTracer.getField("INSTANCE").get(null)
+                val holderInstance = globalDatadogTracer.getDeclaredField("INSTANCE").get(null)
                 globalDatadogTracer.getDeclaredMethod("getOrNull").invoke(holderInstance) != null
             } catch (@Suppress("TooGenericExceptionCaught") t: Throwable) {
                 sdkCore.internalLogger.log(

features/dd-sdk-android-trace-api/src/main/kotlin/com/datadog/android/trace/api/span/DatadogSpan.kt

@@ -74,7 +74,7 @@ interface DatadogSpan {
     /**
      * Retrieves the context associated with this Datadog span.
      *
-     * @return The DatadogSpanContext containing trace and span-specific information such as identifiers, sampling priority, and tags.
+     * @return The [DatadogSpanContext] containing trace and span-specific information such as identifiers, sampling priority, and tags.
      */
     fun context(): DatadogSpanContext
 

reliability/single-fit/okhttp/src/test/kotlin/com/datadog/android/okhttp/HeadBasedSamplingTest.kt

@@ -80,7 +80,6 @@ class HeadBasedSamplingTest {
     }
 
     private fun Request.Builder.parentSpan(span: DatadogSpan): Request.Builder {
-        @Suppress("UnsafeThirdPartyFunctionCall") // Span can't be null
         tag(DatadogSpan::class.java, span)
         return this
     }

reliability/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/opentracing/SpanExt.kt renamed to reliability/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/api/SpanExt.kt

@@ -4,7 +4,7 @@
  * Copyright 2016-Present Datadog, Inc.
  */
 
-package com.datadog.android.trace.integration.opentracing
+package com.datadog.android.trace.integration.api
 
 import com.datadog.android.trace.api.span.DatadogSpan
 import com.datadog.android.trace.internal.DatadogTracingToolkit

reliability/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/opentracing/TraceConfigurationTest.kt renamed to reliability/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/api/TraceConfigurationTest.kt

@@ -4,7 +4,7 @@
  * Copyright 2016-Present Datadog, Inc.
  */
 
-package com.datadog.android.trace.integration.opentracing
+package com.datadog.android.trace.integration.api
 
 import com.datadog.android.api.feature.Feature
 import com.datadog.android.api.feature.StorageBackedFeature

reliability/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/opentracing/UtilitiesTest.kt renamed to reliability/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/api/UtilitiesTest.kt

@@ -4,7 +4,7 @@
  * Copyright 2016-Present Datadog, Inc.
  */
 
-package com.datadog.android.trace.integration.opentracing
+package com.datadog.android.trace.integration.api
 
 import com.datadog.android.api.feature.Feature
 import com.datadog.android.core.stub.StubSDKCore

reliability/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/otel/OtelTraceConfigurationTest.kt

@@ -50,7 +50,7 @@ class OtelTraceConfigurationTest {
         stubSdkCore = StubSDKCore(forge)
     }
 
-    @Test
+    @RepeatedTest(10)
     fun `M send span without network info W setNetworkInfoEnabled(false) + buildSpan() + start() + finish()`(
         @StringForgery fakeInstrumentationName: String,
         @StringForgery fakeOperation: String