Skip to content

Commit c9961a4

Browse files
committed
RUM-9902: post review fixes
1 parent 0861b23 commit c9961a4

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

features/dd-sdk-android-trace-api/src/main/kotlin/com/datadog/android/trace/api/scope/DataScopeListener.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
public interface DataScopeListener {
1111
/**
1212
* Called just after a scope becomes the active scope.
13+
* <p>May be called multiple times. When a scope is initially created, or after a child scope is
14+
* deactivated.
1315
*/
1416
void afterScopeActivated();
1517

features/dd-sdk-android-trace-api/src/main/kotlin/com/datadog/android/trace/api/span/DatadogSpanBuilder.kt

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ interface DatadogSpanBuilder {
2525

2626
/**
2727
* Specifies the origin of the span.
28+
* The origin provides metadata about the context or source where the span was created.
2829
*
2930
* @param origin The origin string to associate with the span. Can be nullable.
3031
* @return The current instance of [DatadogSpanBuilder] to allow method chaining.
@@ -33,6 +34,8 @@ interface DatadogSpanBuilder {
3334

3435
/**
3536
* Adds a tag to the span with the specified key and a nullable double value.
37+
* Tags are used to add contextual information to spans, which can later be
38+
* used for filtering, grouping, or analyzing spans in trace data.
3639
*
3740
* @param key The key identifying the tag. Cannot be null.
3841
* @param value The value associated with the tag. Can be null.
@@ -42,6 +45,8 @@ interface DatadogSpanBuilder {
4245

4346
/**
4447
* Adds a tag to the span with the specified key and a nullable long value.
48+
* Tags are used to add contextual information to spans, which can later be
49+
* used for filtering, grouping, or analyzing spans in trace data.
4550
*
4651
* @param key The key identifying the tag. Must not be null.
4752
* @param value The nullable long value associated with the tag.
@@ -51,6 +56,8 @@ interface DatadogSpanBuilder {
5156

5257
/**
5358
* Adds a tag to the span with the specified key and a nullable value of any type.
59+
* Tags are used to add contextual information to spans, which can later be
60+
* used for filtering, grouping, or analyzing spans in trace data.
5461
*
5562
* @param key The key identifying the tag. Cannot be null.
5663
* @param value The nullable value associated with the tag.
@@ -59,23 +66,24 @@ interface DatadogSpanBuilder {
5966
fun withTag(key: String, value: Any?): DatadogSpanBuilder
6067

6168
/**
62-
* Specifies the resource name of the span.
69+
* Specifies the resource name of the span.The resource name is used to describe
70+
* the operation or endpoint associated with the span.
6371
*
6472
* @param resourceName The resource name to associate with the span.
6573
* @return The current instance of [DatadogSpanBuilder] to allow method chaining.
6674
*/
6775
fun withResourceName(resourceName: String?): DatadogSpanBuilder
6876

6977
/**
70-
* Sets the parent context for the span being built.
78+
* Sets the parent context for the span being built. Allowing to link related operations together.
7179
*
7280
* @param parentContext The parent context to associate with the span. Can be null.
7381
* @return The current instance of [DatadogSpanBuilder] to enable method chaining.
7482
*/
7583
fun withParentContext(parentContext: DatadogSpanContext?): DatadogSpanBuilder
7684

7785
/**
78-
* Sets the parent span for the span being built. Default implementation usually use parentSpan only for
86+
* Sets the parent span for the span being built. The default implementation uses parentSpan only for
7987
* context retrieval.
8088
*
8189
* @param parentSpan The parent span to associate with the span being built. Can be null.

0 commit comments

Comments
 (0)