Skip to content

Commit e2b4020

Browse files
committed
RUM-9899: fix test compilation(10 fallen)
1 parent ee998cc commit e2b4020

File tree

3 files changed

+43
-26
lines changed

3 files changed

+43
-26
lines changed

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/DatadogInterceptorWithoutRumTest.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ internal class DatadogInterceptorWithoutRumTest : TracingInterceptorTest() {
5151

5252
override fun instantiateTestedInterceptor(
5353
tracedHosts: Map<String, Set<TracingHeaderType>>,
54-
factory: (SdkCore, Set<TracingHeaderType>) -> Tracer
54+
globalTracerProvider: () -> Tracer?,
55+
localTracerFactory: (SdkCore, Set<TracingHeaderType>) -> Tracer
5556
): TracingInterceptor {
5657
return DatadogInterceptor(
5758
sdkInstanceName = null,
@@ -61,8 +62,8 @@ internal class DatadogInterceptorWithoutRumTest : TracingInterceptorTest() {
6162
traceSampler = mockTraceSampler,
6263
traceContextInjection = TraceContextInjection.ALL,
6364
redacted404ResourceName = fakeRedacted404Resources,
64-
localTracerFactory = factory,
65-
globalTracerProvider = { null }
65+
localTracerFactory = localTracerFactory,
66+
globalTracerProvider = globalTracerProvider
6667
)
6768
}
6869

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/trace/TracingInterceptorContextInjectionSampledTest.kt

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ import org.mockito.kotlin.verify
7272
import org.mockito.kotlin.verifyNoInteractions
7373
import org.mockito.kotlin.whenever
7474
import org.mockito.quality.Strictness
75-
import java.math.BigInteger
7675
import java.util.Locale
7776
import java.util.concurrent.CountDownLatch
7877
import java.util.concurrent.TimeUnit
@@ -178,21 +177,25 @@ internal class TracingInterceptorContextInjectionSampledTest {
178177
whenever(rumMonitor.mockSdkCore.getFeature(Feature.TRACING_FEATURE_NAME)) doReturn mock()
179178
whenever(rumMonitor.mockSdkCore.internalLogger) doReturn mockInternalLogger
180179
whenever(rumMonitor.mockSdkCore.firstPartyHostResolver) doReturn mockResolver
181-
testedInterceptor = instantiateTestedInterceptor(fakeLocalHosts) { _, _ ->
182-
mockLocalTracer
183-
}
180+
testedInterceptor = instantiateTestedInterceptor(
181+
fakeLocalHosts,
182+
localTracerFactory = { _, _ -> mockLocalTracer },
183+
globalTracerProvider = { mockTracer }
184+
)
184185
}
185186

186187
fun instantiateTestedInterceptor(
187188
tracedHosts: Map<String, Set<TracingHeaderType>> = emptyMap(),
188-
factory: (SdkCore, Set<TracingHeaderType>) -> Tracer
189+
globalTracerProvider: () -> Tracer? = { null },
190+
localTracerFactory: (SdkCore, Set<TracingHeaderType>) -> Tracer
189191
): TracingInterceptor {
190192
return TracingInterceptor.Builder(tracedHosts)
191193
.setTracedRequestListener(mockRequestListener)
192194
.setTraceOrigin(fakeOrigin)
193195
.setTraceSampler(mockTraceSampler)
194196
.setTraceContextInjection(TraceContextInjection.SAMPLED)
195-
.setLocalTracerFactory(factory)
197+
.setLocalTracerFactory(localTracerFactory)
198+
.setGlobalTracerProvider(globalTracerProvider)
196199
.set404ResourcesRedacted(fakeRedacted404Resources)
197200
.build()
198201
}
@@ -1081,22 +1084,22 @@ internal class TracingInterceptorContextInjectionSampledTest {
10811084

10821085
@Test
10831086
fun `M drop automatic tracer W intercept() and global tracer registered`(
1087+
forge: Forge,
10841088
@IntForgery(min = 200, max = 300) statusCode: Int
10851089
) {
1086-
val localSpanBuilder: AgentTracer.SpanBuilder = mock()
1087-
val localSpan: Span = mock(extraInterfaces = arrayOf(MutableSpan::class))
1090+
val localSpan: Span = forge.newSpanMock(mockSpanContext)
1091+
val localSpanBuilder: AgentTracer.SpanBuilder = forge.newSpanBuilderMock(localSpan, mockSpanContext)
10881092
whenever(mockResolver.isFirstPartyUrl(fakeUrl.toHttpUrl())).thenReturn(true)
10891093
stubChain(mockChain, statusCode)
1090-
whenever(localSpanBuilder.asChildOf(null as SpanContext?)) doReturn localSpanBuilder
1091-
whenever(localSpanBuilder.withOrigin(getExpectedOrigin())) doReturn localSpanBuilder
1092-
whenever(localSpanBuilder.start()) doReturn localSpan
1093-
whenever(localSpan.context()) doReturn mockSpanContext
10941094
whenever(mockTraceSampler.sample(localSpan)).thenReturn(true)
1095-
whenever(mockSpanContext.spanId) doReturn fakeSpanId
1096-
whenever(mockSpanContext.traceId) doReturn fakeTraceId
10971095
whenever(mockLocalTracer.buildSpan(TracingInterceptor.SPAN_NAME)) doReturn localSpanBuilder
1096+
val testedInterceptorNoGlobal = instantiateTestedInterceptor(
1097+
fakeLocalHosts,
1098+
localTracerFactory = { _, _ -> mockLocalTracer },
1099+
globalTracerProvider = { null }
1100+
)
10981101

1099-
val response1 = testedInterceptor.intercept(mockChain)
1102+
val response1 = testedInterceptorNoGlobal.intercept(mockChain)
11001103
val expectedResponse1 = fakeResponse
11011104
stubChain(mockChain, statusCode)
11021105
val response2 = testedInterceptor.intercept(mockChain)

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/trace/TracingInterceptorTest.kt

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,11 @@ internal open class TracingInterceptorTest {
180180
whenever(rumMonitor.mockSdkCore.getFeature(Feature.TRACING_FEATURE_NAME)) doReturn mock()
181181
whenever(rumMonitor.mockSdkCore.internalLogger) doReturn mockInternalLogger
182182
whenever(rumMonitor.mockSdkCore.firstPartyHostResolver) doReturn mockResolver
183-
testedInterceptor = instantiateTestedInterceptor(fakeLocalHosts) { _, _ ->
184-
mockLocalTracer
185-
}
183+
testedInterceptor = instantiateTestedInterceptor(
184+
fakeLocalHosts,
185+
globalTracerProvider = { mockTracer },
186+
localTracerFactory = { _, _ -> mockLocalTracer }
187+
)
186188
}
187189

188190
@Test
@@ -216,18 +218,19 @@ internal open class TracingInterceptorTest {
216218

217219
open fun instantiateTestedInterceptor(
218220
tracedHosts: Map<String, Set<TracingHeaderType>> = emptyMap(),
219-
factory: (SdkCore, Set<TracingHeaderType>) -> Tracer
221+
globalTracerProvider: () -> Tracer? = { null },
222+
localTracerFactory: (SdkCore, Set<TracingHeaderType>) -> Tracer
220223
): TracingInterceptor {
221224
return TracingInterceptor(
222225
sdkInstanceName = null,
223226
tracedHosts = tracedHosts,
224227
tracedRequestListener = mockRequestListener,
225228
traceOrigin = fakeOrigin,
226229
traceSampler = mockTraceSampler,
227-
localTracerFactory = factory,
230+
localTracerFactory = localTracerFactory,
228231
redacted404ResourceName = fakeRedacted404Resources,
229232
traceContextInjection = TraceContextInjection.ALL,
230-
globalTracerProvider = { null }
233+
globalTracerProvider = globalTracerProvider
231234
)
232235
}
233236

@@ -1281,8 +1284,13 @@ internal open class TracingInterceptorTest {
12811284
stubChain(mockChain, statusCode)
12821285
whenever(mockTraceSampler.sample(localSpan)).thenReturn(true)
12831286
whenever(mockLocalTracer.buildSpan(TracingInterceptor.SPAN_NAME)) doReturn localSpanBuilder
1287+
val testedInterceptorNoGlobal = instantiateTestedInterceptor(
1288+
fakeLocalHosts,
1289+
localTracerFactory = { _, _ -> mockLocalTracer },
1290+
globalTracerProvider = { null }
1291+
)
12841292

1285-
val response = testedInterceptor.intercept(mockChain)
1293+
val response = testedInterceptorNoGlobal.intercept(mockChain)
12861294

12871295
verify(localSpanBuilder).withOrigin(getExpectedOrigin())
12881296
verify(localSpan).setTag("http.url", fakeUrl.lowercase(Locale.US))
@@ -1313,8 +1321,13 @@ internal open class TracingInterceptorTest {
13131321
whenever(mockSpanContext.spanId) doReturn fakeSpanId
13141322
whenever(mockSpanContext.traceId) doReturn fakeTraceId
13151323
whenever(mockLocalTracer.buildSpan(TracingInterceptor.SPAN_NAME)) doReturn localSpanBuilder
1324+
val testedInterceptorNoGlobal = instantiateTestedInterceptor(
1325+
fakeLocalHosts,
1326+
localTracerFactory = { _, _ -> mockLocalTracer },
1327+
globalTracerProvider = { null }
1328+
)
13161329

1317-
val response1 = testedInterceptor.intercept(mockChain)
1330+
val response1 = testedInterceptorNoGlobal.intercept(mockChain)
13181331
val expectedResponse1 = fakeResponse
13191332
stubChain(mockChain, statusCode)
13201333
val response2 = testedInterceptor.intercept(mockChain)

0 commit comments

Comments
 (0)