Merge pull request #2763 from DataDog/yl/remove-main-thread-post

RUM-10143: Stop posting recorded data item from main thread

Author: ambushwork

features/dd-sdk-android-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/async/RecordedDataQueueHandler.kt

@@ -99,7 +99,6 @@ internal class RecordedDataQueueHandler(
      * for example if a snapshot failed to traverse the tree).
      * If neither of the previous conditions occurs, the loop breaks.
      */
-    @MainThread
     override fun tryToConsumeItems() {
         // no need to create a thread if the queue is empty
         if (recordedDataQueue.isEmpty()) {

features/dd-sdk-android-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/async/RecordedDataQueueRefs.kt

@@ -6,15 +6,11 @@
 
 package com.datadog.android.sessionreplay.internal.async
 
-import android.os.Handler
-import android.os.Looper
-
 /**
  * References to the work queue context.
  */
 internal data class RecordedDataQueueRefs(
-    private val recordedDataQueueHandler: RecordedDataQueueHandler,
-    private val mainThreadHandler: Handler = Handler(Looper.getMainLooper())
+    private val recordedDataQueueHandler: RecordedDataQueueHandler
 ) {
     // this can only be populated after the snapshot has been created
     internal var recordedDataQueueItem: SnapshotRecordedDataQueueItem? = null
@@ -28,9 +24,6 @@ internal data class RecordedDataQueueRefs(
     }
 
     internal fun tryToConsumeItem() {
-        mainThreadHandler.post {
-            @Suppress("ThreadSafety") // we are in the main thread context
-            recordedDataQueueHandler.tryToConsumeItems()
-        }
+        recordedDataQueueHandler.tryToConsumeItems()
     }
 }

features/dd-sdk-android-session-replay/src/test/kotlin/com/datadog/android/sessionreplay/internal/async/RecordedDataQueueRefsTest.kt

@@ -6,7 +6,6 @@
 
 package com.datadog.android.sessionreplay.internal.async
 
-import android.os.Handler
 import com.datadog.android.sessionreplay.forge.ForgeConfigurator
 import fr.xgouchet.elmyr.junit5.ForgeConfiguration
 import fr.xgouchet.elmyr.junit5.ForgeExtension
@@ -15,10 +14,8 @@ import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
 import org.junit.jupiter.api.extension.Extensions
 import org.mockito.Mock
-import org.mockito.Mockito.`when`
 import org.mockito.junit.jupiter.MockitoExtension
 import org.mockito.junit.jupiter.MockitoSettings
-import org.mockito.kotlin.any
 import org.mockito.kotlin.verify
 import org.mockito.quality.Strictness
 
@@ -37,18 +34,9 @@ internal class RecordedDataQueueRefsTest {
     @Mock
     lateinit var mockRecordedDataQueueItem: SnapshotRecordedDataQueueItem
 
-    @Mock
-    lateinit var mockHandler: Handler
-
     @BeforeEach
     fun setup() {
-        // make mockHandler execute all runnables immediately
-        `when`(mockHandler.post(any())).thenAnswer {
-            (it.arguments[0] as Runnable).run()
-            true
-        }
-
-        testedDataQueueRefs = RecordedDataQueueRefs(mockDataQueueHandler, mockHandler)
+        testedDataQueueRefs = RecordedDataQueueRefs(mockDataQueueHandler)
         testedDataQueueRefs.recordedDataQueueItem = mockRecordedDataQueueItem
     }