Skip to content

Commit 0409ba1

Browse files
authored
Add some unit tests for class Curl. (#16)
1 parent c4c7812 commit 0409ba1

File tree

7 files changed

+643
-79
lines changed

7 files changed

+643
-79
lines changed

CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ target_sources(dd_trace_cpp PRIVATE
102102
src/datadog/trace_sampler_config.cpp
103103
src/datadog/trace_sampler.cpp
104104
src/datadog/trace_segment.cpp
105-
src/datadog/version.cpp
105+
src/datadog/version.cpp
106106
)
107107

108108
# This library's public headers are just its source headers.
@@ -164,12 +164,12 @@ target_sources(dd_trace_cpp PUBLIC
164164

165165
add_dependencies(dd_trace_cpp curl)
166166

167-
# Make the build libcurl visible to dd_trace_cpp, but not to its dependents.
168-
target_include_directories(dd_trace_cpp PRIVATE ${CMAKE_BINARY_DIR}/include)
167+
# Make the build libcurl visible to dd_trace_cpp, and its dependents.
168+
target_include_directories(dd_trace_cpp PUBLIC ${CMAKE_BINARY_DIR}/include)
169169

170170
# Linking this library requires libcurl and threads.
171171
find_package(Threads REQUIRED)
172-
target_link_libraries(dd_trace_cpp PRIVATE ${CMAKE_BINARY_DIR}/lib/libcurl.a PUBLIC Threads::Threads ${COVERAGE_LIBRARIES})
172+
target_link_libraries(dd_trace_cpp PUBLIC ${CMAKE_BINARY_DIR}/lib/libcurl.a PUBLIC Threads::Threads ${COVERAGE_LIBRARIES})
173173

174174
# When installing, install the library and its public headers.
175175

0 commit comments

Comments
 (0)