Skip to content

Commit 07796a0

Browse files
committed
fix attempt 2
1 parent c558ae3 commit 07796a0

File tree

2 files changed

+20
-13
lines changed

2 files changed

+20
-13
lines changed

.gitlab-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
stages:
22
- benchmarks
3-
- benchmarks-gate
3+
- benchmarks-report
44

55
include: ".gitlab/benchmarks.yml"

.gitlab/benchmarks.yml

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,13 @@ benchmarks:
1111
script:
1212
- export ARTIFACTS_DIR="$(pwd)/reports" && (mkdir "${ARTIFACTS_DIR}" || :)
1313
- git config --global url."https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/".insteadOf "https://github.com/DataDog/"
14-
- git clone --branch dd-trace-cpp https://github.com/DataDog/benchmarking-platform /platform && cd /platform
15-
- ./steps/capture-hardware-software-info.sh
16-
- ./steps/run-benchmarks.sh
17-
- ./steps/analyze-results.sh
18-
- "./steps/upload-results-to-s3.sh || :"
19-
- "./steps/post-pr-comment.sh || :"
14+
- git clone --branch dd-trace-cpp https://github.com/DataDog/benchmarking-platform /platform
15+
- export PATH="$PATH:/platform/steps"
16+
- capture-hardware-software-info.sh
17+
- run-benchmarks.sh
18+
- analyze-results.sh
19+
- "upload-results-to-s3.sh || :"
20+
- "post-pr-comment.sh || :"
2021
artifacts:
2122
name: "reports"
2223
when: always
@@ -33,15 +34,21 @@ benchmarks:
3334
FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY: "true"
3435

3536
check-big-regressions:
36-
stage: benchmarks-gate
37+
stage: benchmarks-report
3738
needs: [ benchmarks ]
3839
when: on_success
40+
allow_failure: false
3941
tags: ["arch:amd64"]
4042
image: $BENCHMARKS_CI_IMAGE
41-
script:
42-
- export ARTIFACTS_DIR="$(pwd)/reports/"
43-
- git config --global url."https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/".insteadOf "https://github.com/DataDog/"
44-
- cd reports && (git init && git remote add origin https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/benchmarking-platform && git pull origin dd-trace-cpp)
45-
- bp-runner bp-runner.fail-on-regression.yml --debug
43+
script: |
44+
export ARTIFACTS_DIR="$(pwd)/reports/"
45+
if [[ -n "$CI_JOB_TOKEN" ]];
46+
then
47+
git config --global url."https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/".insteadOf "https://github.com/DataDog/"
48+
fi
49+
git clone --branch dd-trace-cpp https://github.com/DataDog/benchmarking-platform /platform
50+
export PATH="$PATH:/platform/steps"
51+
52+
bp-runner /platform/bp-runner.fail-on-regression.yml --debug
4653
variables:
4754
KUBERNETES_SERVICE_ACCOUNT_OVERWRITE: dd-trace-cpp

0 commit comments

Comments
 (0)