Skip to content

Commit 0b36277

Browse files
authored
chore: update some out-of-date comments and documentation (#176)
* comments: extract_or_create_span does not return an error * comments: NullCollector is used in unit tests only * documentation: src/ has been split into include/ and src/
1 parent 1a5985e commit 0b36277

File tree

3 files changed

+4
-21
lines changed

3 files changed

+4
-21
lines changed

include/datadog/null_collector.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
#pragma once
22

33
// This component provides a `class`, `NullCollector`, that implements the
4-
// `Collector` interface in terms of a no-op. It's used by `Tracer` in lieu
5-
// of a `DatadogAgent` whenever `TracerConfig::report_traces` is `false`.
4+
// `Collector` interface in terms of a no-op. It's used in unit tests.
65

76
#include "collector.h"
87

include/datadog/tracer.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,9 @@ class Tracer {
7171
const SpanConfig& config);
7272

7373
// Return a span extracted from the specified `reader` (see `extract_span`).
74-
// If there is no span to extract, then return a span that is the root of a
75-
// new trace (see `create_span`). Optionally specify a `config` indicating
76-
// the attributes of the span. If a failure occurs, then return an error.
77-
// Note that the absence of a span to extract is not considered an error.
74+
// If there is no span to extract, or if an error occurs during extraction,
75+
// then return a span that is the root of a new trace (see `create_span`).
76+
// Optionally specify a `config` indicating the attributes of the span.
7877
Span extract_or_create_span(const DictReader& reader);
7978
Span extract_or_create_span(const DictReader& reader,
8079
const SpanConfig& config);

src/README.md

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)