feat!: Change the default value of DD_TRACE_RATE_LIMIT to 100 (#159)

zacharycmontoya · web-flow · commit 1bcd5b1a3203 · 2024-10-07T06:18:43.000-07:00
Issues: APMAPI-511
diff --git a/src/datadog/trace_sampler_config.cpp b/src/datadog/trace_sampler_config.cpp
@@ -224,7 +224,7 @@ Expected<FinalizedTraceSamplerConfig> finalize_config(
   }
 
   const auto [origin, max_per_second] =
-      pick(env_config->max_per_second, config.max_per_second, 200);
+      pick(env_config->max_per_second, config.max_per_second, 100);
   result.metadata[ConfigName::TRACE_SAMPLING_LIMIT] = ConfigMetadata(
       ConfigName::TRACE_SAMPLING_LIMIT, std::to_string(max_per_second), origin);
 
diff --git a/test/test_tracer_config.cpp b/test/test_tracer_config.cpp
@@ -707,10 +707,10 @@ TEST_CASE("TracerConfig::trace_sampler") {
   }
 
   SECTION("max_per_second") {
-    SECTION("defaults to 200") {
+    SECTION("defaults to 100") {
       auto finalized = finalize_config(config);
       REQUIRE(finalized);
-      REQUIRE(finalized->trace_sampler.max_per_second == 200);
+      REQUIRE(finalized->trace_sampler.max_per_second == 100);
     }
 
     SECTION("must be >0 and a finite number") {

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ Expected<FinalizedTraceSamplerConfig> finalize_config(`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`const auto [origin, max_per_second] =`
`227`		`- pick(env_config->max_per_second, config.max_per_second, 200);`
	`227`	`+ pick(env_config->max_per_second, config.max_per_second, 100);`
`228`	`228`	`result.metadata[ConfigName::TRACE_SAMPLING_LIMIT] = ConfigMetadata(`
`229`	`229`	`ConfigName::TRACE_SAMPLING_LIMIT, std::to_string(max_per_second), origin);`
`230`	`230`
Original file line number	Diff line number	Diff line change
`@@ -707,10 +707,10 @@ TEST_CASE("TracerConfig::trace_sampler") {`
`707`	`707`	`}`
`708`	`708`
`709`	`709`	`SECTION("max_per_second") {`
`710`		`- SECTION("defaults to 200") {`
	`710`	`+ SECTION("defaults to 100") {`
`711`	`711`	`auto finalized = finalize_config(config);`
`712`	`712`	`REQUIRE(finalized);`
`713`		`- REQUIRE(finalized->trace_sampler.max_per_second == 200);`
	`713`	`+ REQUIRE(finalized->trace_sampler.max_per_second == 100);`
`714`	`714`	`}`
`715`	`715`
`716`	`716`	`SECTION("must be >0 and a finite number") {`