Apply suggestions from code review

dmehala · zacharycmontoya · dmehala · commit 2fb3270ea532 · 2025-09-04T11:12:11.000+02:00
Co-authored-by: Zach Montoya &lt;zach.montoya@datadoghq.com&gt;
diff --git a/test/test_config_manager.cpp b/test/test_config_manager.cpp
@@ -486,12 +486,12 @@ CONFIG_MANAGER_TEST("remote configuration handling") {
           {
               __LINE__,
               "invalid value for `tags` field",
-              R"("tracing_sampling_rules": [{"service": "bar", "resource": "yo", "sample_rate": "0.5", "provenance": "customer", "tags": "tag1"}])",
+              R"("tracing_sampling_rules": [{"service": "bar", "resource": "yo", "sample_rate": 0.2, "provenance": "customer", "tags": "tag1"}])",
           },
           {
               __LINE__,
               "invalid second rules",
-              R"("tracing_sampling_rules": [{"service": "bar", "resource": "yo", "sample_rate": "0.5", "provenance": "customer"}, {"foo": "bar"}])",
+              R"("tracing_sampling_rules": [{"service": "bar", "resource": "yo", "sample_rate": 0.2, "provenance": "customer"}, {"foo": "bar"}])",
           },
       }));
 

Original file line number	Diff line number	Diff line change
`@@ -486,12 +486,12 @@ CONFIG_MANAGER_TEST("remote configuration handling") {`
`486`	`486`	`{`
`487`	`487`	`__LINE__,`
`488`	`488`	"invalid value for `tags` field",
`489`		`- R"("tracing_sampling_rules": [{"service": "bar", "resource": "yo", "sample_rate": "0.5", "provenance": "customer", "tags": "tag1"}])",`
	`489`	`+ R"("tracing_sampling_rules": [{"service": "bar", "resource": "yo", "sample_rate": 0.2, "provenance": "customer", "tags": "tag1"}])",`
`490`	`490`	`},`
`491`	`491`	`{`
`492`	`492`	`__LINE__,`
`493`	`493`	`"invalid second rules",`
`494`		`- R"("tracing_sampling_rules": [{"service": "bar", "resource": "yo", "sample_rate": "0.5", "provenance": "customer"}, {"foo": "bar"}])",`
	`494`	`+ R"("tracing_sampling_rules": [{"service": "bar", "resource": "yo", "sample_rate": 0.2, "provenance": "customer"}, {"foo": "bar"}])",`
`495`	`495`	`},`
`496`	`496`	`}));`
`497`	`497`