nits

dgoffredo · dgoffredo · commit 67b2f96cc0db · 2022-12-16T12:57:30.000-05:00
diff --git a/src/datadog/optional.h b/src/datadog/optional.h
@@ -57,7 +57,7 @@ auto value_or(Value&& value) {
 
 template <typename Value, typename... Rest>
 auto value_or(Optional<Value> maybe, Rest&&... rest) {
-  return maybe.value_or(value_or(rest...));
+  return maybe.value_or(value_or(std::forward<Rest>(rest)...));
 }
 
 }  // namespace tracing
diff --git a/src/datadog/tracer_config.cpp b/src/datadog/tracer_config.cpp
@@ -145,7 +145,7 @@ Optional<PropagationStyles> styles_from_env(environment::Variable env_var) {
 std::string json_quoted(StringView text) {
   std::string unquoted;
   assign(unquoted, text);
-  return nlohmann::json(unquoted).dump();
+  return nlohmann::json(std::move(unquoted)).dump();
 }
 
 Expected<void> finalize_propagation_styles(FinalizedTracerConfig &result,

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ auto value_or(Value&& value) {`
`57`	`57`
`58`	`58`	`template <typename Value, typename... Rest>`
`59`	`59`	`auto value_or(Optional<Value> maybe, Rest&&... rest) {`
`60`		`- return maybe.value_or(value_or(rest...));`
	`60`	`+ return maybe.value_or(value_or(std::forward<Rest>(rest)...));`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`} // namespace tracing`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ Optional<PropagationStyles> styles_from_env(environment::Variable env_var) {`
`145`	`145`	`std::string json_quoted(StringView text) {`
`146`	`146`	`std::string unquoted;`
`147`	`147`	`assign(unquoted, text);`
`148`		`- return nlohmann::json(unquoted).dump();`
	`148`	`+ return nlohmann::json(std::move(unquoted)).dump();`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`Expected<void> finalize_propagation_styles(FinalizedTracerConfig &result,`