Remove the remote config check asserting a matching env / service, as this is incorrect behavior

Author: zacharycmontoya

src/datadog/config_manager.cpp

@@ -151,14 +151,6 @@ Optional<std::string> ConfigManager::on_update(const Configuration& config) {
 
   const auto config_json = nlohmann::json::parse(config.content);
 
-  const auto& targeted_service = config_json.at("service_target");
-  if (targeted_service.at("service").get<StringView>() !=
-          tracer_signature_.default_service ||
-      targeted_service.at("env").get<StringView>() !=
-          tracer_signature_.default_environment) {
-    return "Wrong service targeted";
-  }
-
   auto config_update = parse_dynamic_config(config_json.at("lib_config"));
 
   auto config_metadata = apply_update(config_update);

test/test_config_manager.cpp

@@ -38,24 +38,6 @@ CONFIG_MANAGER_TEST("remote configuration handling") {
                                             /* version = */ 1,
                                             rc::product::Flag::APM_TRACING};
 
-  SECTION(
-      "configuration updates targetting the wrong tracer reports an error") {
-    // clang-format off
-    auto test_case = GENERATE(values<std::string>({
-      R"({ "service_target": { "service": "not-testsvc", "env": "test" } })",
-      R"({ "service_target": { "service": "testsvc", "env": "not-test" } })"
-    }));
-    // clang-format on
-
-    CAPTURE(test_case);
-
-    config_update.content = test_case;
-
-    // TODO: targetting wrong procut -> error
-    const auto err = config_manager.on_update(config_update);
-    CHECK(err);
-  }
-
   SECTION("handling of `tracing_sampling_rate`") {
     // SECTION("invalid value") {
     //   config_update.content = R"({