Skip to content

Commit a0f9a74

Browse files
authored
Span tags for "unified naming conventions" (#20)
* net_util -> platform_util * get_process_id() * move pthread_atfork into platform_util.cpp * Tag every span with the process ID. - glibc does not cache the process ID in user space. So, as a (premature?) optimization, we cache the process ID and recalculate it whenever the process forks. - The existing behavior of tagging each span with _dd.origin wasn't tested, so in testing this process ID change I also added a test for origin. * Tag every span with the language "cpp". * move random number generation into its own component * Tag every span with a resource-id UUID. * update includes graph * missed a spot * fix typo * be consistent with the order * wrong again! * inline some at_fork handlers * remove unnecessary includes * comment the cached_* functions * fix tag name: error.msg -> error.message * remove unnecessary caveat * delambdify * generate 64 bits of randomness in a go, not 63 * modify bits high-to-low * zero most significant bit of 64-bit trace IDs * zero most significant bit of span IDs
1 parent ae90dc5 commit a0f9a74

21 files changed

+2596
-2258
lines changed

BUILD.bazel

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,12 @@ cc_library(
2424
"src/datadog/limiter.cpp",
2525
"src/datadog/logger.cpp",
2626
"src/datadog/msgpack.cpp",
27-
"src/datadog/net_util.cpp",
2827
"src/datadog/null_collector.cpp",
2928
"src/datadog/optional.cpp",
3029
"src/datadog/parse_util.cpp",
30+
"src/datadog/platform_util.cpp",
3131
"src/datadog/propagation_style.cpp",
32+
"src/datadog/random.cpp",
3233
"src/datadog/rate.cpp",
3334
"src/datadog/sampling_decision.cpp",
3435
"src/datadog/sampling_mechanism.cpp",
@@ -79,11 +80,12 @@ cc_library(
7980
"src/datadog/limiter.h",
8081
"src/datadog/logger.h",
8182
"src/datadog/msgpack.h",
82-
"src/datadog/net_util.h",
8383
"src/datadog/null_collector.h",
8484
"src/datadog/optional.h",
8585
"src/datadog/parse_util.h",
86+
"src/datadog/platform_util.h",
8687
"src/datadog/propagation_style.h",
88+
"src/datadog/random.h",
8789
"src/datadog/rate.h",
8890
"src/datadog/sampling_decision.h",
8991
"src/datadog/sampling_mechanism.h",

CMakeLists.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,12 @@ target_sources(dd_trace_cpp PRIVATE
9393
src/datadog/limiter.cpp
9494
src/datadog/logger.cpp
9595
src/datadog/msgpack.cpp
96-
src/datadog/net_util.cpp
9796
src/datadog/null_collector.cpp
9897
src/datadog/optional.cpp
9998
src/datadog/parse_util.cpp
99+
src/datadog/platform_util.cpp
100100
src/datadog/propagation_style.cpp
101+
src/datadog/random.cpp
101102
src/datadog/rate.cpp
102103
src/datadog/sampling_decision.cpp
103104
src/datadog/sampling_mechanism.cpp
@@ -154,11 +155,12 @@ target_sources(dd_trace_cpp PUBLIC
154155
src/datadog/limiter.h
155156
src/datadog/logger.h
156157
src/datadog/msgpack.h
157-
src/datadog/net_util.h
158158
src/datadog/null_collector.h
159159
src/datadog/optional.h
160160
src/datadog/parse_util.h
161+
src/datadog/platform_util.h
161162
src/datadog/propagation_style.h
163+
src/datadog/random.h
162164
src/datadog/rate.h
163165
src/datadog/sampling_decision.h
164166
src/datadog/sampling_mechanism.h

doc/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ all: ownership.svg includes.svg
44
%.svg: %.dot
55
dot -Grankdir=LR -Tsvg -o $@ $<
66

7-
includes.dot: $(wildcard ../src/*)
7+
includes.dot: $(wildcard ../src/datadog/*)
88
raco graph-includes --exclude-std-c --exclude-std-cpp --exclude-posix --extension h --extension cpp ../src/ >$@

0 commit comments

Comments
 (0)