Apply suggestions from code review

Co-authored-by: pablomartinezbernardo <[email protected]>

Author: dmehala

src/datadog/telemetry/telemetry_impl.h

@@ -18,9 +18,6 @@
 
 namespace datadog::telemetry {
 
-// This uses a reference_wrapper so references to internal metric values can
-// be captured, and be iterated trivially when the values need to be
-// snapshotted and published in telemetry messages.
 using MetricSnapshot = std::vector<std::pair<std::time_t, uint64_t>>;
 
 /// The telemetry class is responsible for handling internal telemetry data to

src/datadog/tracer.cpp

@@ -382,7 +382,7 @@ Expected<Span> Tracer::extract_span(const DictReader& reader,
 
   const auto span_data_ptr = span_data.get();
   telemetry::counter::increment(metrics::tracer::trace_segments_created,
-                                {"new_continued:new"});
+                                {"new_continued:continued"});
   const auto segment = std::make_shared<TraceSegment>(
       logger_, collector_, config_manager_->trace_sampler(), span_sampler_,
       config_manager_->span_defaults(), config_manager_, runtime_id_,
@@ -445,11 +445,11 @@ Expected<void> Tracer::inject(const Baggage& baggage, DictWriter& writer) {
     if (err->code == Error::Code::BAGGAGE_MAXIMUM_BYTES_REACHED) {
       telemetry::counter::increment(
           metrics::tracer::context_header_truncated,
-          {"truncation_reason:baggage_item_count_exceeded"});
+          {"truncation_reason:baggage_byte_count_exceeded"});
     } else if (err->code == Error::Code::BAGGAGE_MAXIMUM_ITEMS_REACHED) {
       telemetry::counter::increment(
           metrics::tracer::context_header_truncated,
-          {"truncation_reason:baggage_byte_count_exceeded"});
+          {"truncation_reason:baggage_item_count_exceeded"});
     }
   }