Apply suggestions from code review

dmehala · web-flow · commit e48984d0ec47 · 2025-05-13T11:24:40.000+02:00
diff --git a/src/datadog/platform_util.cpp b/src/datadog/platform_util.cpp
@@ -338,8 +338,6 @@ Optional<Cgroup> get_cgroup_version() {
 }
 
 Optional<std::string> find_docker_container_id_from_cgroup() {
-  constexpr std::string_view cgroup_path = "/proc/self/cgroup";
-
   auto cgroup_fd = std::ifstream("/proc/self/cgroup", std::ios::in);
   if (!cgroup_fd.is_open()) return nullopt;
 

Original file line number	Diff line number	Diff line change
`@@ -338,8 +338,6 @@ Optional<Cgroup> get_cgroup_version() {`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`Optional<std::string> find_docker_container_id_from_cgroup() {`
`341`		`- constexpr std::string_view cgroup_path = "/proc/self/cgroup";`
`342`		`-`
`343`	`341`	`auto cgroup_fd = std::ifstream("/proc/self/cgroup", std::ios::in);`
`344`	`342`	`if (!cgroup_fd.is_open()) return nullopt;`
`345`	`343`