Skip to content

Commit f25e15e

Browse files
committed
Fix json dump of configuration
1 parent b4f4cbe commit f25e15e

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

include/datadog/null_collector.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ class NullCollector : public Collector {
1919
std::string config() const override {
2020
// clang-format off
2121
return R"({
22-
{"type", "datadog::tracing::NullCollector"},
23-
{"config", {}}
22+
"type": "datadog::tracing::NullCollector",
23+
"config": {}
2424
})";
2525
// clang-format on
2626
};

src/datadog/datadog_agent.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,8 @@ std::string DatadogAgent::config() const {
254254
{"flush_interval_milliseconds", std::chrono::duration_cast<std::chrono::milliseconds>(flush_interval_).count() },
255255
{"request_timeout_milliseconds", std::chrono::duration_cast<std::chrono::milliseconds>(request_timeout_).count() },
256256
{"shutdown_timeout_milliseconds", std::chrono::duration_cast<std::chrono::milliseconds>(shutdown_timeout_).count() },
257-
{"http_client", http_client_->config()},
258-
{"event_scheduler", event_scheduler_->config()},
257+
{"http_client", nlohmann::json::parse(http_client_->config())},
258+
{"event_scheduler", nlohmann::json::parse(event_scheduler_->config())},
259259
})},
260260
}).dump();
261261
// clang-format on

src/datadog/span_sampler.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,8 @@ nlohmann::json SpanSampler::config_json() const {
7373
}
7474

7575
return nlohmann::json::object({
76-
{"rules", rules},
77-
})
78-
.dump();
76+
{"rules", rules},
77+
});
7978
}
8079

8180
} // namespace tracing

src/datadog/tracer.cpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,19 @@ Tracer::Tracer(const FinalizedTracerConfig& config,
8383
}
8484
}
8585

86+
void to_json(nlohmann::json& j, const PropagationStyle& style) {
87+
j = to_string_view(style);
88+
}
89+
8690
std::string Tracer::config() const {
8791
// clang-format off
8892
auto config = nlohmann::json::object({
8993
{"version", tracer_version_string},
9094
{"runtime_id", runtime_id_.string()},
91-
{"collector", collector_->config()},
95+
{"collector", nlohmann::json::parse(collector_->config())},
9296
{"span_sampler", span_sampler_->config_json()},
93-
{"injection_styles", join_propagation_styles(injection_styles_)},
94-
{"extraction_styles", join_propagation_styles(extraction_styles_)},
97+
{"injection_styles", injection_styles_},
98+
{"extraction_styles", extraction_styles_},
9599
{"tags_header_size", tags_header_max_size_},
96100
{"environment_variables", environment::to_json()},
97101
});

0 commit comments

Comments
 (0)