[Dynamic Instrumentation] DEBUG-3514 Refactor debugger code (#7304)

## Summary of changes
Refactoring of all debugger related code to reflect the current debugger
suite and as a pre work for in product enablement.

## Test coverage
All existing tests

Author: dudikeleti

tracer/missing-nullability-files.csv

@@ -103,9 +103,6 @@ src/Datadog.Trace/ContinuousProfiler/ProfilerStatus.cs
 src/Datadog.Trace/DatabaseMonitoring/MultiPartIdentifier.cs
 src/Datadog.Trace/DatabaseMonitoring/VendoredSqlHelpers.cs
 src/Datadog.Trace/DataStreamsMonitoring/CheckpointKind.cs
-src/Datadog.Trace/Debugger/ILineProbeResolver.cs
-src/Datadog.Trace/Debugger/LiveDebugger.cs
-src/Datadog.Trace/Debugger/ProbeLocationType.cs
 src/Datadog.Trace/DiagnosticListeners/AspNetCoreDiagnosticObserver.cs
 src/Datadog.Trace/DiagnosticListeners/DiagnosticManager.cs
 src/Datadog.Trace/DiagnosticListeners/DiagnosticObserver.cs

tracer/src/Datadog.Trace.Trimming/build/Datadog.Trace.Trimming.xml

@@ -1036,6 +1036,7 @@
       <type fullname="System.Threading.Monitor" />
       <type fullname="System.Threading.Mutex" />
       <type fullname="System.Threading.ReaderWriterLockSlim" />
+      <type fullname="System.Threading.SemaphoreFullException" />
       <type fullname="System.Threading.SemaphoreSlim" />
       <type fullname="System.Threading.SpinLock" />
       <type fullname="System.Threading.SpinWait" />

tracer/src/Datadog.Trace/ClrProfiler/DynamicInstrumentationHelper.cs

@@ -408,39 +408,13 @@ private static void InitializeTracer(Stopwatch sw)
             {
                 try
                 {
-                    DynamicInstrumentationHelper.ServiceName = TraceUtil.NormalizeTag(tracer.Settings.ServiceName ?? tracer.DefaultServiceName);
-                }
-                catch (Exception e)
-                {
-                    DynamicInstrumentationHelper.ServiceName = tracer.DefaultServiceName;
-                    Log.Error(e, "Could not set `DynamicInstrumentationHelper.ServiceName`.");
-                }
-
-                try
-                {
-                    InitLiveDebugger(tracer);
+                    InitializeDebugger(tracer.Settings);
                 }
                 catch (Exception e)
                 {
                     Log.Error(e, "Failed to initialize Remote Configuration Management.");
                 }
 
-                try
-                {
-                    if (ExceptionDebugging.Enabled)
-                    {
-                        ExceptionDebugging.Initialize();
-                    }
-                    else
-                    {
-                        Log.Information("Exception Replay is disabled. To enable it, please set DD_EXCEPTION_REPLAY_ENABLED environment variable to '1'/'true'.");
-                    }
-                }
-                catch (Exception ex)
-                {
-                    Log.Error(ex, "Error initializing Exception Debugging");
-                }
-
                 // RCM isn't _actually_ initialized at this point, as we do it in the background, so we record that separately
                 sw.Restart();
 
@@ -490,51 +464,18 @@ private static void StartDiagnosticManager()
         }
 #endif
 
-        private static void InitLiveDebugger(Tracer tracer)
+        private static void InitializeDebugger(TracerSettings tracerSettings)
         {
-            var settings = tracer.Settings;
-            var debuggerSettings = DebuggerSettings.FromDefaultSource();
-
-            if (!settings.IsRemoteConfigurationAvailable)
-            {
-                // live debugger requires RCM, so there's no point trying to initialize it if RCM is not available
-                if (debuggerSettings.Enabled)
-                {
-                    Log.Warning("Live Debugger is enabled but remote configuration is not available in this environment, so live debugger cannot be enabled.");
-                }
-
-                tracer.TracerManager.Telemetry.ProductChanged(TelemetryProductType.DynamicInstrumentation, enabled: false, error: null);
-                return;
-            }
-
-            // Service Name must be lowercase, otherwise the agent will not be able to find the service
-            var serviceName = DynamicInstrumentationHelper.ServiceName;
-            var discoveryService = tracer.TracerManager.DiscoveryService;
-
-            Task.Run(
+            _ = Task.Run(
                 async () =>
                 {
-                    // TODO: LiveDebugger should be initialized in TracerManagerFactory so it can respond
-                    // to changes in ExporterSettings etc.
-
                     try
                     {
-                        var sw = Stopwatch.StartNew();
-                        var isDiscoverySuccessful = await WaitForDiscoveryService(discoveryService).ConfigureAwait(false);
-                        TelemetryFactory.Metrics.RecordDistributionSharedInitTime(MetricTags.InitializationComponent.DiscoveryService, sw.ElapsedMilliseconds);
-
-                        if (isDiscoverySuccessful)
-                        {
-                            var liveDebugger = LiveDebuggerFactory.Create(discoveryService, RcmSubscriptionManager.Instance, settings, serviceName, tracer.TracerManager.Telemetry, debuggerSettings, tracer.TracerManager.GitMetadataTagsProvider);
-
-                            Log.Debug("Initializing live debugger.");
-
-                            await InitializeLiveDebugger(liveDebugger).ConfigureAwait(false);
-                        }
+                        await DebuggerManager.Instance.UpdateConfiguration(tracerSettings).ConfigureAwait(false);
                     }
                     catch (Exception ex)
                     {
-                        Log.Error(ex, "Error initializing live debugger.");
+                        Log.Error(ex, "Error initializing debugger");
                     }
                 });
         }
@@ -557,21 +498,6 @@ void Callback(AgentConfiguration x)
             }
         }
 
-        internal static async Task InitializeLiveDebugger(LiveDebugger liveDebugger)
-        {
-            var sw = Stopwatch.StartNew();
-            try
-            {
-                await liveDebugger.InitializeAsync().ConfigureAwait(false);
-            }
-            catch (Exception ex)
-            {
-                Log.Error(ex, "Failed to initialize Live Debugger");
-            }
-
-            TelemetryFactory.Metrics.RecordDistributionSharedInitTime(MetricTags.InitializationComponent.DynamicInstrumentation, sw.ElapsedMilliseconds);
-        }
-
         internal static void EnableTracerInstrumentations(InstrumentationCategory categories, Stopwatch sw = null)
         {
             var defs = NativeMethods.EnableCallTargetDefinitions((uint)categories);

tracer/src/Datadog.Trace/ClrProfiler/Instrumentation.cs

@@ -14,11 +14,11 @@ internal static partial class ConfigurationKeys
         internal static class Debugger
         {
             /// <summary>
-            /// Configuration key for enabling or disabling Live Debugger.
+            /// Configuration key for enabling or disabling Dynamic Instrumentation.
             /// Default value is false (disabled).
             /// </summary>
-            /// <seealso cref="DebuggerSettings.Enabled"/>
-            public const string Enabled = "DD_DYNAMIC_INSTRUMENTATION_ENABLED";
+            /// <seealso cref="DebuggerSettings.DynamicInstrumentationEnabled"/>
+            public const string DynamicInstrumentationEnabled = "DD_DYNAMIC_INSTRUMENTATION_ENABLED";
 
             /// <summary>
             /// Configuration key for the max object depth to serialize for probe snapshots.

tracer/src/Datadog.Trace/Configuration/ConfigurationKeys.Debugger.cs

@@ -124,12 +124,12 @@ bool IsEnvAndVersionMatch(ProbeDefinition probe)
 
         private void HandleAddedProbesChanges(ProbeConfigurationComparer comparer)
         {
-            LiveDebugger.Instance.UpdateAddedProbeInstrumentations(comparer.AddedDefinitions);
+            DebuggerManager.Instance.DynamicInstrumentation?.UpdateAddedProbeInstrumentations(comparer.AddedDefinitions);
         }
 
         private void HandleRemovedProbesChanges(string[] removedProbesIds)
         {
-            LiveDebugger.Instance.UpdateRemovedProbeInstrumentations(removedProbesIds);
+            DebuggerManager.Instance.DynamicInstrumentation?.UpdateRemovedProbeInstrumentations(removedProbesIds);
         }
 
         private void HandleRateLimitChanged(ProbeConfigurationComparer comparer)

tracer/src/Datadog.Trace/Debugger/Configurations/ConfigurationUpdater.cs

@@ -41,7 +41,7 @@ public override bool Equals(object obj)
                 return true;
             }
 
-            if (obj.GetType() != this.GetType())
+            if (obj.GetType() != GetType())
             {
                 return false;
             }

tracer/src/Datadog.Trace/Debugger/Configurations/Models/FilterList.cs

@@ -50,7 +50,7 @@ public override bool Equals(object? obj)
                 return true;
             }
 
-            if (obj.GetType() != this.GetType())
+            if (obj.GetType() != GetType())
             {
                 return false;
             }

tracer/src/Datadog.Trace/Debugger/Configurations/Models/LogProbe.cs

@@ -42,7 +42,7 @@ public override bool Equals(object obj)
                 return true;
             }
 
-            if (obj.GetType() != this.GetType())
+            if (obj.GetType() != GetType())
             {
                 return false;
             }

tracer/src/Datadog.Trace/Debugger/Configurations/Models/MetricProbe.cs

@@ -56,7 +56,7 @@ public override bool Equals(object obj)
                 return true;
             }
 
-            if (obj.GetType() != this.GetType())
+            if (obj.GetType() != GetType())
             {
                 return false;
             }