Skip to content

Commit 01ca7d0

Browse files
authored
Fix debug symbol upload in release job (#7377)
## Summary of changes Fixes the debug symbol upload in release job ## Reason for change It broke with: ``` cp: cannot stat '/home/runner/work/dd-trace-dotnet/dd-trace-dotnet/tracer/bin/543c80fd22857677ec9a86bc52131eb2907d5899/*.zip': No such file or directory ``` ## Implementation details It turns out, bash globbing doesn't work like I thought it did 😅 I _thought_ that shell expansion worked inside strings as long as they were wrapped in `"` (and not `'`). But while that's true for _variable_ expansion, it's not true for expanding file paths etc. i.e. - ✅ `/some/path/*.zip` - expands globs - ✅ `"/some/path/"*.zip` - expands globs - ❌ `"/some/path/*.zip"` - does not expand globs ## Test coverage Tested it locally to confirm
1 parent e434fb9 commit 01ca7d0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/create_draft_release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ jobs:
138138
dotnet nuget push "*.${{steps.versions.outputs.full_version}}*.nupkg" --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json
139139
140140
- name: "Copy gitlab artifacts to artifacts_path"
141-
run: cp "${{steps.assets.outputs.gitlab_artifacts_path}}/*.zip" "${{steps.assets.outputs.artifacts_path}}/"
141+
run: cp "${{steps.assets.outputs.gitlab_artifacts_path}}/"*.zip "${{steps.assets.outputs.artifacts_path}}/"
142142

143143
- name: 'Push debug symbols to datadog'
144144
uses: ./.github/actions/publish-debug-symbols

0 commit comments

Comments
 (0)