Skip to content

Commit 15e6d28

Browse files
NachoEchevarriaandrewlock
NachoEchevarria
authored and
andrewlock
committed
test removing verify from Datadog.Trace.Tools.Runner.Tests
1 parent c210f93 commit 15e6d28

File tree

2 files changed

+0
-182
lines changed

2 files changed

+0
-182
lines changed

‎tracer/test/Datadog.Trace.Tools.Runner.Tests/CoverageRewriteTests.cs

Lines changed: 0 additions & 181 deletions
Original file line numberDiff line numberDiff line change
@@ -15,184 +15,3 @@
1515
using VerifyTests;
1616
using VerifyXunit;
1717
using Xunit;
18-
19-
namespace Datadog.Trace.Tools.Runner.Tests;
20-
21-
[UsesVerify]
22-
public class CoverageRewriteTests
23-
{
24-
public static IEnumerable<object[]> FiltersData()
25-
{
26-
yield return
27-
[
28-
"CoverageRewriteTests.Rewritten.CoverletFilterByAttribute",
29-
@"<?xml version=""1.0"" encoding=""utf-8""?>
30-
<Configuration>
31-
<!-- Coverlet configuration -->
32-
<ExcludeByAttribute>CompilerGeneratedAttribute</ExcludeByAttribute>
33-
</Configuration>"
34-
];
35-
36-
yield return
37-
[
38-
"CoverageRewriteTests.Rewritten.NetFrameworkSettingsFilterByAttribute",
39-
@"<?xml version=""1.0"" encoding=""utf-8""?>
40-
<Configuration>
41-
<!-- Old .NET Framework configuration -->
42-
<CodeCoverage>
43-
<Attributes>
44-
<Exclude>
45-
<Attribute>^System\.Runtime\.CompilerServices\.CompilerGeneratedAttribute$</Attribute>
46-
</Exclude>
47-
</Attributes>
48-
</CodeCoverage>
49-
</Configuration>"
50-
];
51-
52-
yield return
53-
[
54-
"CoverageRewriteTests.Rewritten.CoverletFilterBySourceFile",
55-
@"<?xml version=""1.0"" encoding=""utf-8""?>
56-
<Configuration>
57-
<!-- Coverlet configuration -->
58-
<ExcludeByFile>**/CoverageRewriterAssembly/Class1.cs</ExcludeByFile>
59-
</Configuration>"
60-
];
61-
62-
yield return
63-
[
64-
"CoverageRewriteTests.Rewritten.NetFrameworkSettingsFilterBySourceFile",
65-
@"<?xml version=""1.0"" encoding=""utf-8""?>
66-
<Configuration>
67-
<!-- Old .NET Framework configuration -->
68-
<CodeCoverage>
69-
<Sources>
70-
<Exclude>
71-
<Source>.*/CoverageRewriterAssembly/Class1.cs$</Source>
72-
</Exclude>
73-
</Sources>
74-
</CodeCoverage>
75-
</Configuration>"
76-
];
77-
78-
yield return
79-
[
80-
"CoverageRewriteTests.Rewritten.CoverletFilterByAssemblyType",
81-
@"<?xml version=""1.0"" encoding=""utf-8""?>
82-
<Configuration>
83-
<!-- Coverlet configuration -->
84-
<Exclude>[*]CoverageRewriterAssembly.Class1</Exclude>
85-
</Configuration>"
86-
];
87-
88-
yield return
89-
[
90-
"CoverageRewriteTests.Rewritten.CoverletFilterByAssemblyAttribute",
91-
@"<?xml version=""1.0"" encoding=""utf-8""?>
92-
<Configuration>
93-
<!-- Coverlet configuration -->
94-
<ExcludeByAttribute>AssemblyFileVersionAttribute</ExcludeByAttribute>
95-
</Configuration>"
96-
];
97-
}
98-
99-
public static IEnumerable<object[]> CoverageModeData()
100-
{
101-
yield return ["LineExecution"];
102-
yield return ["LineCallCount"];
103-
}
104-
105-
public static IEnumerable<object[]> FiltersByCoverageModeData()
106-
{
107-
foreach (var filter in FiltersData())
108-
{
109-
foreach (var coverageMode in CoverageModeData())
110-
{
111-
yield return filter.Concat(coverageMode).ToArray();
112-
}
113-
}
114-
}
115-
116-
#if NETCOREAPP2_1
117-
// Due to a BCL Bug in .NET Core 2.1 [DirectoryInfo.GetDirectories()] triggered by this test, we need to skip the test in some cases
118-
[SkippableTheory(typeof(NullReferenceException), typeof(IndexOutOfRangeException))]
119-
#else
120-
[SkippableTheory]
121-
#endif
122-
[MemberData(nameof(CoverageModeData))]
123-
public async Task NoFilter(string coverageMode)
124-
{
125-
var tempFileName = GetTempFile();
126-
127-
// Verify settings
128-
var settings = new DecompilerSettings();
129-
130-
// Decompile original code
131-
var decompilerOriginalCode = new CSharpDecompiler(tempFileName, settings);
132-
var originalCode = decompilerOriginalCode.DecompileWholeModuleAsString();
133-
134-
var originalVerifySettings = new VerifySettings();
135-
originalVerifySettings.UseDirectory(Path.Combine("..", "snapshots"));
136-
originalVerifySettings.DisableRequireUniquePrefix();
137-
originalVerifySettings.UseFileName("CoverageRewriteTests.Original");
138-
await Verifier.Verify(originalCode, originalVerifySettings);
139-
140-
// Apply rewriter process
141-
var covSettings = new CoverageSettings(null, string.Empty);
142-
covSettings.TestOptimization.SetCodeCoverageMode(coverageMode);
143-
var asmProcessor = new AssemblyProcessor(tempFileName, covSettings);
144-
asmProcessor.Process();
145-
146-
// Decompile rewritten code
147-
var decompilerTransCode = new CSharpDecompiler(tempFileName, settings);
148-
var transCode = decompilerTransCode.DecompileWholeModuleAsString();
149-
150-
var transVerifySettings = new VerifySettings();
151-
transVerifySettings.UseFileName($"CoverageRewriteTests.Rewritten.{coverageMode}");
152-
transVerifySettings.UseDirectory(Path.Combine("..", "snapshots"));
153-
await Verifier.Verify(transCode, transVerifySettings);
154-
}
155-
156-
#if NETCOREAPP2_1
157-
// Due to a BCL Bug in .NET Core 2.1 [DirectoryInfo.GetDirectories()] triggered by this test, we need to skip the test in some cases
158-
[SkippableTheory(typeof(NullReferenceException), typeof(IndexOutOfRangeException))]
159-
#else
160-
[SkippableTheory]
161-
#endif
162-
[MemberData(nameof(FiltersByCoverageModeData))]
163-
public async Task WithFilters(string targetSnapshot, string configurationSettingsXml, string coverageMode)
164-
{
165-
var tempFileName = GetTempFile();
166-
167-
// Verify settings
168-
var settings = new DecompilerSettings();
169-
170-
var configurationElement = new XmlDocument();
171-
configurationElement.LoadXml(configurationSettingsXml);
172-
173-
var covSettings = new CoverageSettings(configurationElement.DocumentElement, string.Empty);
174-
covSettings.TestOptimization.SetCodeCoverageMode(coverageMode);
175-
var asmProcessor = new AssemblyProcessor(tempFileName, covSettings);
176-
asmProcessor.Process();
177-
178-
// Decompile rewritten code
179-
var decompilerTransCode = new CSharpDecompiler(tempFileName, settings);
180-
var transCode = decompilerTransCode.DecompileWholeModuleAsString();
181-
182-
var transVerifySettings = new VerifySettings();
183-
transVerifySettings.UseFileName($"{targetSnapshot}.{coverageMode}");
184-
transVerifySettings.UseDirectory(Path.Combine("..", "snapshots"));
185-
await Verifier.Verify(transCode, transVerifySettings);
186-
}
187-
188-
private string GetTempFile()
189-
{
190-
const string assemblyFileName = "CoverageRewriterAssembly.dll";
191-
192-
// Copy assembly and symbols to a temp folder (we need to rewrite it)
193-
var tempFileName = Path.GetFileNameWithoutExtension(Path.GetTempFileName()) + ".dll";
194-
File.Copy(assemblyFileName, tempFileName, true);
195-
File.Copy(Path.GetFileNameWithoutExtension(assemblyFileName) + ".pdb", Path.GetFileNameWithoutExtension(tempFileName) + ".pdb", true);
196-
return tempFileName;
197-
}
198-
}

‎tracer/test/Datadog.Trace.Tools.Runner.Tests/Datadog.Trace.Tools.Runner.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
</ItemGroup>
3232

3333
<ItemGroup>
34-
<PackageReference Include="Verify.Xunit" Version="14.13.1" />
3534
<PackageReference Include="DiffPlex" Version="1.7.2" />
3635
</ItemGroup>
3736

0 commit comments

Comments
 (0)