Skip to content

Commit 31b6987

Browse files
Pre pull aerospike image (#7333)
## Summary of changes When running aerospike tests, we pull the docker image during the test execution. This can lead to some failures due to rate limits. This PR pulls the image directly from the CI along with all the needed ones. ## Reason for change ## Implementation details ## Test coverage ## Other details <!-- Fixes #{issue} --> <!-- ⚠️ Note: Where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. MergeQueue is NOT enabled in this repository. If you have write access to the repo, the PR has 1-2 approvals (see above), and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #apm-dotnet channel in Slack. --> --------- Co-authored-by: Andrew Lock <[email protected]>
1 parent 213c3ef commit 31b6987

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

docker-compose.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1184,3 +1184,7 @@ services:
11841184
environment:
11851185
- ACCEPT_EULA=Y
11861186
- SA_PASSWORD=Strong!Passw0rd
1187+
1188+
# keep syncronized image version with tracer\test\Datadog.Trace.TestHelpers.AutoInstrumentation\Containers\AerospikeFixture.cs
1189+
aerospike:
1190+
image: aerospike/aerospike-server:6.2.0.6

tracer/test/Datadog.Trace.TestHelpers.AutoInstrumentation/Containers/AerospikeFixture.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ protected override async Task InitializeResources(Action<string, object> registe
2828
{
2929
// pinning to a known good version because the latest version
3030
// (6.3.0.5 at time of issue) causes 'Server memory error' and flake
31+
// Keep syncronized image version with docker-compose.yml
3132
var container = new ContainerBuilder()
3233
.WithImage("aerospike/aerospike-server:6.2.0.6")
3334
.WithPortBinding(AerospikePort, true)

0 commit comments

Comments
 (0)