Update xunit to latest, fix analyzer warnings, and update analyzer tests (#7280)

## Summary of changes

- Update `xunit` to latest v2 package version (`v2.9.3`)
- Update Analyzer testing libraries to the new test-framework agnostic
versions
- Fix all the errors xunit now flags

## Reason for change

As part of the .NET 10 work we tried updating to the latest xunit. It's
not _entirely_ clear if that work was actually necessary (there appeared
to be a bug in preview 5 that didn't impact preview 6) but rather than
waste the effort, pulling this out into a separate PR.

## Implementation details

Mostly just bumping package versions. For the analyzer library changes,
I followed [this
guide](https://github.com/dotnet/roslyn-sdk/blob/main/src/Microsoft.CodeAnalysis.Testing/README.md)
to update. For xunit I bumped required packages, and then fixed a bunch
of errors the xunit.analyzers started flagging:

- `Assert.Empty` -> use FluentAssertions
- "Incorrect type" -> Use `int` instead of `HttpStatusCode`,
`NullableBooleanTestCases` instead of `BooleanTestCases` (for example)
- "Don't use `ConfigureAwait(false)`" -> Remove it (xunit has a sync
context)
- "xUnit1031 - Test methods should not use Blocking operations" - I
_mostly_ ignored this one, because the tests are in testing for
low-level stuff (call target machinery) and didn't want to change the
behavior

## Test coverage

This is the test. Need to double check the tests are definitely
_actually_ running though...

## Other details

Related to
- #7170 
- #7281
- https://datadoghq.atlassian.net/browse/LANGPLAT-632

Author: andrewlock

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AWS/AwsEventBridgeTests.cs

@@ -108,7 +108,7 @@ public async Task IntegrationDisabled()
                 var spans = await agent.WaitForSpansAsync(1, returnAllOperations: true);
 
                 Assert.NotEmpty(spans);
-                Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+                spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
                 await telemetry.AssertIntegrationDisabledAsync(IntegrationId.AwsEventBridge);
             }
         }

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AWS/AwsS3Tests.cs

@@ -103,7 +103,7 @@ public async Task IntegrationDisabled()
                 var spans = await agent.WaitForSpansAsync(1, returnAllOperations: true);
 
                 Assert.NotEmpty(spans);
-                Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+                spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
                 await telemetry.AssertIntegrationDisabledAsync(IntegrationId.AwsS3);
             }
         }

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AWS/AwsStepFunctionsTests.cs

@@ -115,7 +115,7 @@ public async Task IntegrationDisabled()
                 var spans = await agent.WaitForSpansAsync(1, returnAllOperations: true);
 
                 Assert.NotEmpty(spans);
-                Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+                spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
                 await telemetry.AssertIntegrationDisabledAsync(IntegrationId.AwsStepFunctions);
             }
         }

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AdoNet/MicrosoftDataSqlClientTests.cs

@@ -10,6 +10,7 @@
 using Datadog.Trace.ClrProfiler.IntegrationTests.Helpers;
 using Datadog.Trace.Configuration;
 using Datadog.Trace.TestHelpers;
+using FluentAssertions;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -101,7 +102,7 @@ public async Task IntegrationDisabled()
             var spans = await agent.WaitForSpansAsync(totalSpanCount, returnAllOperations: true);
 
             Assert.NotEmpty(spans);
-            Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+            spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
             await telemetry.AssertIntegrationDisabledAsync(IntegrationId.SqlClient);
         }
     }

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AdoNet/MicrosoftDataSqliteTests.cs

@@ -13,6 +13,7 @@
 using Datadog.Trace.ClrProfiler.IntegrationTests.Helpers;
 using Datadog.Trace.Configuration;
 using Datadog.Trace.TestHelpers;
+using FluentAssertions;
 using VerifyXunit;
 using Xunit;
 using Xunit.Abstractions;
@@ -101,7 +102,7 @@ public async Task IntegrationDisabled()
             var spans = await agent.WaitForSpansAsync(totalSpanCount, returnAllOperations: true);
 
             Assert.NotEmpty(spans);
-            Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+            spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
             await telemetry.AssertIntegrationDisabledAsync(IntegrationId.Sqlite);
         }
     }

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AdoNet/MySqlCommandTests.cs

@@ -76,7 +76,7 @@ public async Task IntegrationDisabled()
             var spans = await agent.WaitForSpansAsync(totalSpanCount, returnAllOperations: true);
 
             Assert.NotEmpty(spans);
-            Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+            spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
             await telemetry.AssertIntegrationDisabledAsync(IntegrationId.MySql);
         }
 

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AdoNet/MySqlConnectorTests.cs

@@ -10,6 +10,7 @@
 using Datadog.Trace.ClrProfiler.IntegrationTests.Helpers;
 using Datadog.Trace.Configuration;
 using Datadog.Trace.TestHelpers;
+using FluentAssertions;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -85,7 +86,7 @@ public async Task IntegrationDisabled()
             var spans = await agent.WaitForSpansAsync(totalSpanCount, returnAllOperations: true);
 
             Assert.NotEmpty(spans);
-            Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+            spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
             await telemetry.AssertIntegrationDisabledAsync(IntegrationId.MySql);
         }
 

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AdoNet/NpgsqlCommandTests.cs

@@ -110,7 +110,7 @@ public async Task IntegrationDisabled()
             var spans = await agent.WaitForSpansAsync(totalSpanCount, returnAllOperations: true);
 
             Assert.NotEmpty(spans);
-            Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+            spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
             await telemetry.AssertIntegrationDisabledAsync(IntegrationId.Npgsql);
         }
     }

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AdoNet/SqlCommand20Tests.cs

@@ -8,6 +8,7 @@
 using System.Threading.Tasks;
 using Datadog.Trace.Configuration;
 using Datadog.Trace.TestHelpers;
+using FluentAssertions;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -50,7 +51,7 @@ public async Task IntegrationDisabled()
             var spans = await agent.WaitForSpansAsync(totalSpanCount, returnAllOperations: true);
 
             Assert.NotEmpty(spans);
-            Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+            spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
             await telemetry.AssertIntegrationDisabledAsync(IntegrationId.SqlClient);
         }
 

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AdoNet/SystemDataSqlClientTests.cs

@@ -135,7 +135,7 @@ public async Task IntegrationDisabled()
             var spans = await agent.WaitForSpansAsync(totalSpanCount, returnAllOperations: true);
 
             Assert.NotEmpty(spans);
-            Assert.Empty(spans.Where(s => s.Name.Equals(expectedOperationName)));
+            spans.Where(s => s.Name.Equals(expectedOperationName)).Should().BeEmpty();
             await telemetry.AssertIntegrationDisabledAsync(IntegrationId.SqlClient);
         }
     }