Skip to content

Commit 57ec51a

Browse files
committed
Answer to Andrew's comments
1 parent fc5cc22 commit 57ec51a

File tree

8 files changed

+1410
-1366
lines changed

8 files changed

+1410
-1366
lines changed

tracer/src/Datadog.Trace.SourceGenerators/EnumExtensions/Sources.cs

Lines changed: 209 additions & 171 deletions
Large diffs are not rendered by default.

tracer/src/Datadog.Trace/Configuration/ConfigurationSources/Telemetry/ConfigurationBuilder.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ public HasKeys WithIntegrationKey(string integrationName)
2626
return new(
2727
_source,
2828
_telemetry,
29-
integrationEnabledKeys[0],
30-
integrationEnabledKeys.Skip(1).ToArray());
29+
integrationEnabledKeys.Key,
30+
integrationEnabledKeys.Value);
3131
}
3232

3333
public HasKeys WithIntegrationAnalyticsKey(string integrationName)
@@ -38,8 +38,8 @@ public HasKeys WithIntegrationAnalyticsKey(string integrationName)
3838
return new(
3939
_source,
4040
_telemetry,
41-
integrationAnalyticsEnabledKeys[0],
42-
integrationAnalyticsEnabledKeys.Skip(1).ToArray());
41+
integrationAnalyticsEnabledKeys.Key,
42+
integrationAnalyticsEnabledKeys.Value);
4343
}
4444

4545
public HasKeys WithIntegrationAnalyticsSampleRateKey(string integrationName)
@@ -50,8 +50,8 @@ public HasKeys WithIntegrationAnalyticsSampleRateKey(string integrationName)
5050
return new(
5151
_source,
5252
_telemetry,
53-
integrationAnalyticsSampleRateKeys[0],
54-
integrationAnalyticsSampleRateKeys.Skip(1).ToArray());
53+
integrationAnalyticsSampleRateKeys.Key,
54+
integrationAnalyticsSampleRateKeys.Value);
5555
}
5656

5757
internal readonly struct HasKeys(IConfigurationSource source, IConfigurationTelemetry telemetry, string key, string[]? providedAliases = null)

tracer/src/Datadog.Trace/Generated/net461/Datadog.Trace.SourceGenerators/EnumExtensionsGenerator/IntegrationNameToKeys.g.cs

Lines changed: 274 additions & 273 deletions
Large diffs are not rendered by default.

tracer/src/Datadog.Trace/Generated/net6.0/Datadog.Trace.SourceGenerators/EnumExtensionsGenerator/IntegrationNameToKeys.g.cs

Lines changed: 274 additions & 273 deletions
Large diffs are not rendered by default.

tracer/src/Datadog.Trace/Generated/netcoreapp3.1/Datadog.Trace.SourceGenerators/EnumExtensionsGenerator/IntegrationNameToKeys.g.cs

Lines changed: 274 additions & 273 deletions
Large diffs are not rendered by default.

tracer/src/Datadog.Trace/Generated/netstandard2.0/Datadog.Trace.SourceGenerators/EnumExtensionsGenerator/IntegrationNameToKeys.g.cs

Lines changed: 274 additions & 273 deletions
Large diffs are not rendered by default.

tracer/test/Datadog.Trace.SourceGenerators.Tests/EnumExtensionsGeneratorTests.cs

Lines changed: 98 additions & 96 deletions
Large diffs are not rendered by default.

tracer/test/Datadog.Trace.Tests/Telemetry/ConfigurationTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public class ConfigurationTests
6262
// deprecated alias
6363
"DATADOG_TRACE_AGENT_HOSTNAME_OPTIMIZED"
6464
}
65-
.Concat(IntegrationNameToKeys.AllIntegrationEnabledKeys)
65+
.Concat(IntegrationNameToKeys.GetAllIntegrationEnabledKeys())
6666
.ToArray();
6767

6868
[Fact]

0 commit comments

Comments
 (0)