Check ping file

Author: gleocadie

tracer/test/Datadog.Trace.Tools.dd_dotnet.ArtifactTests/CreatedumpTests.cs

@@ -375,6 +375,8 @@ public async Task NativeCrash()
             helper.StandardOutput.Should().Contain(CrashReportExpectedOutput);
         }
 
+        var pingFile = reportFile.GetPingFile();
+        File.Exists(pingFile.Path).Should().BeTrue();
         File.Exists(reportFile.Path).Should().BeTrue();
     }
 
@@ -426,6 +428,8 @@ public async Task CheckThreadName()
             helper.StandardOutput.Should().Contain(CrashReportExpectedOutput);
         }
 
+        var pingFile = reportFile.GetPingFile();
+        File.Exists(pingFile.Path).Should().BeTrue();
         File.Exists(reportFile.Path).Should().BeTrue();
     }
 
@@ -503,7 +507,9 @@ public async Task OptionallyDoNotReportNonDatadogCrashes(bool mainThread)
               .And.EndWith("Crashing...\n"); // Making sure there is no additional output
         }
 
-        // TODO check for ping file
+        var pingFile = reportFile.GetPingFile();
+        // Ping should always be present, even if the crash is not reported
+        File.Exists(pingFile.Path).Should().BeTrue();
         File.Exists(reportFile.Path).Should().BeFalse();
     }
 
@@ -527,6 +533,8 @@ public async Task ReportNonDatadogCrashes()
             helper.StandardOutput.Should().Contain(CrashReportUnfilteredExpectedOutput);
         }
 
+        var pingFile = reportFile.GetPingFile();
+        File.Exists(pingFile.Path).Should().BeTrue();
         File.Exists(reportFile.Path).Should().BeTrue();
     }
 
@@ -550,6 +558,8 @@ public async Task MakeSureNonDatadogCrashesAreReportedByDefault()
             helper.StandardOutput.Should().Contain(CrashReportUnfilteredExpectedOutput);
         }
 
+        var pingFile = reportFile.GetPingFile();
+        File.Exists(pingFile.Path).Should().BeTrue();
         File.Exists(reportFile.Path).Should().BeTrue();
     }
 
@@ -568,10 +578,11 @@ public async Task ReportedStacktrace()
 
         await helper.Task;
 
+        using var pingFile = reportFile.GetPingFile();
+        File.Exists(pingFile.Path).Should().BeTrue();
         File.Exists(reportFile.Path).Should().BeTrue();
 
         var reader = new StringReader(helper.StandardOutput);
-
         int? mainThreadId = null;
         var expectedCallstack = new List<string>();
 
@@ -596,12 +607,22 @@ public async Task ReportedStacktrace()
         mainThreadId.Should().NotBeNull();
         expectedCallstack.Should().HaveCountGreaterOrEqualTo(2);
 
-        var report = JObject.Parse(reportFile.GetContent());
+        {
+            var report = JObject.Parse(reportFile.GetContent());
+            using var assertionScope = new AssertionScope();
+            assertionScope.AddReportable("Report", report.ToString());
+
+            ValidateStacktrace(report["error"]["stack"]);
+        }
 
         using var assertionScope = new AssertionScope();
-        assertionScope.AddReportable("Report", report.ToString());
+        assertionScope.AddReportable("Ping", pingFile.GetContent());
+        var pingFileContent = pingFile.GetContent();
+        var ping = JObject.Parse(pingFileContent);
+        ping["type"].Value<string>().Should().Be("Crash ping");
+        ping["crash_uuid"].Value<string>().Should().NotBeNull();
 
-        ValidateStacktrace(report["error"]["stack"]);
+        pingFileContent.Should().BeEmpty();
 
         void ValidateStacktrace(JToken callstack)
         {
@@ -756,5 +777,24 @@ public void Dispose()
         {
             File.Delete(Path);
         }
+
+        public TemporaryFile GetPingFile()
+        {
+            var filename = System.IO.Path.GetFileNameWithoutExtension(Path);
+            var directory = System.IO.Path.GetDirectoryName(Path);
+            var pingFile = $"{filename}-ping.json";
+
+            if (directory == null)
+            {
+                return new TemporaryFile(pingFile);
+            }
+
+            return new TemporaryFile(Path.Combine(directory, pingFile));
+        }
+
+        private TemporaryFile(string filePath)
+        {
+            Path = filePath;
+        }
     }
 }