Skip to content

Commit a15b163

Browse files
committed
Don't create the OpenTelemetryTags until we know we are going to use them (e.g. the activity is not ignored
1 parent d790383 commit a15b163

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tracer/src/Datadog.Trace/Activity/Handlers/ActivityHandlerCommon.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ static Scope CreateScopeFromActivity(T activity, OpenTelemetryTags? tags, SpanCo
216216
{
217217
var span = Tracer.Instance.StartSpan(
218218
activity.OperationName,
219-
tags: tags,
219+
tags: tags ?? new OpenTelemetryTags(),
220220
parent: parent,
221221
startTime: activity.StartTimeUtc,
222222
traceId: traceId,

tracer/src/Datadog.Trace/Activity/Handlers/DefaultActivityHandler.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public bool ShouldListenTo(string sourceName, string? version)
2222

2323
public void ActivityStarted<T>(string sourceName, T activity)
2424
where T : IActivity
25-
=> ActivityHandlerCommon.ActivityStarted(sourceName, activity, tags: new OpenTelemetryTags(), out _);
25+
=> ActivityHandlerCommon.ActivityStarted(sourceName, activity, tags: null, out _);
2626

2727
public void ActivityStopped<T>(string sourceName, T activity)
2828
where T : IActivity

0 commit comments

Comments
 (0)