Skip to content

Commit b33d47b

Browse files
committed
Try something
1 parent 7b6b423 commit b33d47b

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

tracer/src/Datadog.Trace.Tools.dd_dotnet/CreatedumpCommand.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -602,14 +602,7 @@ private unsafe void GenerateCrashReport(int pid, int? signal, int? crashThread)
602602
}
603603
}
604604

605-
// Set signal information early to include it in the ping
606-
if (signal.HasValue)
607-
{
608-
DebugPrint("Adding signal information to the crash report");
609-
_ = SetSignal(crashReport, signal.Value);
610-
}
611-
612-
_ = SendPing(crashReport, _runtime);
605+
// _ = SendPing(crashReport, _runtime);
613606

614607
if (crashThread == null)
615608
{
@@ -716,6 +709,13 @@ private unsafe void GenerateCrashReport(int pid, int? signal, int? crashThread)
716709
AnsiConsole.WriteLine("Datadog - The crash may have been caused by automatic instrumentation, sending crash report...");
717710
}
718711

712+
// Set signal information early to include it in the ping
713+
if (signal.HasValue)
714+
{
715+
DebugPrint("Adding signal information to the crash report");
716+
_ = SetSignal(crashReport, signal.Value);
717+
}
718+
719719
DebugPrint("Setting crash report metadata");
720720
_ = SetMetadata(crashReport, _runtime, exception, isSuspicious);
721721

tracer/test/Datadog.Trace.Tools.dd_dotnet.ArtifactTests/CreatedumpTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,7 @@ public async Task OptionallyDoNotReportNonDatadogCrashes(bool mainThread)
503503
.And.EndWith("Crashing...\n"); // Making sure there is no additional output
504504
}
505505

506+
// TODO check for ping file
506507
File.Exists(reportFile.Path).Should().BeFalse();
507508
}
508509

0 commit comments

Comments
 (0)