Skip to content

Commit e0b68bc

Browse files
tonyredondotonyredondo
authored
[Test Optimization] Fix base branch SHA usage (#7300)
## Summary of changes This PR fixes the use of the base branch sha value, we thought this sha was the BASE sha, but we realized it is the HEAD sha of the base branch. ## Reason for change Jira: https://datadoghq.atlassian.net/browse/SDTEST-2352 ## Implementation details Small updates on the tag names ## Test coverage Update the tests json files and small modification on the github test. ## Other details <!-- Fixes #{issue} --> <!-- ⚠️ Note: where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. -->
1 parent fa6192b commit e0b68bc

File tree

16 files changed

+234
-3
lines changed

16 files changed

+234
-3
lines changed

‎tracer/src/Datadog.Trace/Ci/CiEnvironment/CIEnvironmentValues.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ public string? GitSearchFolder
9191

9292
public string? PrBaseCommit { get; protected set; }
9393

94+
public string? PrBaseHeadCommit { get; protected set; }
95+
9496
public string? PrBaseBranch { get; protected set; }
9597

9698
public string? PrNumber { get; protected set; }
@@ -283,6 +285,7 @@ public void DecorateSpan(Span span)
283285
SetTagIfNotNullOrEmpty(span, CommonTags.CINodeLabels, Datadog.Trace.Vendors.Newtonsoft.Json.JsonConvert.SerializeObject(nodeLabels));
284286
}
285287

288+
SetTagIfNotNullOrEmpty(span, CommonTags.GitPrBaseHeadCommit, PrBaseHeadCommit);
286289
SetTagIfNotNullOrEmpty(span, CommonTags.GitPrBaseCommit, PrBaseCommit);
287290
SetTagIfNotNullOrEmpty(span, CommonTags.GitPrBaseBranch, PrBaseBranch);
288291
SetTagIfNotNullOrEmpty(span, CommonTags.PrNumber, PrNumber);
@@ -529,6 +532,7 @@ internal sealed class Constants
529532
public const string GitlabRunnerTags = "CI_RUNNER_TAGS";
530533
public const string GitlabMergeRequestSourceBranchSha = "CI_MERGE_REQUEST_SOURCE_BRANCH_SHA";
531534
public const string GitlabMergeRequestTargetBranchSha = "CI_MERGE_REQUEST_TARGET_BRANCH_SHA";
535+
public const string GitlabMergeRequestDiffBaseSha = "CI_MERGE_REQUEST_DIFF_BASE_SHA";
532536
public const string GitlabMergeRequestTargetBranchName = "CI_MERGE_REQUEST_TARGET_BRANCH_NAME";
533537
public const string GitlabMergeRequestId = "CI_MERGE_REQUEST_IID";
534538

‎tracer/src/Datadog.Trace/Ci/CiEnvironment/GithubActionsEnvironmentValues.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ private void LoadGithubEventJson()
121121
var prBaseSha = pullRequestObject["base"]?["sha"]?.Value<string>();
122122
if (!string.IsNullOrWhiteSpace(prBaseSha))
123123
{
124-
PrBaseCommit = prBaseSha;
124+
PrBaseHeadCommit = prBaseSha;
125125
}
126126

127127
var prBaseRef = pullRequestObject["base"]?["ref"]?.Value<string>();

‎tracer/src/Datadog.Trace/Ci/CiEnvironment/GitlabEnvironmentValues.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ protected override void OnInitialize(IGitInfo gitInfo)
7777
Constants.GitlabJobId);
7878

7979
HeadCommit = ValueProvider.GetValue(Constants.GitlabMergeRequestSourceBranchSha);
80-
PrBaseCommit = ValueProvider.GetValue(Constants.GitlabMergeRequestTargetBranchSha);
80+
PrBaseHeadCommit = ValueProvider.GetValue(Constants.GitlabMergeRequestTargetBranchSha);
81+
PrBaseCommit = ValueProvider.GetValue(Constants.GitlabMergeRequestDiffBaseSha);
8182
PrBaseBranch = ValueProvider.GetValue(Constants.GitlabMergeRequestTargetBranchName);
8283
PrNumber = ValueProvider.GetValue(Constants.GitlabMergeRequestId);
8384
}

‎tracer/src/Datadog.Trace/Ci/Tagging/TestSessionSpanTags.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,9 @@ public TestSessionSpanTags()
123123
[Metric(CommonTags.LogicalCpuCount)]
124124
public double? LogicalCpuCount { get; }
125125

126+
[Tag(CommonTags.GitPrBaseHeadCommit)]
127+
public string? GitPrBaseHeadCommit { get; set; }
128+
126129
[Tag(CommonTags.GitPrBaseCommit)]
127130
public string? GitPrBaseCommit { get; set; }
128131

@@ -182,6 +185,7 @@ public void SetCIEnvironmentValues(CIEnvironmentValues environmentValues)
182185
GitCommitCommitterEmail = environmentValues.CommitterEmail;
183186
GitCommitMessage = environmentValues.Message;
184187
BuildSourceRoot = environmentValues.SourceRoot;
188+
GitPrBaseHeadCommit = environmentValues.PrBaseHeadCommit;
185189
GitPrBaseCommit = environmentValues.PrBaseCommit;
186190
GitPrBaseBranch = environmentValues.PrBaseBranch;
187191
PrNumber = environmentValues.PrNumber;

‎tracer/src/Datadog.Trace/Ci/Tags/CommonTags.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,11 @@ internal static class CommonTags
206206
/// </summary>
207207
public const string GitPrBaseCommit = "git.pull_request.base_branch_sha";
208208

209+
/// <summary>
210+
/// GIT PR Base head commit hash
211+
/// </summary>
212+
public const string GitPrBaseHeadCommit = "git.pull_request.base_branch_head_sha";
213+
209214
/// <summary>
210215
/// GIT PR Base branch name
211216
/// </summary>

‎tracer/src/Datadog.Trace/Generated/net461/Datadog.Trace.SourceGenerators/TagListGenerator/TestSessionSpanTags.g.cs

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ partial class TestSessionSpanTags
8080
private static ReadOnlySpan<byte> EarlyFlakeDetectionTestEnabledBytes => new byte[] { 184, 116, 101, 115, 116, 46, 101, 97, 114, 108, 121, 95, 102, 108, 97, 107, 101, 46, 101, 110, 97, 98, 108, 101, 100 };
8181
// EarlyFlakeDetectionTestAbortReasonBytes = MessagePack.Serialize("test.early_flake.abort_reason");
8282
private static ReadOnlySpan<byte> EarlyFlakeDetectionTestAbortReasonBytes => new byte[] { 189, 116, 101, 115, 116, 46, 101, 97, 114, 108, 121, 95, 102, 108, 97, 107, 101, 46, 97, 98, 111, 114, 116, 95, 114, 101, 97, 115, 111, 110 };
83+
// GitPrBaseHeadCommitBytes = MessagePack.Serialize("git.pull_request.base_branch_head_sha");
84+
private static ReadOnlySpan<byte> GitPrBaseHeadCommitBytes => new byte[] { 217, 37, 103, 105, 116, 46, 112, 117, 108, 108, 95, 114, 101, 113, 117, 101, 115, 116, 46, 98, 97, 115, 101, 95, 98, 114, 97, 110, 99, 104, 95, 104, 101, 97, 100, 95, 115, 104, 97 };
8385
// GitPrBaseCommitBytes = MessagePack.Serialize("git.pull_request.base_branch_sha");
8486
private static ReadOnlySpan<byte> GitPrBaseCommitBytes => new byte[] { 217, 32, 103, 105, 116, 46, 112, 117, 108, 108, 95, 114, 101, 113, 117, 101, 115, 116, 46, 98, 97, 115, 101, 95, 98, 114, 97, 110, 99, 104, 95, 115, 104, 97 };
8587
// GitPrBaseBranchBytes = MessagePack.Serialize("git.pull_request.base_branch");
@@ -139,6 +141,7 @@ partial class TestSessionSpanTags
139141
"test.itr.tests_skipping.type" => IntelligentTestRunnerSkippingType,
140142
"test.early_flake.enabled" => EarlyFlakeDetectionTestEnabled,
141143
"test.early_flake.abort_reason" => EarlyFlakeDetectionTestAbortReason,
144+
"git.pull_request.base_branch_head_sha" => GitPrBaseHeadCommit,
142145
"git.pull_request.base_branch_sha" => GitPrBaseCommit,
143146
"git.pull_request.base_branch" => GitPrBaseBranch,
144147
"pr.number" => PrNumber,
@@ -251,6 +254,9 @@ public override void SetTag(string key, string value)
251254
case "test.early_flake.abort_reason":
252255
EarlyFlakeDetectionTestAbortReason = value;
253256
break;
257+
case "git.pull_request.base_branch_head_sha":
258+
GitPrBaseHeadCommit = value;
259+
break;
254260
case "git.pull_request.base_branch_sha":
255261
GitPrBaseCommit = value;
256262
break;
@@ -455,6 +461,11 @@ public override void EnumerateTags<TProcessor>(ref TProcessor processor)
455461
processor.Process(new TagItem<string>("test.early_flake.abort_reason", EarlyFlakeDetectionTestAbortReason, EarlyFlakeDetectionTestAbortReasonBytes));
456462
}
457463

464+
if (GitPrBaseHeadCommit is not null)
465+
{
466+
processor.Process(new TagItem<string>("git.pull_request.base_branch_head_sha", GitPrBaseHeadCommit, GitPrBaseHeadCommitBytes));
467+
}
468+
458469
if (GitPrBaseCommit is not null)
459470
{
460471
processor.Process(new TagItem<string>("git.pull_request.base_branch_sha", GitPrBaseCommit, GitPrBaseCommitBytes));
@@ -739,6 +750,13 @@ protected override void WriteAdditionalTags(System.Text.StringBuilder sb)
739750
.Append(',');
740751
}
741752

753+
if (GitPrBaseHeadCommit is not null)
754+
{
755+
sb.Append("git.pull_request.base_branch_head_sha (tag):")
756+
.Append(GitPrBaseHeadCommit)
757+
.Append(',');
758+
}
759+
742760
if (GitPrBaseCommit is not null)
743761
{
744762
sb.Append("git.pull_request.base_branch_sha (tag):")

‎tracer/src/Datadog.Trace/Generated/net6.0/Datadog.Trace.SourceGenerators/TagListGenerator/TestSessionSpanTags.g.cs

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ partial class TestSessionSpanTags
8080
private static ReadOnlySpan<byte> EarlyFlakeDetectionTestEnabledBytes => new byte[] { 184, 116, 101, 115, 116, 46, 101, 97, 114, 108, 121, 95, 102, 108, 97, 107, 101, 46, 101, 110, 97, 98, 108, 101, 100 };
8181
// EarlyFlakeDetectionTestAbortReasonBytes = MessagePack.Serialize("test.early_flake.abort_reason");
8282
private static ReadOnlySpan<byte> EarlyFlakeDetectionTestAbortReasonBytes => new byte[] { 189, 116, 101, 115, 116, 46, 101, 97, 114, 108, 121, 95, 102, 108, 97, 107, 101, 46, 97, 98, 111, 114, 116, 95, 114, 101, 97, 115, 111, 110 };
83+
// GitPrBaseHeadCommitBytes = MessagePack.Serialize("git.pull_request.base_branch_head_sha");
84+
private static ReadOnlySpan<byte> GitPrBaseHeadCommitBytes => new byte[] { 217, 37, 103, 105, 116, 46, 112, 117, 108, 108, 95, 114, 101, 113, 117, 101, 115, 116, 46, 98, 97, 115, 101, 95, 98, 114, 97, 110, 99, 104, 95, 104, 101, 97, 100, 95, 115, 104, 97 };
8385
// GitPrBaseCommitBytes = MessagePack.Serialize("git.pull_request.base_branch_sha");
8486
private static ReadOnlySpan<byte> GitPrBaseCommitBytes => new byte[] { 217, 32, 103, 105, 116, 46, 112, 117, 108, 108, 95, 114, 101, 113, 117, 101, 115, 116, 46, 98, 97, 115, 101, 95, 98, 114, 97, 110, 99, 104, 95, 115, 104, 97 };
8587
// GitPrBaseBranchBytes = MessagePack.Serialize("git.pull_request.base_branch");
@@ -139,6 +141,7 @@ partial class TestSessionSpanTags
139141
"test.itr.tests_skipping.type" => IntelligentTestRunnerSkippingType,
140142
"test.early_flake.enabled" => EarlyFlakeDetectionTestEnabled,
141143
"test.early_flake.abort_reason" => EarlyFlakeDetectionTestAbortReason,
144+
"git.pull_request.base_branch_head_sha" => GitPrBaseHeadCommit,
142145
"git.pull_request.base_branch_sha" => GitPrBaseCommit,
143146
"git.pull_request.base_branch" => GitPrBaseBranch,
144147
"pr.number" => PrNumber,
@@ -251,6 +254,9 @@ public override void SetTag(string key, string value)
251254
case "test.early_flake.abort_reason":
252255
EarlyFlakeDetectionTestAbortReason = value;
253256
break;
257+
case "git.pull_request.base_branch_head_sha":
258+
GitPrBaseHeadCommit = value;
259+
break;
254260
case "git.pull_request.base_branch_sha":
255261
GitPrBaseCommit = value;
256262
break;
@@ -455,6 +461,11 @@ public override void EnumerateTags<TProcessor>(ref TProcessor processor)
455461
processor.Process(new TagItem<string>("test.early_flake.abort_reason", EarlyFlakeDetectionTestAbortReason, EarlyFlakeDetectionTestAbortReasonBytes));
456462
}
457463

464+
if (GitPrBaseHeadCommit is not null)
465+
{
466+
processor.Process(new TagItem<string>("git.pull_request.base_branch_head_sha", GitPrBaseHeadCommit, GitPrBaseHeadCommitBytes));
467+
}
468+
458469
if (GitPrBaseCommit is not null)
459470
{
460471
processor.Process(new TagItem<string>("git.pull_request.base_branch_sha", GitPrBaseCommit, GitPrBaseCommitBytes));
@@ -739,6 +750,13 @@ protected override void WriteAdditionalTags(System.Text.StringBuilder sb)
739750
.Append(',');
740751
}
741752

753+
if (GitPrBaseHeadCommit is not null)
754+
{
755+
sb.Append("git.pull_request.base_branch_head_sha (tag):")
756+
.Append(GitPrBaseHeadCommit)
757+
.Append(',');
758+
}
759+
742760
if (GitPrBaseCommit is not null)
743761
{
744762
sb.Append("git.pull_request.base_branch_sha (tag):")

‎tracer/src/Datadog.Trace/Generated/netcoreapp3.1/Datadog.Trace.SourceGenerators/TagListGenerator/TestSessionSpanTags.g.cs

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ partial class TestSessionSpanTags
8080
private static ReadOnlySpan<byte> EarlyFlakeDetectionTestEnabledBytes => new byte[] { 184, 116, 101, 115, 116, 46, 101, 97, 114, 108, 121, 95, 102, 108, 97, 107, 101, 46, 101, 110, 97, 98, 108, 101, 100 };
8181
// EarlyFlakeDetectionTestAbortReasonBytes = MessagePack.Serialize("test.early_flake.abort_reason");
8282
private static ReadOnlySpan<byte> EarlyFlakeDetectionTestAbortReasonBytes => new byte[] { 189, 116, 101, 115, 116, 46, 101, 97, 114, 108, 121, 95, 102, 108, 97, 107, 101, 46, 97, 98, 111, 114, 116, 95, 114, 101, 97, 115, 111, 110 };
83+
// GitPrBaseHeadCommitBytes = MessagePack.Serialize("git.pull_request.base_branch_head_sha");
84+
private static ReadOnlySpan<byte> GitPrBaseHeadCommitBytes => new byte[] { 217, 37, 103, 105, 116, 46, 112, 117, 108, 108, 95, 114, 101, 113, 117, 101, 115, 116, 46, 98, 97, 115, 101, 95, 98, 114, 97, 110, 99, 104, 95, 104, 101, 97, 100, 95, 115, 104, 97 };
8385
// GitPrBaseCommitBytes = MessagePack.Serialize("git.pull_request.base_branch_sha");
8486
private static ReadOnlySpan<byte> GitPrBaseCommitBytes => new byte[] { 217, 32, 103, 105, 116, 46, 112, 117, 108, 108, 95, 114, 101, 113, 117, 101, 115, 116, 46, 98, 97, 115, 101, 95, 98, 114, 97, 110, 99, 104, 95, 115, 104, 97 };
8587
// GitPrBaseBranchBytes = MessagePack.Serialize("git.pull_request.base_branch");
@@ -139,6 +141,7 @@ partial class TestSessionSpanTags
139141
"test.itr.tests_skipping.type" => IntelligentTestRunnerSkippingType,
140142
"test.early_flake.enabled" => EarlyFlakeDetectionTestEnabled,
141143
"test.early_flake.abort_reason" => EarlyFlakeDetectionTestAbortReason,
144+
"git.pull_request.base_branch_head_sha" => GitPrBaseHeadCommit,
142145
"git.pull_request.base_branch_sha" => GitPrBaseCommit,
143146
"git.pull_request.base_branch" => GitPrBaseBranch,
144147
"pr.number" => PrNumber,
@@ -251,6 +254,9 @@ public override void SetTag(string key, string value)
251254
case "test.early_flake.abort_reason":
252255
EarlyFlakeDetectionTestAbortReason = value;
253256
break;
257+
case "git.pull_request.base_branch_head_sha":
258+
GitPrBaseHeadCommit = value;
259+
break;
254260
case "git.pull_request.base_branch_sha":
255261
GitPrBaseCommit = value;
256262
break;
@@ -455,6 +461,11 @@ public override void EnumerateTags<TProcessor>(ref TProcessor processor)
455461
processor.Process(new TagItem<string>("test.early_flake.abort_reason", EarlyFlakeDetectionTestAbortReason, EarlyFlakeDetectionTestAbortReasonBytes));
456462
}
457463

464+
if (GitPrBaseHeadCommit is not null)
465+
{
466+
processor.Process(new TagItem<string>("git.pull_request.base_branch_head_sha", GitPrBaseHeadCommit, GitPrBaseHeadCommitBytes));
467+
}
468+
458469
if (GitPrBaseCommit is not null)
459470
{
460471
processor.Process(new TagItem<string>("git.pull_request.base_branch_sha", GitPrBaseCommit, GitPrBaseCommitBytes));
@@ -739,6 +750,13 @@ protected override void WriteAdditionalTags(System.Text.StringBuilder sb)
739750
.Append(',');
740751
}
741752

753+
if (GitPrBaseHeadCommit is not null)
754+
{
755+
sb.Append("git.pull_request.base_branch_head_sha (tag):")
756+
.Append(GitPrBaseHeadCommit)
757+
.Append(',');
758+
}
759+
742760
if (GitPrBaseCommit is not null)
743761
{
744762
sb.Append("git.pull_request.base_branch_sha (tag):")

‎tracer/src/Datadog.Trace/Generated/netstandard2.0/Datadog.Trace.SourceGenerators/TagListGenerator/TestSessionSpanTags.g.cs

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ partial class TestSessionSpanTags
8080
private static ReadOnlySpan<byte> EarlyFlakeDetectionTestEnabledBytes => new byte[] { 184, 116, 101, 115, 116, 46, 101, 97, 114, 108, 121, 95, 102, 108, 97, 107, 101, 46, 101, 110, 97, 98, 108, 101, 100 };
8181
// EarlyFlakeDetectionTestAbortReasonBytes = MessagePack.Serialize("test.early_flake.abort_reason");
8282
private static ReadOnlySpan<byte> EarlyFlakeDetectionTestAbortReasonBytes => new byte[] { 189, 116, 101, 115, 116, 46, 101, 97, 114, 108, 121, 95, 102, 108, 97, 107, 101, 46, 97, 98, 111, 114, 116, 95, 114, 101, 97, 115, 111, 110 };
83+
// GitPrBaseHeadCommitBytes = MessagePack.Serialize("git.pull_request.base_branch_head_sha");
84+
private static ReadOnlySpan<byte> GitPrBaseHeadCommitBytes => new byte[] { 217, 37, 103, 105, 116, 46, 112, 117, 108, 108, 95, 114, 101, 113, 117, 101, 115, 116, 46, 98, 97, 115, 101, 95, 98, 114, 97, 110, 99, 104, 95, 104, 101, 97, 100, 95, 115, 104, 97 };
8385
// GitPrBaseCommitBytes = MessagePack.Serialize("git.pull_request.base_branch_sha");
8486
private static ReadOnlySpan<byte> GitPrBaseCommitBytes => new byte[] { 217, 32, 103, 105, 116, 46, 112, 117, 108, 108, 95, 114, 101, 113, 117, 101, 115, 116, 46, 98, 97, 115, 101, 95, 98, 114, 97, 110, 99, 104, 95, 115, 104, 97 };
8587
// GitPrBaseBranchBytes = MessagePack.Serialize("git.pull_request.base_branch");
@@ -139,6 +141,7 @@ partial class TestSessionSpanTags
139141
"test.itr.tests_skipping.type" => IntelligentTestRunnerSkippingType,
140142
"test.early_flake.enabled" => EarlyFlakeDetectionTestEnabled,
141143
"test.early_flake.abort_reason" => EarlyFlakeDetectionTestAbortReason,
144+
"git.pull_request.base_branch_head_sha" => GitPrBaseHeadCommit,
142145
"git.pull_request.base_branch_sha" => GitPrBaseCommit,
143146
"git.pull_request.base_branch" => GitPrBaseBranch,
144147
"pr.number" => PrNumber,
@@ -251,6 +254,9 @@ public override void SetTag(string key, string value)
251254
case "test.early_flake.abort_reason":
252255
EarlyFlakeDetectionTestAbortReason = value;
253256
break;
257+
case "git.pull_request.base_branch_head_sha":
258+
GitPrBaseHeadCommit = value;
259+
break;
254260
case "git.pull_request.base_branch_sha":
255261
GitPrBaseCommit = value;
256262
break;
@@ -455,6 +461,11 @@ public override void EnumerateTags<TProcessor>(ref TProcessor processor)
455461
processor.Process(new TagItem<string>("test.early_flake.abort_reason", EarlyFlakeDetectionTestAbortReason, EarlyFlakeDetectionTestAbortReasonBytes));
456462
}
457463

464+
if (GitPrBaseHeadCommit is not null)
465+
{
466+
processor.Process(new TagItem<string>("git.pull_request.base_branch_head_sha", GitPrBaseHeadCommit, GitPrBaseHeadCommitBytes));
467+
}
468+
458469
if (GitPrBaseCommit is not null)
459470
{
460471
processor.Process(new TagItem<string>("git.pull_request.base_branch_sha", GitPrBaseCommit, GitPrBaseCommitBytes));
@@ -739,6 +750,13 @@ protected override void WriteAdditionalTags(System.Text.StringBuilder sb)
739750
.Append(',');
740751
}
741752

753+
if (GitPrBaseHeadCommit is not null)
754+
{
755+
sb.Append("git.pull_request.base_branch_head_sha (tag):")
756+
.Append(GitPrBaseHeadCommit)
757+
.Append(',');
758+
}
759+
742760
if (GitPrBaseCommit is not null)
743761
{
744762
sb.Append("git.pull_request.base_branch_sha (tag):")

‎tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/CI/CIEnvironmentVariableTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public void GithubEventJsonTest()
161161

162162
reloadEnvironmentData?.Invoke(githubEnvVars, null);
163163
githubEnvVars.HeadCommit.Should().Be("df289512a51123083a8e6931dd6f57bb3883d4c4");
164-
githubEnvVars.PrBaseCommit.Should().Be("52e0974c74d41160a03d59ddc73bb9f5adab054b");
164+
githubEnvVars.PrBaseHeadCommit.Should().Be("52e0974c74d41160a03d59ddc73bb9f5adab054b");
165165
githubEnvVars.PrBaseBranch.Should().Be("main");
166166
githubEnvVars.PrNumber.Should().Be("1");
167167

0 commit comments

Comments
 (0)