Skip to content

Commit 1e5b2db

Browse files
committed
feat(ci): drop Go 1.24, support Go 1.25/1.26
- Remove GOEXPERIMENT=synctest from all CI scripts and workflows - Delete internal/synctest/synctest_go124.go fallback - Remove go1.25 build constraint from internal/synctest/synctest.go - Update GitHub Actions version matrices to 1.25/1.26 - Update GitLab macrobenchmarks to stable=1.26.0, oldstable=1.25.0 - Update Dockerfiles from golang:1.24 to golang:1.25 - Update Makefile checkmake comment Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
1 parent 51e6211 commit 1e5b2db

File tree

21 files changed

+31
-62
lines changed

21 files changed

+31
-62
lines changed

.github/workflows/appsec.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ on:
2727
- 'scripts/**'
2828
env:
2929
DD_APPSEC_WAF_TIMEOUT: 1m
30-
GOEXPERIMENT: synctest # TODO: remove once go1.25 is the minimum supported version
3130
PACKAGES: >-
3231
./appsec/...
3332
./instrumentation/appsec/...
@@ -85,6 +84,7 @@ jobs:
8584
8685
- uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
8786
with:
87+
go-version: stable
8888
cache: false
8989

9090
- name: Cache Go modules
@@ -109,7 +109,7 @@ jobs:
109109
strategy:
110110
matrix:
111111
runs-on: [ macos-14, macos-latest ] # oldest and newest macos runners available
112-
go-version: [ "1.25", "1.24" ]
112+
go-version: [ "1.26", "1.25" ]
113113
fail-fast: true # saving some CI time - macos runners are too long to get
114114
steps:
115115
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
@@ -277,7 +277,7 @@ jobs:
277277
needs: go-mod-caching
278278
strategy:
279279
matrix:
280-
go-version: [ "1.25", "1.24" ]
280+
go-version: [ "1.26", "1.25" ]
281281
distribution: [ trixie, bookworm, alpine ]
282282
platform: [ linux/amd64, linux/arm64 ]
283283

.github/workflows/generate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
- name: Setup Go and development tools
3939
uses: ./.github/actions/setup-go
4040
with:
41-
go-version: ${{ inputs.go-version }}
41+
go-version: ${{ inputs.go-version || 'stable' }}
4242
tools-dir: ${{ github.workspace }}/_tools
4343
tools-bin: ${{ github.workspace }}/bin
4444
- name: Run generator

.github/workflows/lambda-integration-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Set up Go
3636
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
3737
with:
38-
go-version: '1.25'
38+
go-version: '1.26'
3939

4040
- name: Set up Node 22
4141
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0

.github/workflows/main-branch-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
id-token: write
2727
pull-requests: write
2828
with:
29-
go-version: "1.25" # Should be the highest supported version of Go
29+
go-version: "1.26" # Should be the highest supported version of Go
3030
secrets: inherit
3131

3232
warm-repo-cache:
@@ -46,7 +46,7 @@ jobs:
4646
strategy:
4747
matrix:
4848
runs-on: [ macos-latest, windows-latest, ubuntu-latest ]
49-
go-version: [ "1.24", "1.25" ]
49+
go-version: [ "1.25", "1.26" ]
5050
fail-fast: false
5151
uses: ./.github/workflows/multios-unit-tests.yml
5252
with:

.github/workflows/multios-unit-tests.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ on:
2222

2323
env:
2424
DD_APPSEC_WAF_TIMEOUT: 1m # Increase time WAF time budget to reduce CI flakiness
25-
GOEXPERIMENT: synctest # TODO: remove once go1.25 is the minimum supported version
2625

2726
permissions:
2827
contents: read

.github/workflows/pull-request.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- warm-repo-cache
2727
strategy:
2828
matrix:
29-
go-version: [ "1.24", "1.25" ]
29+
go-version: [ "1.25", "1.26" ]
3030
fail-fast: false
3131
uses: ./.github/workflows/unit-integration-tests.yml
3232
with:
@@ -38,7 +38,7 @@ jobs:
3838
strategy:
3939
matrix:
4040
runs-on: [ macos-latest, windows-latest, ubuntu-latest ]
41-
go-version: [ "1.24", "1.25" ]
41+
go-version: [ "1.25", "1.26" ]
4242
fail-fast: false
4343
uses: ./.github/workflows/multios-unit-tests.yml
4444
with:

.github/workflows/smoke-tests.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ on:
2727

2828
env:
2929
TEST_RESULTS: /tmp/test-results # path to where test results will be saved
30-
GOEXPERIMENT: synctest # TODO: remove once go1.25 is the minimum supported version
3130

3231
permissions:
3332
contents: read
@@ -136,7 +135,7 @@ jobs:
136135
- name: Setup Go and development tools
137136
uses: ./.github/actions/setup-go
138137
with:
139-
go-version: "1.24"
138+
go-version: "1.25"
140139
tools-dir: ${{ github.workspace }}/_tools
141140
tools-bin: ${{ github.workspace }}/bin
142141
- name: Run tests
@@ -155,7 +154,7 @@ jobs:
155154
with:
156155
dd-api-key: ${{ secrets.DD_CI_API_KEY }}
157156
path: ${{ env.TEST_RESULTS }}
158-
tags: go:1.24,arch:${{ runner.arch }},os:${{ runner.os }}
157+
tags: go:1.25,arch:${{ runner.arch }},os:${{ runner.os }}
159158
- name: Upload Coverage
160159
if: always()
161160
shell: bash
@@ -179,7 +178,7 @@ jobs:
179178
- name: Setup Go and development tools
180179
uses: ./.github/actions/setup-go
181180
with:
182-
go-version: "1.24"
181+
go-version: "1.25"
183182
tools-dir: ${{ github.workspace }}/_tools
184183
tools-bin: ${{ github.workspace }}/bin
185184
- name: Run generate scripts and check diff

.github/workflows/static-checks.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ env:
3030
# without having to download a newer one.
3131
GOTOOLCHAIN: local
3232
GODEBUG: "x509negativeserial=1"
33-
GOEXPERIMENT: synctest # TODO: remove once go1.25 is the minimum supported version
3433
GOLANGCI_LINT_VERSION: v2.3.0 # NOTICE: Make sure this is synced with the version in the _tools/go.mod file.
3534

3635
permissions:
@@ -49,7 +48,7 @@ jobs:
4948
- name: Setup Go and development tools
5049
uses: ./.github/actions/setup-go
5150
with:
52-
go-version: ${{ inputs.go-version }}
51+
go-version: ${{ inputs.go-version || 'stable' }}
5352
tools-dir: ${{ github.workspace }}/_tools
5453
tools-bin: ${{ github.workspace }}/bin
5554
- name: Copyright
@@ -70,7 +69,7 @@ jobs:
7069
- name: Setup Go and development tools
7170
uses: ./.github/actions/setup-go
7271
with:
73-
go-version: ${{ inputs.go-version }}
72+
go-version: ${{ inputs.go-version || 'stable' }}
7473
tools-dir: ${{ github.workspace }}/_tools
7574
tools-bin: ${{ github.workspace }}/bin
7675
- name: Lint GitHub Actions workflows
@@ -88,7 +87,7 @@ jobs:
8887
- name: Setup Go and development tools
8988
uses: ./.github/actions/setup-go
9089
with:
91-
go-version: ${{ inputs.go-version }}
90+
go-version: ${{ inputs.go-version || 'stable' }}
9291
tools-dir: ${{ github.workspace }}/_tools
9392
tools-bin: ${{ github.workspace }}/bin
9493
- name: Run fixmodules
@@ -108,7 +107,7 @@ jobs:
108107
- name: Setup Go and development tools
109108
uses: ./.github/actions/setup-go
110109
with:
111-
go-version: ${{ inputs.go-version }}
110+
go-version: ${{ inputs.go-version || 'stable' }}
112111
tools-dir: ${{ github.workspace }}/_tools
113112
tools-bin: ${{ github.workspace }}/bin
114113
- name: Update documentation
@@ -128,7 +127,7 @@ jobs:
128127
- name: Setup Go and development tools
129128
uses: ./.github/actions/setup-go
130129
with:
131-
go-version: ${{ inputs.go-version }}
130+
go-version: ${{ inputs.go-version || 'stable' }}
132131
tools-dir: ${{ github.workspace }}/_tools
133132
tools-bin: ${{ github.workspace }}/bin
134133
- name: Format

.github/workflows/unit-integration-tests.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ env:
2121
# without having to download a newer one.
2222
GOTOOLCHAIN: local
2323
GODEBUG: "x509negativeserial=1"
24-
GOEXPERIMENT: synctest # TODO: remove once go1.25 is the minimum supported version
2524
TEST_RESULT_PATH: /tmp/test-results
2625

2726
permissions:
@@ -43,6 +42,10 @@ jobs:
4342
with:
4443
ref: ${{ github.sha }}
4544
clean: false
45+
- uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
46+
with:
47+
go-version: stable
48+
cache: false
4649

4750
- name: Compute Matrix
4851
id: matrix

.gitlab/benchmarks.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
interruptible: true
1010
tags: ["runner:apm-k8s-m8g-metal"]
1111
variables:
12-
GOEXPERIMENT: "synctest" # TODO: remove once go1.25 is the minimum supported version
1312
KUBERNETES_CPU_REQUEST: "48"
1413
KUBERNETES_CPU_LIMIT: "48"
1514
script: |

0 commit comments

Comments
 (0)